Description of problem: Upgrade of Net::DNS to 0.49 and spec file cleanup. Version-Release number of selected component (if applicable): perl-Net-DNS-0.48-3 Actual results / Expected results: I would suggest the attached changes, review it and decide yourself.
Created attachment 112610 [details] Diff of spec files
Created attachment 112611 [details] filter-requires-dns.sh
Sorry Warren, I saw your remove of brp-compress in CVS too late :-(
Please clarify, is there any real benefit to your new filter-requires script replacement?
Maybe, there were a few times discussions about having multiple filtering scripts with the same file name. I thought with this update, it could also solve one of the really unimportant problems. Skip it simply, if you don't agree :)
Two problems... + /usr/lib/rpm/redhat/brp-compress + /usr/lib/rpm/redhat/brp-strip /usr/bin/strip + /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump /usr/bin/strip: unable to copy file '/usr/src/build/549770-i386/install/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/auto/Net/DNS/DNS.so' reason: Permission denied Processing files: perl-Net-DNS-0.49-1 Executing(%doc): /bin/sh -e /usr/src/build/549770-i386/install-tmp/rpm-tmp.51291 + cp -pr README /usr/src/build/549770-i386/install/usr/share/doc/perl-Net-DNS-0.49 + exit 0 error: Couldn't exec /usr/src/build/549770-i386/SOURCES/filter-requires.sh: Permission denied error: Couldn't exec /usr/src/build/549770-i386/SOURCES/filter-requires.sh: Permission denied error: Couldn't exec /usr/src/build/549770-i386/SOURCES/filter-requires.sh: Permission denied error: Couldn't exec /usr/src/build/549770-i386/SOURCES/filter-requires.sh: Permission denied error: Couldn't exec /usr/src/build/549770-i386/SOURCES/filter-requires.sh: Permission denied error: Couldn't exec /usr/src/build/549770-i386/SOURCES/filter-requires.sh: Permission denied getOutputFrom(): Broken pipe Run finished Sat Apr 2 06:47:30 2005 -0500
First is a problem of non-root builds: Add "chmod -R u+w $RPM_BUILD_ROOT/*" as last line of %install, then it should work. Ville already suggested this solution in bug #127025 comment #1. Second is: /usr/src/build/549770-i386/SOURCES/filter-requires.sh has permissions 644 not 755 or similar :-(
We have NO CONTROL over permissions of files going into the SRPM. We somehow avoided this trouble with other packages. What is different now? Please consider using this kind of construct for make test in all of your spec submissions. %check || : make test http://cvs.fedora.us/cgi-bin/cvsweb.cgi/pkg/fedora-rpmdevtools/spectemplate-perl.spec Bring perl modules closer to the spec template if possible. Please checkout from Core CVS again and submit another unidiff. Thank you.
Created attachment 112617 [details] Diff between Core CVS and spec file closer to the template Sorry for the trouble! This really should work now...
If you import executable files into cvs, they remain executable, and you can't change it with the cvs command. Add 'chmod +x %{SOURCE1}' in %prep to work around insufficient permissions.
I suggest taking a look at perl-IPC-Run in Extras CVS, devel branch. It has a dep filtering solution that honors the system rpmbuild setup instead of hardcoding /usr/lib/rpm/find-requires. I just committed some small improvements to the dep filtering implementation there, now it no longer sets _use_internal_dependency_generator to 0.
Please submit a new patch against core CVS based on Ville's suggestion on Comment #11. Ville is the Fedora perl team technical lead.
Created attachment 112908 [details] More specfile improvements Here's an alternative approach: the Win32 and Cygwin specific functionality has been isolated to dedicated modules upstream; excluding them doesn't hurt on Linux, saves some space and gets rid of the troublesome autodeps too. Also included are some other minor fixes. If this patch is applied, filter-requires.sh can be removed from CVS. Purists might say that this patch should also include "ExcludeOS: Win32 Cygwin" or something, but I'm not losing any sleep over that.
build complete. I didn't include the more docs. really trying to prevent any size growth at all in core.