Description of problem: We should turn on the upstream tests in the spec file so that these are run on every build. The only problem is the --noatime option that was added in the 3.1.0 version because the tests won't compile with the patch for this option. This option was added to rsync in Fedora even though it was never approved by the upstream. The --noatime option was added due to this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1233893 But the upstream bug is still unresolved: https://bugzilla.samba.org/show_bug.cgi?id=7249 I guess we'll wait until upstream decides what to do with this option. Version-Release number of selected component (if applicable): rsync-3.1.2 How reproducible: always when building the package with tests on Steps to Reproduce: 1. add %check section into the spec file 2. put make check command into the %check section 3. build the package Actual results: The build will fail with undefined reference to noatime variable Expected results: The build should finish successfully Additional info: It seems that the order in which the source files are compiled in the make check section of the Makefile is wrong. The newly added noatime variable is then regarded as undefined.
This message is a reminder that Fedora 27 is nearing its end of life. On 2018-Nov-30 Fedora will stop maintaining and issuing updates for Fedora 27. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '27'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 27 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 27 changed to end-of-life (EOL) status on 2018-11-30. Fedora 27 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.
Opening this again. There is a new patch in the upstream bug that solves the problem with make check. Adding the patch and enabling the tests. I am keeping the --no-atime option in rsync but this is still NOT approved by the upstream.
Created attachment 1624192 [details] Upgraded patch
FEDORA-2019-c99632a79d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c99632a79d
FEDORA-2019-d457be29c5 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d457be29c5
rsync-3.1.3-10.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c99632a79d
rsync-3.1.3-8.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b54a9b5130
rsync-3.1.3-9.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d457be29c5
rsync-3.1.3-9.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
rsync-3.1.3-8.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
rsync-3.1.3-10.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.