Bug 1536815 - Typo in system-config-firewall rpm spec file
Summary: Typo in system-config-firewall rpm spec file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-firewall
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Eric Garver
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1487337 1731662 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-21 12:44 UTC by H.J. Lu
Modified: 2020-05-01 14:30 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-01 14:30:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description H.J. Lu 2018-01-21 12:44:02 UTC
[root@gnu-skl-1 usr]#  rpm -ql system-config-firewall-base
/etc/sysconfig/system-config-firewall
/usr/@DATADIRNAME@/locale/ar/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/as/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/bg/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/bn/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/bn_IN/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/bs/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ca/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/cs/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/cy/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/da/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/de/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/el/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/en_GB/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/es/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/et/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/fa/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/fi/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/fr/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/gu/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/he/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/hi/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/hr/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/hu/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/hy/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/id/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/is/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/it/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ja/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ka/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/kn/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ko/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ku/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/lo/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/lt/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/lv/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/mai/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/mk/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ml/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/mn/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/mr/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ms/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/my/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/nb/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/nds/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/nl/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/or/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/pa/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/pl/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/pt/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/pt_BR/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ro/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ru/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/si/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/sk/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/sl/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/sq/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/sr/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/sr@latin/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/sv/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ta/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/te/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/tr/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/uk/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/ur/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/vi/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/zh_CN/LC_MESSAGES/system-config-firewall.mo
/usr/@DATADIRNAME@/locale/zh_TW/LC_MESSAGES/system-config-firewall.mo
/usr/sbin/lokkit

@DATADIRNAME@ is a typo.

Comment 1 Frediano Ziglio 2018-05-30 09:24:57 UTC
Not exactly a typo. If you extract the src.rpm and compile every is fine, however running under mock it has the problem. Looking at https://kojipkgs.fedoraproject.org//packages/system-config-firewall/1.2.29/19.fc28/data/logs/noarch/build.log looks like a autoreconf is executed which replace the IT_PROG_INTLTOOL macro in aclocal.m4 (and so configure script) with a version that do not set DATADIRNAME. Note also the line:

autoreconf: configure.in: not using Gettext

in the above build.log.
DATADIRNAME is used in po/Makefile.in.in which is provided by intltool (like the IT_PROG_INTLTOOL macro) however the macro is replaced by autoreconf while po/Makefile.in.in is not replaced causing a version mismatch and the issue the bug is reporting.

Comment 2 Jan Kratochvil 2018-09-10 16:15:56 UTC
*** Bug 1487337 has been marked as a duplicate of this bug. ***

Comment 3 Ben Cotton 2018-11-27 14:38:56 UTC
This message is a reminder that Fedora 27 is nearing its end of life.
On 2018-Nov-30  Fedora will stop maintaining and issuing updates for
Fedora 27. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora  'version' of '27'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 27 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 H.J. Lu 2018-11-27 14:40:19 UTC
Still happen with Fedora 29.

Comment 5 Frediano Ziglio 2018-11-27 15:22:50 UTC
Similar issues at https://kojipkgs.fedoraproject.org//packages/system-config-firewall/1.2.29/21.fc29/data/logs/noarch/build.log, looks like this package is just rebuild but not much updated.

Setting LANG to it_IT.UTF-8 strace ("LANG=it_IT.UTF-8 strace -e open,openat,stat -o trace /usr/bin/system-config-firewall" after a "/bin/systemctl stop firewalld.service") reports these logs:

stat("/usr/share/locale/it_IT.UTF-8/LC_MESSAGES/system-config-firewall.mo", 0x7fff1a1a7c00) = -1 ENOENT (No such file or directory)
stat("/usr/share/locale/it_IT/LC_MESSAGES/system-config-firewall.mo", 0x7fff1a1a7c00) = -1 ENOENT (No such file or directory)
stat("/usr/share/locale/it.UTF-8/LC_MESSAGES/system-config-firewall.mo", 0x7fff1a1a7c00) = -1 ENOENT (No such file or directory)
stat("/usr/share/locale/it/LC_MESSAGES/system-config-firewall.mo", 0x7fff1a1a7c00) = -1 ENOENT (No such file or directory)

confirming the later issue.

Comment 6 Frediano Ziglio 2018-11-27 15:54:14 UTC
Adding intltoolize command before autoreconf fix the issue, so now in the spec file I have:

%build
intltoolize --force
autoreconf --force -v --install --symlink
%configure %{?with_usermode: --enable-usermode} \

Comment 7 Frediano Ziglio 2018-11-27 18:01:21 UTC
Created pull request https://src.fedoraproject.org/rpms/system-config-firewall/pull-request/2

Comment 8 Jérôme Benoit 2018-12-04 18:02:18 UTC
Still here on all Fedora stable versions.

Comment 9 Frediano Ziglio 2019-07-18 08:57:29 UTC
Problem still persist on Fedora 30.

Comment 10 Chris Schanzle 2019-07-20 21:33:05 UTC
*** Bug 1731662 has been marked as a duplicate of this bug. ***

Comment 11 Ben Cotton 2020-04-30 21:31:46 UTC
This message is a reminder that Fedora 30 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '30'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 30 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 12 Frediano Ziglio 2020-05-01 14:30:49 UTC
package not present in fedora 31, closing


Note You need to log in before you can comment on or make changes to this bug.