Bug 153741 - gulm init script should not fail if tag doesn't exist in cluster.conf
gulm init script should not fail if tag doesn't exist in cluster.conf
Product: Red Hat Cluster Suite
Classification: Red Hat
Component: gulm (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Adam "mantis" Manthei
Cluster QE
Depends On:
Blocks: 144795
  Show dependency treegraph
Reported: 2005-04-05 11:29 EDT by Corey Marthaler
Modified: 2009-04-16 15:56 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-04-20 14:32:55 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Corey Marthaler 2005-04-05 11:29:21 EDT
Description of problem:
Starting lock_gulmd:  no <gulm> section detected in /etc/cluster/cluster.conf

A better messages might be:
Starting lock_gulmd: Skipping because no <gulm> section detected in
/etc/cluster/cluster.conf  [OK]

Version-Release number of selected component (if applicable):
[root@tank-03 ~]# lock_gulmd -V
lock_gulmd 1.0-0.pre26 (built Mar 28 2005 18:04:15)
Copyright (C) 2004 Red Hat, Inc.  All rights reserved.

How reproducible:
Comment 1 Adam "mantis" Manthei 2005-04-05 11:40:33 EDT
Except for the fact that lock_gulmd didn't actually startup.  "OK" is just as
wrong as "FAILED".

Trouble shooting working systems that are reporting failures are easier to deal
with than broken systems reporting success.

Will look into a different error message to appease both camps
Comment 2 Adam "mantis" Manthei 2005-04-13 17:15:43 EDT
gulm init.d script now prints WARNING instead of FAILURE.

Checking in gulm/init.d/lock_gulmd;
/cvs/cluster/cluster/gulm/init.d/lock_gulmd,v  <--  lock_gulmd
new revision:; previous revision:
Comment 3 Corey Marthaler 2005-04-14 16:27:01 EDT
where did the "no <gulm> section detected in /etc/cluster/cluster.conf" go?

Now it just says:
Starting lock_gulmd:[WARNING]
Comment 4 Adam "mantis" Manthei 2005-04-20 12:39:21 EDT
> where did the "no <gulm> section detected in /etc/cluster/cluster.conf" go?
The warning message is sent to syslog.

Since lock_gulmd does not start, it should not print "OK".  It instead fails to
start in a manor that is determined to be acceptable (hence why it's exit status
is 0 and not 1) but in a way that still provides the user with a clue that they
might have a configuration problem.

The bug states that lock_gulmd should not fail, so it doesn't.  It just provides
the user with feedback to start looking into what the problem might be.  If they
don't like that message, they should disable lock_gulmd with chkconfig.

It is my opinion that this will be much easier to trouble shoot than pretending
that everything is OK.  
Comment 5 Corey Marthaler 2005-04-20 14:32:55 EDT
I see the message in the syslog, fix verified.

Note You need to log in before you can comment on or make changes to this bug.