Bug 1542869 - libisl: Missing parentheses in call to 'print'
Summary: libisl: Missing parentheses in call to 'print'
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: isl
Version: 27
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dave Malcolm
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-02-07 08:47 UTC by Aldy Hernandez
Modified: 2018-11-30 19:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-30 19:42:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Add parentheses to the two "print" invocations; convert tabs to spaces (3.52 KB, patch)
2018-02-07 11:45 UTC, Dave Malcolm
no flags Details | Diff

Description Aldy Hernandez 2018-02-07 08:47:15 UTC
Description of problem:

While debugging GCC internally, I get the following:

libisl.so*.-gdb.py seems to have some missing parentheses:

  File "/usr/share/gdb/auto-load/usr/lib64/libisl.so.15.1.1-gdb.py", line 67
    print "No isl printer for this type"
                                       ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(print "No isl printer for this type")?

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Build gcc
2. gdb cc1
3. break main
4. run

Actual results:
  File "/usr/share/gdb/auto-load/usr/lib64/libisl.so.15.1.1-gdb.py", line 67
    print "No isl printer for this type"
                                       ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(print "No isl printer for this type")?


Expected results:

A pleasant debugging experience :)


Additional info:

Comment 1 Dave Malcolm 2018-02-07 11:25:27 UTC
Looks like libisl's pretty-printers haven't yet been ported from Python 2 to Python 3 (or, better, to the common subset).

Comment 2 Dave Malcolm 2018-02-07 11:41:15 UTC
There's also:

  File "/usr/share/gdb/auto-load/usr/lib64/libisl.so.15.1.1-gdb.py", line 78
    else:
        ^
TabError: inconsistent use of tabs and spaces in indentation

Am working on a fix.

Comment 3 Dave Malcolm 2018-02-07 11:45:37 UTC
Created attachment 1392649 [details]
Add parentheses to the two "print" invocations; convert tabs to spaces

This patch fixes the error messages on startup.

Tested with gdb-8.0.1-33.fc26.x86_64, which is linked against CPython 3.6.4

Only lightly tested, by directly invoking:
  gdb /usr/lib64/libisl.so.15.1.1
and verifying absence of error messages on startup.  I didn't test the commands.

Comment 4 Dave Malcolm 2018-02-07 11:52:39 UTC
Posted upstream here:
  https://groups.google.com/forum/#!topic/isl-development/3a3L1yMNWXs

Comment 5 Dave Malcolm 2018-02-08 01:30:13 UTC
Looks like the next upstream release is going to fix this, based on a tweaked version of my patch:
  https://groups.google.com/forum/#!topic/isl-development/D4BM4olFvrg

Aldy, is this something that's impacting your work (and thus needs patching), or can we just close this out as UPSTREAM? (and hopefully the patch works for you...)

Comment 6 Aldy Hernandez 2018-02-08 09:49:03 UTC
No worries.

I just didn't want it surviving to the next Fedora release.

Thanks for addressing this quickly.

Comment 7 Ben Cotton 2018-11-27 17:09:52 UTC
This message is a reminder that Fedora 27 is nearing its end of life.
On 2018-Nov-30  Fedora will stop maintaining and issuing updates for
Fedora 27. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora  'version' of '27'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 27 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 8 Ben Cotton 2018-11-30 19:42:07 UTC
Fedora 27 changed to end-of-life (EOL) status on 2018-11-30. Fedora 27 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.