Red Hat Bugzilla – Bug 154462
sensors-detect gives bad advice;here's a little patch
Last modified: 2015-03-04 20:14:45 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050323 Firefox/1.0.2 Fedora/1.0.2-1.3.1
Description of problem:
Running sensors-detect manually gives confusing/bad advice. I might be
advantageous to modify the script slightly regarding file names and explanations
given. As I don't know what the setup on distros other than Red Hat is, this
is a stab in the dark, but here goes.
The script does not check for '/etc/modprobe.conf' which seems to be standard
under 2.6 but uses only 'old style' names - added.
The advice given to the user to modify the boot init script is unnecessary -
the /etc/sysconfig/lm_sensors file contains the list of modules already.
Fixed but only if the script finds it's on a Red Hat system. Also:
sensors -s may have to be added manually. Tell the user.
Note that the Red Hat system is detected by checking for /etc/redhat-release.
Additional explanations regarding /etc/sysconfig/lm_sensors given. Also
a warning saying that some modules might not yet have been ported to 2.6!
Use variables for location of boot script and lm_sensors file. The script
seems to assume that the boot script is always /etc/rc.d/init.d/lm_sensors.
Which might be incorrect, but that's what it did originally.
Putting a GNU copyleft header into /etc/sysconfig/lm_sensors strikes me
as serious overkill. Removed. Yes, I'm arrogant.
Advice to user to copy boot script suppressed on Red Hat systems.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Actual Results: n/a
Expected Results: n/a
Created attachment 112999 [details]
Patch for sensors-detect
I like some parts of the patch, but with 2.9.1 which we now have in FC4 and
later most of the kernel-2.6 issues should be handled properly.
I might put in a trimmed down version of this patch in a later version.
Read ya, Phil