Bug 154713 - 5 * undefined C code
5 * undefined C code
Status: CLOSED UPSTREAM
Product: Fedora
Classification: Fedora
Component: HelixPlayer (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: John (J5) Palmieri
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-13 13:50 EDT by David Binderman
Modified: 2013-03-13 00:48 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-04-20 17:07:19 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description David Binderman 2005-04-13 13:50:25 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)

Description of problem:

I just tried to compile HelixPlayer-1.0.3-4 from Redhat
Fedora Core development tree

The compiler said

1.

hxaudses.cpp:1779: warning: operation on 'pShortBuf' may be undefined

The source code is

            *pOutUCharBuf++ = (UCHAR)   (
                                ((LONG32) ((*pShortBuf++  + 32768L) >> 8) +
                                 (LONG32) ((*pShortBuf++  + 32768L) >> 8))/2
                                        );

Clearly undefined code. Suggest code rework.

2.

hxaudses.cpp:1787: warning: operation on 'pShortBuf' may be undefined

Duplicate.

3.

pxjpgrnd.cpp:1145: warning: operation on 'pPix' may be undefined

The source code is

	*pPix++ = (*pPix & 0x00FFFFFF) | ulMediaAlpha;

More undefined code. Suggest code rework.

4.

pxjpgrnd.cpp:1195: warning: operation on 'pPix' may be undefined
pxjpgrnd.cpp:1200: warning: operation on 'pPix' may be undefined

Duplicates

I just tried to compile HelixPlayer-1.0.3-4 from Redhat
Fedora Core development tree

The compiler said

1.

hxaudses.cpp:1779: warning: operation on 'pShortBuf' may be undefined

The source code is

            *pOutUCharBuf++ = (UCHAR)   (
                                ((LONG32) ((*pShortBuf++  + 32768L) >> 8) +
                                 (LONG32) ((*pShortBuf++  + 32768L) >> 8))/2
                                        );

Clearly undefined code. Suggest code rework.

2.

hxaudses.cpp:1787: warning: operation on 'pShortBuf' may be undefined

Duplicate.

3.

pxjpgrnd.cpp:1145: warning: operation on 'pPix' may be undefined

The source code is

	*pPix++ = (*pPix & 0x00FFFFFF) | ulMediaAlpha;

More undefined code. Suggest code rework.

4.

pxjpgrnd.cpp:1195: warning: operation on 'pPix' may be undefined
pxjpgrnd.cpp:1200: warning: operation on 'pPix' may be undefined

Duplicates


Version-Release number of selected component (if applicable):
HelixPlayer-1.0.3-4 

How reproducible:
Always

Steps to Reproduce:
1. compile the code with flag -Wall
2.
3.
  

Additional info:
Comment 1 John (J5) Palmieri 2005-04-13 18:10:01 EDT
This should be filed with the Helix Player developers.
Comment 2 David Binderman 2005-04-14 07:04:53 EDT
>This should be filed with the Helix Player developers.

I tried to do this, but the helixplayer homepage wouldn't let me.
Maybe you would have better luck.

I think it would be pretty easy to brew up a suggested patch to 
fix these compiler warnings, while we wait for the helix player pages
to sort themselves out.

Suggest carry patch forward into new versions for Fedora.
Comment 3 John (J5) Palmieri 2005-04-14 11:04:38 EDT
Feel free to submit a patch.  I'm busy with crashers and the like for FC4 so
this is low in my queue.  Are you sure this codepath is even used or is just
cruft laying around that developers haven't taken out yet?  I'll file the bug
upstream.
Comment 4 David Binderman 2005-04-15 07:40:50 EDT
>Are you sure this codepath is even used 

I have no idea. I just compiled the code.

>I'll file the bug upstream.

Thanks

Note You need to log in before you can comment on or make changes to this bug.