Spec URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00726557-cava/cava.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00726557-cava/cava-0.6.0-3.fc27.src.rpm Description: C.A.V.A. is a bar spectrum audio visualizer for the Linux terminal using ALSA, pulseaudio or fifo buffer for input. Fedora Account System Username:larsks
>URL: https://github.com/karlstav/cava >Source0: https://github.com/karlstav/%{name}/... Instead of repeating this, just start Source0 with %{url}. >Source0: https://github.com/karlstav/%{name}/archive/%{version}.tar.gz?/%{name}-%{version}.tar.gz Use "/archive/%{version}/%{name}-%{version}.tar.gz" instead. >%{_libdir}/libiniparser.so.4* Bundling libraries should be avoided. https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries >/usr/share/consolefonts/cava.psf This should be "%{_datadir}/consolefonts/cava.psf". Also, the "consolefonts" directory is not owned by the package. The package must either own the directory, or have a Requires: on another package that owns it.
Thanks for the comments. I hadn't realized that iniparser was actually an upstream project. It turns out that cava only uses that if it's not already available on the system, so simply adding iniparser-devel to the buildrequirements takes care of that problem.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00726716-cava/cava.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00726716-cava/cava-0.6.0-5.fc27.src.rpm I've updated the package based on Iwicki's comments.
- Not needed: %defattr(-,root,root)
Spec URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727165-cava/cava.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727165-cava/cava-0.6.0-6.fc27.src.rpm I've updated the package based on Robert-André's comments.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727168-cava/cava.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727168-cava/cava-0.6.0-7.fc27.src.rpm While testing the previous fixes I realized that a typo had crept into the URL field.
- Don't mix tabs and spaces: cava.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 1) i.e.: BuildRequires: iniparser-devel Package otherwise approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 35 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/cava/review-cava/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/consolefonts (console-setup, cmatrix) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cava-0.6.0-7.fc29.x86_64.rpm cava-debuginfo-0.6.0-7.fc29.x86_64.rpm cava-debugsource-0.6.0-7.fc29.x86_64.rpm cava-0.6.0-7.fc29.src.rpm cava.x86_64: W: only-non-binary-in-usr-lib cava.x86_64: W: no-manual-page-for-binary cava cava-debugsource.x86_64: W: no-documentation cava.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 1) 4 packages and 0 specfiles checked; 0 errors, 4 warnings.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727290-cava/cava.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/larsks/cava/fedora-27-x86_64/00727290-cava/cava-0.6.0-8.fc27.src.rpm I have corrected the tabs/spaces issue. Thanks!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cava
cava-0.6.0-8.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9aef134434
cava-0.6.0-8.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-05a23d7cff
cava-0.6.0-8.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f26830a055
cava-0.6.0-8.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f26830a055
cava-0.6.0-8.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-05a23d7cff
cava-0.6.0-8.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9aef134434
cava-0.6.0-8.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
cava-0.6.0-8.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
cava-0.6.0-8.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.