Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/musuruan/gcompris-qt/gcompris-qt.git/plain/gcompris-qt.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/musuruan/gcompris-qt/fedora-rawhide-x86_64/00713329-gcompris-qt/gcompris-qt-0.81-2.fc28.src.rpm Description: GCompris-Qt is an educational software suite comprising of numerous activities for children aged 2 to 10. Some of the activities are game orientated, but nonetheless still educational. Currently, GCompris offers in excess of 100 activities. New activities can be added, and an activity can implement its own game scheme. This version is a rewrite of GCompris using the QtQuick technology. Fedora Account System Username: musuruan
- Use cmake goodies for your dependencies: BuildRequires: cmake BuildRequires: extra-cmake-modules BuildRequires: cmake(Qt5Qml) BuildRequires: cmake(Qt5Quick) BuildRequires: cmake(Qt5Gui) BuildRequires: cmake(Qt5Multimedia) BuildRequires: cmake(Qt5Core) BuildRequires: cmake(Qt5Svg) BuildRequires: cmake(Qt5Xml) BuildRequires: cmake(Qt5XmlPatterns) BuildRequires: cmake(Qt5LinguistTools) BuildRequires: cmake(Qt5Sensors) BuildRequires: gettext BuildRequires: desktop-file-utils BuildRequires: libappstream-glib - Got various CC-BY and CC-BY-SA, also one MPL 2.0 and SIL for the fonts *No copyright* CC by (v2.0) --------------------------- gcompris-qt-0.81/src/activities/categorization/resource/images/others/README gcompris-qt-0.81/src/activities/categorization/resource/images/renewable/README gcompris-qt-0.81/src/activities/categorization/resource/images/tools/README *No copyright* CC by (v3.0) --------------------------- gcompris-qt-0.81/src/activities/explore_world_animals/resource/animals/README *No copyright* CC0 ------------------ gcompris-qt-0.81/src/activities/target/resource/README *No copyright* GPL ------------------ gcompris-qt-0.81/src/activities/erase/resource/README gcompris-qt-0.81/src/activities/paintings/resource/image/README *No copyright* MPL (v2.0) ------------------------- gcompris-qt-0.81/src/activities/checkers/LICENSE *No copyright* Public domain ---------------------------- gcompris-qt-0.81/src/activities/chess/engine.js CC by (v2.0) ------------ gcompris-qt-0.81/src/activities/categorization/resource/images/fishes/README gcompris-qt-0.81/src/activities/categorization/resource/images/monuments/README CC by (v2.5) ------------ gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_a1.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_a2.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_a3.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_a4.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_b1.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_b2.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_b3.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_b4.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_c1.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_c2.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_c3.png gcompris-qt-0.81/src/activities/paintings/resource/image/Michelangelo_Pieta_c4.png CC by (v3.0) ------------ gcompris-qt-0.81/src/core/resource/fonts/OpenDyslexic-Regular.otf gcompris-qt-0.81/src/core/resource/fonts/README-OpenDyslexic.txt CC by-sa -------- gcompris-qt-0.81/src/core/resource/README CC by-sa (v3.0) --------------- gcompris-qt-0.81/src/activities/drawletters/resource/README gcompris-qt-0.81/src/activities/drawnumbers/resource/README CC by-sa (v4.0) --------------- gcompris-qt-0.81/src/activities/README gcompris-qt-0.81/src/activities/algebra_by/resource/README gcompris-qt-0.81/src/activities/algorithm/resource/README gcompris-qt-0.81/src/activities/align4-2players/resource/README gcompris-qt-0.81/src/activities/babymatch/resource/README gcompris-qt-0.81/src/activities/balancebox/resource/README gcompris-qt-0.81/src/activities/ballcatch/resource/README gcompris-qt-0.81/src/activities/bargame/resource/README gcompris-qt-0.81/src/activities/braille_alphabets/resource/README gcompris-qt-0.81/src/activities/braille_fun/resource/README gcompris-qt-0.81/src/activities/canal_lock/resource/README gcompris-qt-0.81/src/activities/categorization/resource/README gcompris-qt-0.81/src/activities/categorization/resource/images/alphabets/README gcompris-qt-0.81/src/activities/categorization/resource/images/numbers/README gcompris-qt-0.81/src/activities/checkers/resource/README gcompris-qt-0.81/src/activities/chess/resource/README gcompris-qt-0.81/src/activities/click_on_letter/resource/README gcompris-qt-0.81/src/activities/clockgame/resource/README gcompris-qt-0.81/src/activities/color_mix/resource/README gcompris-qt-0.81/src/activities/crane/resource/README gcompris-qt-0.81/src/activities/crane/resource/letters/README gcompris-qt-0.81/src/activities/fifteen/resource/README gcompris-qt-0.81/src/activities/followline/resource/README gcompris-qt-0.81/src/activities/football/resource/README gcompris-qt-0.81/src/activities/gletters/resource/README gcompris-qt-0.81/src/activities/graph-coloring/resource/shapes/README gcompris-qt-0.81/src/activities/guesscount/resource/README gcompris-qt-0.81/src/activities/hangman/resource/README gcompris-qt-0.81/src/activities/hanoi_real/resource/README gcompris-qt-0.81/src/activities/intro_gravity/resource/README gcompris-qt-0.81/src/activities/land_safe/resource/README gcompris-qt-0.81/src/activities/maze/resource/README gcompris-qt-0.81/src/activities/memory/resource/README gcompris-qt-0.81/src/activities/menu/resource/README gcompris-qt-0.81/src/activities/mining/resource/README gcompris-qt-0.81/src/activities/nine_men_morris/resource/README gcompris-qt-0.81/src/activities/penalty/resource/README gcompris-qt-0.81/src/activities/planegame/resource/README gcompris-qt-0.81/src/activities/readingh/resource/README gcompris-qt-0.81/src/activities/reversecount/resource/README gcompris-qt-0.81/src/activities/share/resource/README gcompris-qt-0.81/src/activities/smallnumbers/resource/README gcompris-qt-0.81/src/activities/sudoku/resource/README gcompris-qt-0.81/src/activities/superbrain/resource/README gcompris-qt-0.81/src/activities/tic_tac_toe/resource/README gcompris-qt-0.81/src/activities/wordsgame/resource/README gcompris-qt-0.81/src/core/resource/bonus/README SIL (v1.1) ---------- gcompris-qt-0.81/src/core/resource/fonts/Andika-R.otf gcompris-qt-0.81/src/core/resource/fonts/OFL.txt Please adjust the license field accordingly. - Split the data into a noarch subpackages: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 97525760 bytes in /usr/share gcompris-qt-0.81-2.fc29.x86_64.rpm:97525760 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "Apache (v2.0)", "CC by-sa (v4.0)", "GPL (v3 or later)", "Unknown or generated", "*No copyright* GPL", "*No copyright* CC by (v3.0)", "CC by-sa (v3.0)", "SIL (v1.1)", "CC0", "*No copyright* Public domain", "CC by-sa", "CC by (v2.5)", "*No copyright* CC0", "*No copyright* CC by (v2.0)", "CC by (v2.0)", "GPL (v2.1) LGPL (v2.1)", "*No copyright* MPL (v2.0)", "CC by (v3.0)". 3589 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review /gcompris-qt/review-gcompris-qt/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 97525760 bytes in /usr/share gcompris-qt-0.81-2.fc29.x86_64.rpm:97525760 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: gcompris-qt-0.81-2.fc29.x86_64.rpm gcompris-qt-debuginfo-0.81-2.fc29.x86_64.rpm gcompris-qt-debugsource-0.81-2.fc29.x86_64.rpm gcompris-qt-0.81-2.fc29.src.rpm gcompris-qt.x86_64: W: only-non-binary-in-usr-lib gcompris-qt.x86_64: W: no-manual-page-for-binary gcompris-qt gcompris-qt-debugsource.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
And now 0.90 is available. http://gcompris.net/newsall-en.html#2018-03-13 Don't you love when this happens in the middle of a review? ;-)
With luck, a simple bump will work.
Hi! I've updated my package to v0.90 and I included the required changes (and others too) but I missed the time to test it. I'm afraid you'll have to wait a bit. BR, Andrea
I have two testers eager to do their work, although this could be considered child labor (6 and 4 years respectively). :-) For some reason :-D they are only allowed to work on the weekend, so take your time. FWIW the 0.81 worked flawlessly in their intensive testing. :-)
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/musuruan/gcompris-qt/gcompris-qt.git/plain/gcompris-qt.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/musuruan/gcompris-qt/fedora-rawhide-x86_64/00732281-gcompris-qt/gcompris-qt-0.90-1.fc29.src.rpm Changelog: - Updated to new upstream release - Made a separate package for activities - Added gcc-c++ dependency - Added kf5-kdoctools-devel to BR to enable the documentation
Package approved.
Thanks for the review!
(fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gcompris-qt
Imported and built.
I tried different development games when I was 10 years old and they really helped me improve my educational process and school studies. My favorite discovery is an online service that helps me do my math homework. I am about something that makes studying easier and this is https://edubirdie.com/do-my-math-homework because it is a platform with only expert writers and professional researchers so my learning process can become easier. It is important to create such quality study software and websites not only for young children but also for adult students.