Bug 155891 - kernel dm-mpath: Decode any SCSI sense data if no hw_handler
kernel dm-mpath: Decode any SCSI sense data if no hw_handler
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: device-mapper-multipath (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Alasdair Kergon
: FutureFeature
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-25 10:12 EDT by Lars Marowsky-Bree
Modified: 2011-02-09 16:54 EST (History)
7 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2011-02-09 16:54:29 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Proposed patch (890 bytes, patch)
2005-04-26 06:54 EDT, Lars Marowsky-Bree
no flags Details | Diff

  None (edit)
Description Lars Marowsky-Bree 2005-04-25 10:12:13 EDT
If no hw-handler is loaded, the dm_scsi_error_handler is never called. Wouldn't
it be sane to always call as the default error decoder it if no explicit
hw-handler is in place? It would only change the default behaviour in case SCSI
sense data was available, so it'd be pretty safe.

Given that probably >90% of all multipath deployments are going to be based on
SCSI, I think that would make a lot of sense.
Comment 1 Lars Marowsky-Bree 2005-04-26 06:54:29 EDT
Created attachment 113662 [details]
Proposed patch

How about this one.
Comment 2 Alasdair Kergon 2005-05-04 09:58:59 EDT
Seems a reasonable thing to do.
Comment 3 Alasdair Kergon 2005-05-04 10:01:19 EDT
If it ever causes problems in the future, we can simply move it into a SCSI
hw_handler and expect userspace to choose it if there isn't a more-specific one
to use.
Comment 4 Alasdair Kergon 2005-05-04 10:07:11 EDT
Adding to next -udm.
Comment 6 Alasdair Kergon 2011-02-09 16:54:29 EST
Old bz, superceded by hardware handler restructuring

Note You need to log in before you can comment on or make changes to this bug.