Bug 156373 - shell_cmd should use waitpid instead of wait
shell_cmd should use waitpid instead of wait
Product: Fedora
Classification: Fedora
Component: tcp_wrappers (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tomas Janousek
David Lawrence
: 157204 (view as bug list)
Depends On:
  Show dependency treegraph
Reported: 2005-04-29 11:03 EDT by Francis Montagnac
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version: tcp_wrappers-7.6-46.fc8
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-28 09:53:56 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Francis Montagnac 2005-04-29 11:03:36 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041220

Description of problem:

The shell_cmd function in shell_cmd.c does the following loop to
wait for its command to terminate:

  while ((wait_pid = wait((int *) 0)) != -1 && wait_pid != child_pid)

Having now the waitpid primitive, it would be safer to use it instead:

  waitpid(child_pid, (int *) 0, 0)

otherwise an application linked with tcp_wrappers and needing to get
the exit status of its children may fail because of that loop in
shell_cmd, if /etc/hosts.allow is setup to fork a command for this

That happened on our site with am-utils (amd and amq).

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. acces to many automount points
2. tell amd to unmount them with "amq -u"
3. repeat 1. end 2.

Additional info:
Comment 1 Thomas Woerner 2005-05-11 11:08:29 EDT
*** Bug 157204 has been marked as a duplicate of this bug. ***
Comment 2 Matthew Miller 2006-07-10 16:17:18 EDT
Fedora Core 3 is now maintained by the Fedora Legacy project for security
updates only. If this problem is a security issue, please reopen and
reassign to the Fedora Legacy product. If it is not a security issue and
hasn't been resolved in the current FC5 updates or in the FC6 test
release, reopen and change the version to match.

Thank you!
Comment 3 Tomas Janousek 2007-05-28 09:53:56 EDT
This should be fixed in rawhide.

Note You need to log in before you can comment on or make changes to this bug.