Created attachment 1419154 [details]
COPR builder log with compile error in gdal_priv.h

Description of problem:

I am trying to compile PDAL on COPR. The compilation fails due to the rather old GDAL in F26 and F27 which lacks a later bugfix.

Indeed it commonly compiles but due to Fedora's -Werror=pedantic setting the warning is turned into a compiler error, see attachment (yet available at
https://copr-be.cloud.fedoraproject.org/results/neteler/pdal/fedora-27-x86_64/00738791-PDAL/builder-live.log):

...
/usr/bin/c++  -DUNIX -Dpdal_base_EXPORTS -I/builddir/build/BUILD/PDAL-1.7.0-src/vendor/gtest/include -I/builddir/build/BUILD/PDAL-1.7.0-src/vendor/gtest -I/builddir/build/BUILD/PDAL-1.7.0-src -I/builddir/build/BUILD/PDAL-1.7.0-src/include -I/builddir/build/BUILD/PDAL-1.7.0-src/vendor -I/builddir/build/BUILD/PDAL-1.7.0-src/vendor/eigen -I/builddir/build/BUILD/PDAL-1.7.0-src/vendor/pdalboost -I/usr/include/gdal -I/usr/include/libgeotiff -isystem /usr/local/include -I/usr/include/libxml2  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -DNDEBUG -fPIC   -std=c++11 -Wno-implicit-fallthrough -Wno-int-in-bool-context -Wno-dangling-else -Wno-noexcept-type -Wextra -Wpedantic -Werror -Wall -Wno-unused-parameter -Wno-unused-variable -Wpointer-arith -Wcast-align -Wcast-qual -Wredundant-decls -Wno-long-long -Wno-unknown-pragmas -Wno-deprecated-declarations -o CMakeFiles/pdal_base.dir/filters/ColorinterpFilter.cpp.o -c /builddir/build/BUILD/PDAL-1.7.0-src/filters/ColorinterpFilter.cpp
In file included from /builddir/build/BUILD/PDAL-1.7.0-src/pdal/GDALUtils.hpp:51:0,
                 from /builddir/build/BUILD/PDAL-1.7.0-src/filters/ColorinterpFilter.hpp:43,
                 from /builddir/build/BUILD/PDAL-1.7.0-src/filters/ColorinterpFilter.cpp:35:
/usr/include/gdal/gdal_priv.h:110:54: error: extra ';' [-Werror=pedantic]
     CPL_DISALLOW_COPY_ASSIGN(GDALMultiDomainMetadata);
                                                      ^
/usr/include/gdal/gdal_priv.h:229:51: error: extra ';' [-Werror=pedantic]
     CPL_DISALLOW_COPY_ASSIGN(GDALDefaultOverviews);
                                                   ^
/usr/include/gdal/gdal_priv.h:269:43: error: extra ';' [-Werror=pedantic]
     CPL_DISALLOW_COPY_ASSIGN(GDALOpenInfo);
                                           ^
/usr/include/gdal/gdal_priv.h:564:42: error: extra ';' [-Werror=pedantic]
     CPL_DISALLOW_COPY_ASSIGN(GDALDataset);
                                          ^
/usr/include/gdal/gdal_priv.h:651:46: error: extra ';' [-Werror=pedantic]
     CPL_DISALLOW_COPY_ASSIGN(GDALRasterBlock);
                                              ^
/usr/include/gdal/gdal_priv.h:925:45: error: extra ';' [-Werror=pedantic]
     CPL_DISALLOW_COPY_ASSIGN(GDALRasterBand);
                                             ^
/usr/include/gdal/gdal_priv.h:1126:41: error: extra ';' [-Werror=pedantic]
     CPL_DISALLOW_COPY_ASSIGN(GDALDriver);
                                         ^

Affected are F26 and F27 since an older GDAL 2.1 is provided.

Solution:
This declaration issue got fixed in 2016 by GDAL Changeset 35751:
"Remove semi-colon at end of use of CPL_DISALLOW_COPY_ASSIGN macro (patch by behrisch, fixes https://trac.osgeo.org/gdal/ticket/6685)"

Please fix GDAL in F26 and F27 accordingly with this "trivial" patch in order to deliver PDAL COPR packages. Thanks!