Bug 1566841 - Better error message required for a size specified in /kilo-or-like/ bytes
Summary: Better error message required for a size specified in /kilo-or-like/ bytes
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat
Component: gluster-block
Version: cns-3.9
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Bhumika Goyal
QA Contact: Rahul Hinduja
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-04-13 05:56 UTC by Sweta Anandpara
Modified: 2018-11-19 09:04 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-19 09:04:04 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Sweta Anandpara 2018-04-13 05:56:15 UTC
Description of problem:
=======================
With BZ 1545049, we accept block sizes specified only as KiB, MiB, GiB and the like.. plus anything specified as 1G would get defaulted to 1GiB and would succeed. Anything specified as 1MB/1GB and the like, will fail with an error. This bugzilla is to improve the error message displayed, mentioning the 'why' a seemingly logical and widely used unit like 1MB/1GB is termed as an incorrect size, along with nudging/educating the user the accepted unit of size in 'gluster-block create' command.

With talks of considering to support gluster-block with stand-alone RHGS, all the more reason to have a good usability of block storage functionality. 

'man gluster-block' does talk about the accepted size units in create command, but nowhere else the same information pops up - neither 'gluster-block create help' nor 'gluster-block create' command specified with size incorrectly.


Version-Release number of selected component (if applicable):
=============================================================
glusterfs-3.12.2-7
gluster-block-0.2.1-17
tcmu-runner-1.2.0-18

How reproducible:
================
Always


Additional info:
================
[root@dhcp47-50 ~]# gluster-block create ozone/ob8 ha 1 prealloc full 10.70.47.55 1KB
'<size>' is incorrect
gluster-block create <volname/blockname> [ha <count>] [auth <enable|disable>] [prealloc <full|no>] [storage <filename>] [ring-buffer <size-in-MB-units>] <HOST1[,HOST2,...]> <size> [--json*]
[root@dhcp47-50 ~]#

Comment 4 Amar Tumballi 2018-11-19 09:04:04 UTC
Not a focus in the product, and we would take it up UPSTREAM.


Note You need to log in before you can comment on or make changes to this bug.