Bug 1579236 - mvn_install macro seems to be doing something weird to file permissions
Summary: mvn_install macro seems to be doing something weird to file permissions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xmvn
Version: 29
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-05-17 08:45 UTC by Mat Booth
Modified: 2019-04-09 18:44 UTC (History)
8 users (show)

Fixed In Version: xmvn-3.0.0-17.fc28 xmvn-3.0.0-18.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-09 18:44:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Source RPM Reproducer (6.37 KB, application/x-rpm)
2018-05-17 08:45 UTC, Mat Booth
no flags Details

Description Mat Booth 2018-05-17 08:45:10 UTC
Created attachment 1437840 [details]
Source RPM Reproducer

Description of problem:

I am seeing some files be installed with permissions of 600 where they used to get permissions of 644

This seems to be a change in behaviour that is breaking the Eclipse installation on F29 because these files are owned by root, so regular users no longer have read permission.

I guess this is happening since javapackages-tools-5.1.0-1.fc29

Consider the attached SRPM, which has this section:


%install
JAR=%{buildroot}%{_prefix}/lib/eclipse/plugins/test.jar
install -D %SOURCE0 $JAR
ls -l $JAR
%mvn_artifact "org.eclipse.osgi:test:jar:1" $JAR
%mvn_install
ls -l $JAR


Built on F28, the final permissions of $JAR are 644, but when built on recent F29, the final permissions of $JAR are 600.

Was this an intentional change?

Comment 1 Mikolaj Izdebski 2018-05-17 10:12:00 UTC
That's definitely not intentional. It looks like a bug in XMvn introduced in https://github.com/fedora-java/xmvn/pull/27
I'll try to fix it later today.

Comment 2 Severin Gehwolf 2018-05-18 09:06:11 UTC
Note that the unpush of the update causes byteman to fail to build. See bug 1579749. Can we get xmvn-3.0.0-15 pushed as an update? The relevant PR seems only in xmvn-3.0.0-16.

Comment 3 Mikolaj Izdebski 2018-05-18 09:27:34 UTC
My intention was to only unpush the update, I'm not sure why buildroot override was untagged.

Anyway this issue is fixed upstream now in https://github.com/fedora-java/xmvn/pull/31
I will submit new update and override fixing both problems.

Comment 4 Mikolaj Izdebski 2018-05-18 09:39:13 UTC
Fixed in xmvn-3.0.0-18

Comment 5 Fedora Update System 2018-05-18 09:54:32 UTC
xmvn-3.0.0-17.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-00031e9c1c

Comment 6 Fedora Update System 2018-05-18 09:54:46 UTC
xmvn-3.0.0-17.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-00031e9c1c

Comment 7 Fedora Update System 2018-05-19 04:19:47 UTC
xmvn-3.0.0-17.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-00031e9c1c

Comment 8 Fedora Update System 2018-05-28 15:24:04 UTC
xmvn-3.0.0-17.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Jan Kurik 2018-08-14 11:22:55 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.


Note You need to log in before you can comment on or make changes to this bug.