Description of problem: The Barometer project is complementary to the Doctor project to build the fault management framework with Apex installer. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: https://wiki.opnfv.org/display/fastpath/Barometer+Home https://wiki.opnfv.org/display/apex
Where's source code?
Added the source code for puppet-barometer
Repo is missing LICENSE file, see https://github.com/opnfv/puppet-barometer/issues/1
LICENSE file has been added in https://github.com/opnfv/puppet-barometer/commit/5c5dfe6a2c1383d01a8dbdb8f6072402b3e492df
$ licensecheck -r . ./.gitreview: *No copyright* UNKNOWN ./LICENSE: Apache (v2.0) ./README.md: *No copyright* UNKNOWN ./metadata.json: *No copyright* UNKNOWN ./setup.py: Apache (v2.0) GENERATED FILE ./test-requirements.txt: *No copyright* UNKNOWN ./tox.ini: *No copyright* UNKNOWN ./manifests/collectd.pp: Apache (v2.0) ./manifests/config.pp: *No copyright* UNKNOWN ./manifests/db.pp: *No copyright* UNKNOWN ./manifests/init.pp: *No copyright* UNKNOWN ./manifests/logging.pp: *No copyright* UNKNOWN ./manifests/params.pp: *No copyright* UNKNOWN ./manifests/policy.pp: *No copyright* UNKNOWN ./manifests/rdt.pp: Apache (v2.0) ./spec/shared_examples.rb: *No copyright* UNKNOWN ./templates/aodh.conf.erb: Apache (v2.0) ./templates/collectd-ceil.conf.erb: Apache (v2.0) ./templates/collectd-gnocchi.conf.erb: *No copyright* UNKNOWN ./templates/collectd.conf.erb: Apache (v2.0) ./templates/hugepages.conf.erb: Apache (v2.0) ./templates/intel_rdt.conf.erb: Apache (v2.0) ./templates/logfile.conf.erb: Apache (v2.0) ./templates/mcelog-client.conf.erb: Apache (v2.0) ./templates/mcelog.conf.erb: Apache (v2.0) ./templates/ovs_events.conf.erb: *No copyright* UNKNOWN ./templates/ovs_stats.conf.erb: *No copyright* UNKNOWN ./templates/pqos.conf.erb: Apache (v2.0) ./templates/snmp_agent.conf.erb: Apache (v2.0) ./tests/init.pp: *No copyright* UNKNOWN ./manifests/db/mysql.pp: UNKNOWN ./manifests/db/postgresql.pp: UNKNOWN ./manifests/db/sync.pp: *No copyright* UNKNOWN ./manifests/keystone/auth.pp: *No copyright* UNKNOWN ./manifests/keystone/authtoken.pp: *No copyright* UNKNOWN ./releasenotes/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE ./releasenotes/source/index.rst: *No copyright* UNKNOWN ./releasenotes/source/unreleased.rst: *No copyright* UNKNOWN ./spec/classes/barometer_db_mysql_spec.rb: *No copyright* UNKNOWN ./spec/classes/barometer_db_postgresql_spec.rb: *No copyright* UNKNOWN ./spec/classes/barometer_db_spec.rb: *No copyright* UNKNOWN ./spec/classes/barometer_db_sync_spec.rb: *No copyright* UNKNOWN ./spec/classes/barometer_keystone_auth_spec.rb: *No copyright* UNKNOWN ./spec/classes/barometer_keystone_authtoken_spec.rb: *No copyright* UNKNOWN ./spec/classes/barometer_logging_spec.rb: *No copyright* UNKNOWN ./spec/classes/barometer_policy_spec.rb: *No copyright* UNKNOWN ./lib/puppet/type/barometer_config.rb: *No copyright* UNKNOWN ./spec/unit/type/barometer_config_spec.rb: *No copyright* UNKNOWN ./lib/puppet/provider/barometer_config/ini_setting.rb: *No copyright* UNKNOWN ./spec/unit/provider/barometer_config/ini_setting_spec.rb: *No copyright* UNKNOWN License is Apache v2.0.
Using https://logs.rdoproject.org/29/15929/5/check/legacy-DLRN-rpmbuild/0f00b12/buildset/centos/current/puppet-barometer-0.0.1-0.20180910185305.5c5dfe6.el7.src.rpm for fedora-review.
Review notes: - The "rm -rf %{buildroot}" is indeed present and not necessary, however the rest of Puppet modules, created using a script, also contain it. So we can fix that post-merge. - Source0 and %global notes are expected, since the source RPM was generated by DLRN. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 25 files have unknown license. Detailed output of licensecheck in /tmp/puppet- barometer/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/openstack-puppet/modules, /usr/share/openstack-puppet [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/openstack- puppet/modules, /usr/share/openstack-puppet [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [-]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 0.0.1 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: puppet-barometer-0.0.1-0.20180910185305.5c5dfe6.el7.noarch.rpm puppet-barometer-0.0.1-0.20180910185305.5c5dfe6.el7.src.rpm puppet-barometer.noarch: E: explicit-lib-dependency puppet-stdlib puppet-barometer.noarch: E: no-changelogname-tag puppet-barometer.noarch: W: no-documentation puppet-barometer.noarch: E: wrong-script-interpreter /usr/share/openstack-puppet/modules/barometer/setup.py /usr/bin/env python puppet-barometer.noarch: E: non-executable-script /usr/share/openstack-puppet/modules/barometer/setup.py 644 /usr/bin/env python puppet-barometer.src: E: no-changelogname-tag puppet-barometer.src: W: invalid-url Source0: 0.0.1-0.20180910185305.5c5dfe6.tar.gz 2 packages and 0 specfiles checked; 5 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- puppet-barometer.noarch: E: explicit-lib-dependency puppet-stdlib puppet-barometer.noarch: E: no-changelogname-tag puppet-barometer.noarch: W: invalid-url URL: https://wiki.opnfv.org/display/fastpath/ <urlopen error [Errno -2] Name or service not known> puppet-barometer.noarch: W: no-documentation puppet-barometer.noarch: E: non-executable-script /usr/share/openstack-puppet/modules/barometer/setup.py 0644L /usr/bin/env 1 packages and 0 specfiles checked; 3 errors, 2 warnings. Requires -------- puppet-barometer (rpmlib, GLIBC filtered): puppet puppet-inifile puppet-java puppet-stdlib Provides -------- puppet-barometer: puppet-barometer Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m dlrn -n puppet-barometer -r Buildroot used: dlrn-centos7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 The package is APPROVED.
Rocky released long ago, removing it's tracker. If needed this package can be proposed to RDO Next release i.e victoria.
package was added but never moved out of under-review in rdoinfo https://review.rdoproject.org/r/q/topic:add-puppet-barometer In the meantime, upstream seems abandoned, last commit 6yrs ago https://github.com/opnfv/puppet-barometer/commits/master and reverted from rdoinfo in https://review.rdoproject.org/r/c/rdoinfo/+/34488