Bug 1585758 - Review Request: lua-cqueues - Stackable Continuation Queues for Lua
Summary: Review Request: lua-cqueues - Stackable Continuation Queues for Lua
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom Krizek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-06-04 16:07 UTC by Petr Špaček
Modified: 2019-01-22 17:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-17 12:09:27 UTC
Type: ---
Embargoed:
tkrizek: fedora-review+


Attachments (Terms of Use)

Description Petr Špaček 2018-06-04 16:07:46 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/pspacek/lua-cqueues/fedora-27-x86_64/00762791-lua-cqueues/lua-cqueues.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/pspacek/lua-cqueues/fedora-27-x86_64/00762791-lua-cqueues/lua-cqueues-20161215-0.fc27.src.rpm

Description:
cqueues is a type of event loop for Lua. It doesn't use callbacks but instead
you communicate with an event controller by the yielding and resumption of
Lua coroutines using objects.

cqueues are stackable. Each instantiated cqueue is a poll-able object which
can be polled from another cqueue, or another event loop system entirely.
The design is meant to be non-intrusive, composable, and embeddable within
existing applications.

Fedora Account System Username: pspacek

COPR build: https://copr.fedorainfracloud.org/coprs/pspacek/lua-cqueues/build/762791/

Comment 1 Petr Špaček 2018-06-04 16:12:35 UTC
$ rpmlint *.rpm
lua-cqueues.src: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues.src: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, routines
lua-cqueues.src: W: spelling-error %description -l en_US stackable -> stack able, stack-able, stable
lua-cqueues.src: W: spelling-error %description -l en_US cqueue -> queue, c queue, McQueen
lua-cqueues.src: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
lua-cqueues.x86_64: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues.x86_64: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, routines
lua-cqueues.x86_64: W: spelling-error %description -l en_US stackable -> stack able, stack-able, stable
lua-cqueues.x86_64: W: spelling-error %description -l en_US cqueue -> queue, c queue, McQueen
lua-cqueues.x86_64: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
lua-cqueues.x86_64: W: no-documentation
lua-cqueues-compat.x86_64: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues-compat.x86_64: W: no-documentation
lua-cqueues-debugsource.x86_64: W: no-documentation
7 packages and 0 specfiles checked; 0 errors, 14 warnings.


I think these can be waived because:
- spelling suggestions are just weird, the text it is complaining about is copied from project page,
- there is separate -doc package with necessary API documentation and code examples.

Comment 2 Jani Juhani Sinervo 2018-07-08 20:36:29 UTC
Here's a preliminary (unofficial) review. Some points I thought would be useful:

- Even though this is a development package by itself, and thus as far as I can tell an unversioned .so-file is acceptable, I would still try to make the _cqueues.so into a versioned .so-file, and then maybe creating an symbolic link from that versioned file to _cqueues.so.

- Like I've marked below, this version of the library isn't the latest. Is there a reason for this? If there is nothing blocking you updating the library version packaged, I would suggest making the version packaged the latest stable release.

- In your %files-section of the doc-subpackage you don't own the package directories correctly. I'd suggest adding %{_pkgdocdir} with %dir-specifier. Or even better, I'd add the docs using the %doc-specifier.

- As you said, the rpmlint messages may be waived, since most of the "misspellings" are either the project's name or things understandable in context.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "*No copyright* MIT (old)", "Unknown or
     generated". 92 files have unknown license. Detailed output of
     licensecheck in /home/jani/review_stuff/1585758-lua-
     cqueues/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/doc/lua-cqueues/examples,
     /usr/share/doc/lua-cqueues
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/lua/5.1,
     /usr/share/lua/5.3, /usr/lib64/lua, /usr/share/doc/lua-
     cqueues/examples, /usr/share/lua, /usr/lib64/lua/5.3,
     /usr/lib64/lua/5.1, /usr/share/doc/lua-cqueues
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install. -- Not sure if artefact from this SPEC also
     seeming to work for RHEL as well
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lua-
     cqueues-compat , lua-cqueues-doc , lua-cqueues-debuginfo , lua-
     cqueues-debugsource
[?]: Package functions as described.you just using common development vocabulary, and 
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define luacompatver 5.1,
     %define luacompatlibdir %{_libdir}/lua/%{luacompatver}, %define
     luacompatpkgdir %{_datadir}/lua/%{luacompatver}
[x]: Reviewer should test that the package builds in mock.
(Of course I need to mention that I may have done some mistakes reviewing this.)
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: lua-cqueues-20161215-0.fc28.x86_64.rpm
          lua-cqueues-compat-20161215-0.fc28.x86_64.rpm
          lua-cqueues-doc-20161215-0.fc28.noarch.rpm
          lua-cqueues-debuginfo-20161215-0.fc28.x86_64.rpm
          lua-cqueues-debugsource-20161215-0.fc28.x86_64.rpm
          lua-cqueues-20161215-0.fc28.src.rpm
lua-cqueues.x86_64: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues.x86_64: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, routines
lua-cqueues.x86_64: W: spelling-error %description -l en_US stackable -> stack able, stack-able, stable
lua-cqueues.x86_64: W: spelling-error %description -l en_US cqueue -> queue, c queue, McQueen
lua-cqueues.x86_64: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
lua-cqueues.x86_64: W: no-documentation
lua-cqueues-compat.x86_64: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues-compat.x86_64: W: no-documentation
lua-cqueues.src: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues.src: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, routines
lua-cqueues.src: W: spelling-error %description -l en_US stackable -> stack able, stack-able, stable
lua-cqueues.src: W: spelling-error %description -l en_US cqueue -> queue, c queue, McQueen
lua-cqueues.src: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
6 packages and 0 specfiles checked; 0 errors, 13 warnings.

Comment 3 Robert-André Mauchin 🐧 2018-07-09 16:07:27 UTC
 - This is not needed even in RHEL:

rm -rf $RPM_BUILD_ROOT


%if 0%{?rhel}
%clean
rm -rf $RPM_BUILD_ROOT
%endif

 - Group: is not used in Fedora


(In reply to Jani Juhani Sinervo from comment #2)
> Here's a preliminary (unofficial) review. Some points I thought would be
> useful:
> 
> - Even though this is a development package by itself, and thus as far as I
> can tell an unversioned .so-file is acceptable, I would still try to make
> the _cqueues.so into a versioned .so-file, and then maybe creating an
> symbolic link from that versioned file to _cqueues.so.
> 

It's in a private dir, so it doesn't really matter.

Comment 4 Petr Špaček 2018-07-13 13:38:56 UTC
(In reply to Jani Juhani Sinervo from comment #2)
> Here's a preliminary (unofficial) review. Some points I thought would be
> useful:

Thank you for your time!


> - Even though this is a development package by itself, and thus as far as I
> can tell an unversioned .so-file is acceptable, I would still try to make
> the _cqueues.so into a versioned .so-file, and then maybe creating an
> symbolic link from that versioned file to _cqueues.so.

As others said, this is library in private directory and it is Lua library after all, so I would prefer to avoid hassle with so versions.


> - Like I've marked below, this version of the library isn't the latest. Is
> there a reason for this? If there is nothing blocking you updating the
> library version packaged, I would suggest making the version packaged the
> latest stable release.

Unfortunatelly this is the newest tarball available. I have asked upstream for latest tarball here https://github.com/wahern/cqueues/issues/202, let's see what happens.


> - In your %files-section of the doc-subpackage you don't own the package
> directories correctly. I'd suggest adding %{_pkgdocdir} with %dir-specifier.
> Or even better, I'd add the docs using the %doc-specifier.

Thanks, I will will into it! Please see below for details.


> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
[...]
> ===== MUST items =====
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/share/doc/lua-cqueues/examples,
>      /usr/share/doc/lua-cqueues
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/lua/5.1,
>      /usr/share/lua/5.3, /usr/lib64/lua, /usr/share/doc/lua-
>      cqueues/examples, /usr/share/lua, /usr/lib64/lua/5.3,
>      /usr/lib64/lua/5.1, /usr/share/doc/lua-cqueues

/usr/share/doc/lua-cqueues is certainly a bug, I'm not sure about others.


> [!]: Each %files section contains %defattr if rpm < 4.4
>      Note: %defattr present but not needed
CentOS 7 has RPM 4.11 so this should not be necessary in all sections,
I'm not going to extend EPEL for RHEL 6.


> [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install. -- Not sure if artefact from this SPEC also
>      seeming to work for RHEL as well

Given comment#3 I'm not sure if it is really necessary.


> [!]: Spec use %global instead of %define unless justified.
>      Note: %define requiring justification: %define luacompatver 5.1,
>      %define luacompatlibdir %{_libdir}/lua/%{luacompatver}, %define
>      luacompatpkgdir %{_datadir}/lua/%{luacompatver}

I will look into this as well.

Comment 5 Petr Špaček 2018-07-18 12:19:09 UTC
Here is refreshed version of packages:

https://copr-be.cloud.fedoraproject.org/results/pspacek/lua-cqueues/fedora-rawhide-x86_64/00778557-lua-cqueues/lua-cqueues-20171014-0.fc29.src.rpm

https://copr-be.cloud.fedoraproject.org/results/pspacek/lua-cqueues/fedora-rawhide-x86_64/00778557-lua-cqueues/lua-cqueues.spec


As far as I can tell it addresses all problems pointed above except two nitpicks:
1. Bug in Lua packaging
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: 
     /usr/share/lua/5.3, /usr/lib64/lua/5.3
This was addressed by
https://src.fedoraproject.org/rpms/lua/pull-request/2
but it will take some time until new packages are built.


2. The unversioned .so is still unversioned because it is in private dir and the only interface it has is Lua interface so it does not really matter (as others pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=1585758#c3).


3. Weird spelling suggestions. These texts come directly from project page so it does not make sense to rewrite it.

It should be ready for formal review, I will look into docs and set flags accordingly.

Comment 6 Tom Krizek 2018-07-25 15:17:48 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Resolved by https://src.fedoraproject.org/rpms/lua/pull-request/2
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lua-
     cqueues-compat , lua-cqueues-doc , lua-cqueues-debuginfo , lua-
     cqueues-debugsource
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: lua-cqueues-20171014-0.fc27.x86_64.rpm
          lua-cqueues-compat-20171014-0.fc27.x86_64.rpm
          lua-cqueues-doc-20171014-0.fc27.noarch.rpm
          lua-cqueues-debuginfo-20171014-0.fc27.x86_64.rpm
          lua-cqueues-debugsource-20171014-0.fc27.x86_64.rpm
          lua-cqueues-20171014-0.fc27.src.rpm
lua-cqueues.x86_64: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues.x86_64: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, routines
lua-cqueues.x86_64: W: spelling-error %description -l en_US stackable -> stack able, stack-able, stable
lua-cqueues.x86_64: W: spelling-error %description -l en_US cqueue -> queue, c queue, McQueen
lua-cqueues.x86_64: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
lua-cqueues.x86_64: W: no-documentation
lua-cqueues-compat.x86_64: E: explicit-lib-dependency compat-lua-libs
lua-cqueues-compat.x86_64: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues-compat.x86_64: W: no-documentation
lua-cqueues.src: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues.src: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, routines
lua-cqueues.src: W: spelling-error %description -l en_US stackable -> stack able, stack-able, stable
lua-cqueues.src: W: spelling-error %description -l en_US cqueue -> queue, c queue, McQueen
lua-cqueues.src: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
6 packages and 0 specfiles checked; 1 errors, 13 warnings.


Rpmlint (debuginfo)
-------------------
Checking: lua-cqueues-debuginfo-20171014-0.fc27.x86_64.rpm
          lua-cqueues-compat-debuginfo-20171014-0.fc27.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
lua-cqueues-debuginfo.x86_64: W: invalid-url URL: https://25thandclement.com/~william/projects/cqueues.html <urlopen error [Errno -2] Name or service not known>
lua-cqueues-compat-debuginfo.x86_64: W: invalid-url URL: https://25thandclement.com/~william/projects/cqueues.html <urlopen error [Errno -2] Name or service not known>
lua-cqueues-debugsource.x86_64: W: invalid-url URL: https://25thandclement.com/~william/projects/cqueues.html <urlopen error [Errno -2] Name or service not known>
lua-cqueues-debugsource.x86_64: W: no-documentation
lua-cqueues-compat.x86_64: E: explicit-lib-dependency compat-lua-libs
lua-cqueues-compat.x86_64: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues-compat.x86_64: W: invalid-url URL: https://25thandclement.com/~william/projects/cqueues.html <urlopen error [Errno -2] Name or service not known>
lua-cqueues-compat.x86_64: W: no-documentation
lua-cqueues.x86_64: W: spelling-error Summary(en_US) Stackable -> Stack able, Stack-able, Stable
lua-cqueues.x86_64: W: spelling-error %description -l en_US coroutines -> co routines, co-routines, routines
lua-cqueues.x86_64: W: spelling-error %description -l en_US stackable -> stack able, stack-able, stable
lua-cqueues.x86_64: W: spelling-error %description -l en_US cqueue -> queue, c queue, McQueen
lua-cqueues.x86_64: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
lua-cqueues.x86_64: W: invalid-url URL: https://25thandclement.com/~william/projects/cqueues.html <urlopen error [Errno -2] Name or service not known>
lua-cqueues.x86_64: W: no-documentation
lua-cqueues-doc.noarch: W: invalid-url URL: https://25thandclement.com/~william/projects/cqueues.html <urlopen error [Errno -2] Name or service not known>
6 packages and 0 specfiles checked; 1 errors, 15 warnings.

Comment 7 Tom Krizek 2018-07-25 15:42:13 UTC
The above rpmlint warnings and errors can be waived. They are either irrelevant (spelling-error), incorrect (invalid-url) or justified (explicit-lib-dependency - see spec file).

Comment 8 Gwyn Ciesla 2018-09-11 13:35:45 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/lua-cqueues

Comment 9 Igor Raits 2018-09-11 13:37:41 UTC
* Group tag should not be used
* %if 0%{?fedora} >= 20, guys we are far further than that. Drop condition.

Comment 10 Petr Špaček 2018-09-11 13:46:09 UTC
I want to use the same SPEC for EPEL... so I can just drop the number from the condition.

Comment 11 Petr Špaček 2018-09-17 12:09:27 UTC
Thanks to everyone involved!

Comment 12 Fedora Update System 2019-01-11 12:21:49 UTC
lua-cqueues-20171014-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4ca5923d43

Comment 13 Fedora Update System 2019-01-12 02:30:43 UTC
lua-cqueues-20171014-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4ca5923d43

Comment 14 Fedora Update System 2019-01-22 17:42:12 UTC
lua-cqueues-20171014-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.