Bug 1591702 - valgrind: missing pkey support
Summary: valgrind: missing pkey support
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: valgrind
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mark Wielaard
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1304452
TreeView+ depends on / blocked
 
Reported: 2018-06-15 10:22 UTC by Florian Weimer
Modified: 2019-11-27 18:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-27 18:57:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2018-06-15 10:22:29 UTC
pkey_alloc and the other pkey system calls are not implemented in valgrind:

--64-- WARNING: unhandled amd64-linux syscall: 329
--64-- You may be able to write your own handler.
--64-- Read the file README_MISSING_SYSCALL_OR_IOCTL.
--64-- Nevertheless we consider this a bug.  Please report
--64-- it at http://valgrind.org/support/bug_reports.html.

pkey_mprotect should be treated as mprotect with an extra argument (in which all bits are significant).  For pkey_alloc and pkey_free, all bits in the arguments are significant.  No special treatment is needed for them.

On Intel, PKRU reads and writes need to be implemented as well.  These instructions should be passed through to the host, after checking (for WRPKRU) that all bits are defined.

Comment 1 Florian Weimer 2018-06-15 10:24:21 UTC
The Intel machines in Beaker can be found by hunting for the “pkru” flag.

POWER has support as well (but you need 4.17 kernel or later, with upcoming fixes).  The system calls are the same for POWER, and POWER8 machines have the necessary hardware support (unless they run under PowerKVM, but LPARs are fine).  The PKRU register on POWER is called AMR.

Comment 2 Jan Kurik 2018-08-14 09:57:57 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

Comment 3 Ben Cotton 2019-10-31 20:55:06 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Ben Cotton 2019-11-27 18:57:58 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.