Description of problem: ======================= /usr/share/icons/hicolor/scalable/apps/wine.svg appears wrong (certainly when displayed under mate or with an image viewer). Version-Release number of selected component (if applicable): ============================================================= wine-desktop-3.11-1.fc28.noarch
Created attachment 1457188 [details] Comparison between the icon we get and what we expect.
Hi, just wanted to confirm that this is still true for fedora 29, wine-4.0-rc6. This is highly visible for many wine apps and easy to fix, any chance to see it happing before 4.0 final? :)
Forgot to mention: using gnome-shell. The icon is just wrong, most certainly under any DE.
Created attachment 1521548 [details] fixed icon The icon as it should be
Another version without this being fixed (4.0.1.fc29) :( To elaborate why this is important, a list of affected things: - Lauchers / App overview: - Wine Boot - Wine OLE View - Panel: - all installed windows applications, even if they have an icon in the overview (at least on GS/wayland) - Alt-tab: - all installed windows applications, even if they have an icon in the overview Workaround: - download the 'fixed icon' attachment, containing 'wine.svg' - move it to /usr/share/icons/hicolor/scalable/apps/wine.svg - change its ownership to root:root Please let`s fix this, it's a really trivial but ugly bug
Friendly reminder that this bug still exists, Fedora 30, wine-4.6 :) Please, if you ever find time, this should only take two minutes to exchange the icon.
This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
This is still present in Fedora 30, please reassign
Sorry for the lack of response. I've become extremely busy in the past year and this bug is very low on my list of things to do. My concerns with this bug: We're using the upstream icon. If it needs changing either we're using it wrong or upstream needs to fix it. If we're using it wrong we need to update our RPM spec file (wine.spec) to extract the appropriate SVG icon data. If upstream needs to fix it then we (preferably you) need to open a bug report upstream for it. https://bugs.winehq.org/ How did you create the attached svg file? If you created it from the upstream file then let's use that to update the wine spec.
Thank you for taking the time now :) The problem comes from line 777-780 in the rpm spec file: # This icon file is still in the legacy format install -p -m 644 dlls/user32/resources/oic_winlogo.svg \ %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/wine.svg sed -i -e '3s/368/64/' %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/wine.svg By now, the main icon is an svg like all others, but the order of the icons is for some reason in the opposite way: the svg we want is at the start, not at the end. So the following patch to the spec file does extract the right svg for me: --- wine.spec.bkp 2019-04-28 19:57:04.000000000 +0200 +++ wine.spec 2019-05-15 12:37:44.999664233 +0200 @@ -766,6 +766,16 @@ %if 0%{?fedora} > 10 mkdir -p %{buildroot}%{_datadir}/icons/hicolor/scalable/apps +MAIN_ICONFIX='s/height="272"/height="256"/;'\ +'s/width="632"/width="256"\n'\ +' x="8"\n'\ +' y="8"\n'\ +' viewBox="8, 8, 256, 256"/;' + +install -p -m 644 dlls/user32/resources/oic_winlogo.svg \ + %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/wine.svg +sed -i -e "$MAIN_ICONFIX" %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/wine.svg + # This replacement masks a composite program icon .SVG down # so that only its full-size scalable icon is visible PROGRAM_ICONFIX='s/height="272"/height="256"/;'\ @@ -774,11 +784,6 @@ ' y="8"\n'\ ' viewBox="368, 8, 256, 256"/;' -# This icon file is still in the legacy format -install -p -m 644 dlls/user32/resources/oic_winlogo.svg \ - %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/wine.svg -sed -i -e '3s/368/64/' %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/wine.svg - # The rest come from programs/, and contain larger scalable icons # with a new layout that requires the PROGRAM_ICONFIX sed adjustment install -p -m 644 programs/notepad/notepad.svg \
Thanks for those notes! I'll push an update. When you see the comments about the update please provide feedback in bodhi.
wine-4.8-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfcdec45c3
wine-4.8-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fe3949852
I tried installing the build, but there are missing dependencies (wine-filesystem?): Problema 1: cannot install the best update candidate for package wine-4.7-1.fc30.x86_64 - nothing provides wine-capi(x86-32) = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-cms(x86-32) = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-common = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-core(x86-32) = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-desktop = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-fonts = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-ldap(x86-32) = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-openal(x86-32) = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-opencl(x86-32) = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-pulseaudio(x86-32) = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 - nothing provides wine-twain(x86-32) = 4.8-2.fc29 needed by wine-4.8-2.fc29.x86_64 Problema 2: cannot install the best update candidate for package wine-core-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 Problema 3: package wine-twain-4.8-2.fc29.x86_64 requires wine-core = 4.8-2.fc29, but none of the providers can be installed - cannot install the best update candidate for package wine-twain-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 Problema 4: package wine-pulseaudio-4.8-2.fc29.x86_64 requires wine-core = 4.8-2.fc29, but none of the providers can be installed - cannot install the best update candidate for package wine-pulseaudio-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 Problema 5: package wine-opencl-4.8-2.fc29.x86_64 requires wine-core = 4.8-2.fc29, but none of the providers can be installed - cannot install the best update candidate for package wine-opencl-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 Problema 6: package wine-openal-4.8-2.fc29.x86_64 requires wine-core = 4.8-2.fc29, but none of the providers can be installed - cannot install the best update candidate for package wine-openal-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 Problema 7: package wine-ldap-4.8-2.fc29.x86_64 requires wine-core = 4.8-2.fc29, but none of the providers can be installed - cannot install the best update candidate for package wine-ldap-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 Problema 8: package wine-cms-4.8-2.fc29.x86_64 requires wine-core = 4.8-2.fc29, but none of the providers can be installed - cannot install the best update candidate for package wine-cms-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 Problema 9: package wine-capi-4.8-2.fc29.x86_64 requires wine-core = 4.8-2.fc29, but none of the providers can be installed - cannot install the best update candidate for package wine-capi-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 Problema 10: package wine-alsa-4.8-2.fc29.x86_64 requires wine-core = 4.8-2.fc29, but none of the providers can be installed - cannot install the best update candidate for package wine-alsa-4.7-1.fc30.x86_64 - nothing provides wine-filesystem = 4.8-2.fc29 needed by wine-core-4.8-2.fc29.x86_64 ===================================================================================================================================== Package Architecture Version Repository Size ===================================================================================================================================== Ignoro i pacchetti con dipendenze rotte : wine x86_64 4.8-2.fc29 @commandline 12 k wine-alsa x86_64 4.8-2.fc29 @commandline 74 k wine-capi x86_64 4.8-2.fc29 @commandline 17 k wine-cms x86_64 4.8-2.fc29 @commandline 44 k wine-core x86_64 4.8-2.fc29 @commandline 28 M wine-ldap x86_64 4.8-2.fc29 @commandline 91 k wine-openal x86_64 4.8-2.fc29 @commandline 24 k wine-opencl x86_64 4.8-2.fc29 @commandline 29 k wine-pulseaudio x86_64 4.8-2.fc29 @commandline 61 k wine-twain x86_64 4.8-2.fc29 @commandline 53 k Riepilogo della transazione ===================================================================================================================================== Ignorati 10 pacchetti
Sorry, I forgot I was on Fedora-30. So it may just be some specfile/build incompatibilities with fc30.
The bodhi build works great here (f30), the icon is perfect now! Thanks a lot!
@Davide Repetto: you also need to download/install certain 32 bit packages, just as dnf says...I downloaded them by hand, but probably there's a more elegant way
Please install the Fedora 30 packages for your Fedora 30 system. You will need x86_64, i686, and noarch packages to do a successful update. If you don't know how to do that I suggest you wait for it to be available in the updates-testing repo (ETA end of today).
wine-4.8-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7fe3949852
wine-4.8-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfcdec45c3
wine-4.8-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
wine-4.8-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.