Spec URL: https://github.com/ryncsn/kdump-anaconda-addon-rpm/blob/master/kdump-anaconda-addon.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/kasong/kdump/fedora-rawhide-x86_64/00775611-kdump-anaconda-addon/kdump-anaconda-addon-005-1.git8b243e3.fc29.src.rpm Description: kdump-anaconda-addon was originally a sub package of kexec-tools. But it is not architecture related (kexec-tools is architecture related), so it should be a noarch package, and its source code does not belongs to or depends on kexec-tools. Now moving it out and make it a standalone package. Fedora Account System Username: kasong **Note** This is my first package and I will need a sponsor. I'm working on the bug bz1599151, please help, thanks. Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28104881 Rpmlint result: rpmlint kdump-anaconda-addon.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
- When packaging a dev snapshot, you should also add the snapshot date to the Release tag: %global gitcommit 8b243e38737fdd0f1e2d5f67445b8980e11d854c %global gitshortcommit %(c=%{gitcommit}; echo ${c:0:7}) %global snapshotdate 20180710 Release: 1.%{snapshotdate}git%{gitshortcommit}%{?dist} - Group: us not used in Fedora - You're missing the URL: field: URL: https://github.com/daveyoung/kdump-anaconda-addon - Why did you add this Obsoletes: Obsoletes: kdump-anaconda-addon <= 2.0.17-3 We do not have a kdump-anaconda-addon package to obsolete on Fedora. The package in kexec-tools is called "anaconda-addon" Maybe it's this one you need to Obsoletes? But in this case, youl also need to add a Provides: - DESTDIR=%{buildroot} make install → %make_install - You must install the LICENSE file in %files with %license and should install the READNE with %doc %files -f kdump-anaconda-addon.lang %doc README %license LICENSE - The changelog entry should contain the version-release info: * Mon Jul 9 2018 Kairui Song <kasong> - 005-1.20180710git8b243e3
(In reply to Robert-André Mauchin from comment #1) Thanks you very much for the review! > - When packaging a dev snapshot, you should also add the snapshot date to > the Release tag: > > %global gitcommit 8b243e38737fdd0f1e2d5f67445b8980e11d854c > %global gitshortcommit %(c=%{gitcommit}; echo ${c:0:7}) > %global snapshotdate 20180710 > > > Release: 1.%{snapshotdate}git%{gitshortcommit}%{?dist} Yes, I thought there were already version number and release number so dropped the snapshot date. Will update the spec file. > > - Group: us not used in Fedora > > - You're missing the URL: field: > > URL: https://github.com/daveyoung/kdump-anaconda-addon > > - Why did you add this Obsoletes: > > Obsoletes: kdump-anaconda-addon <= 2.0.17-3 > > We do not have a kdump-anaconda-addon package to obsolete on Fedora. The > package in kexec-tools is called "anaconda-addon" Maybe it's this one you > need to Obsoletes? But in this case, youl also need to add a Provides: Oops, the package I want to obsoletes is kexec-tools-anaconda-addon, will fix it. > > - DESTDIR=%{buildroot} make install → %make_install > > - You must install the LICENSE file in %files with %license and should > install the READNE with %doc > > %files -f kdump-anaconda-addon.lang > %doc README > %license LICENSE > > - The changelog entry should contain the version-release info: > > * Mon Jul 9 2018 Kairui Song <kasong> - 005-1.20180710git8b243e3 Will update the spec to fix those issues.
Updated: Spec URL: https://github.com/ryncsn/kdump-anaconda-addon-rpm/blob/master/kdump-anaconda-addon.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/kasong/kdump/fedora-rawhide-ppc64le/00775772-kdump-anaconda-addon/kdump-anaconda-addon-005-1.20180626git8b243e3.fc29.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28107994 Spec file updated in place, URL not changed. There was a problem I'm unsure about, I added Provides: kexec-tools-anaconda-addon = %{version}-%{release} Is this OK? Or should I use a fixed Provides version?
It's ok. - [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable You must add a Requires: hicolor-icon-theme to own these directories. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 73 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/kdump-anaconda- addon/review-kdump-anaconda-addon/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/anaconda/addons/com_redhat_kdump/tui(kexec-tools-anaconda- addon), /usr/share/anaconda/addons/com_redhat_kdump/tui/spokes(kexec- tools-anaconda-addon), /usr/share/anaconda/addons/com_redhat_kdump/gui/spokes(kexec-tools- anaconda-addon), /usr/share/anaconda/addons/com_redhat_kdump/ks(kexec- tools-anaconda-addon), /usr/share/anaconda/addons/com_redhat_kdump/gui (kexec-tools-anaconda-addon), /usr/share/anaconda/addons/com_redhat_kdump(kexec-tools-anaconda- addon) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kdump-anaconda-addon-005-1.20180626git8b243e3.fc29.noarch.rpm kdump-anaconda-addon-005-1.20180626git8b243e3.fc29.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Spec URL: https://github.com/ryncsn/kdump-anaconda-addon-rpm/blob/master/kdump-anaconda-addon.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/kasong/kdump/fedora-rawhide-x86_64/00775999-kdump-anaconda-addon/kdump-anaconda-addon-005-1.20180626git8b243e3.fc29.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28118036 Spec file updated.
Ok package approved. You still need to find a sponsor.
(In reply to Robert-André Mauchin from comment #6) > Ok package approved. > > You still need to find a sponsor. Thanks a lot for your review! it's really helpful.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kdump-anaconda-addon