Bug 159974 - pam_loginuid fails horribly on non-audit kernels
pam_loginuid fails horribly on non-audit kernels
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: pam (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tomas Mraz
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-09 16:28 EDT by Bill Nottingham
Modified: 2014-03-16 22:54 EDT (History)
2 users (show)

See Also:
Fixed In Version: pam-0.79-10
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-06-09 17:36:30 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Bill Nottingham 2005-06-09 16:28:08 EDT
Noticed by Al Viro.

It tries to open /proc/<pid>/loginuid, which doesn't exist. It then errors out
-> you can't log in at all.

It should probably either check for the /proc/<pid>/loginuid file first (and
warn if it's not there), or it should check for the presence of a compatible
audit layer, and exit successfully if there isn't one.
Comment 1 Steve Grubb 2005-06-09 16:56:47 EDT
I'll adjust the loginuid patch to exit successfully if and only if errno ==
ENOENT on open. This will satisfy CAPP & let people with nonstandard kernels get
back into their system.
Comment 2 Tomas Mraz 2005-06-09 17:36:30 EDT
Here is the changed code snippet I patched in the latest rawhide:

        fd = open("/proc/self/loginuid", O_NOFOLLOW|O_WRONLY|O_TRUNC);
        if (fd < 0) {
                int loglevel = LOG_DEBUG;
                if (errno != ENOENT) {
                        rc = 1;
                        loglevel = LOG_ERR;
                }
                _pam_log(loglevel, "set_loginuid failed opening loginuid\n");
                return rc;
        }

Note You need to log in before you can comment on or make changes to this bug.