DEBUG util.py:489:  BUILDSTDERR: No matching package to install: '(crate(termcolor) >= 0.3.0 with crate(termcolor) < 0.4.0)'

(In reply to Robert-André Mauchin from comment #1)
> DEBUG util.py:489:  BUILDSTDERR: No matching package to install:
> '(crate(termcolor) >= 0.3.0 with crate(termcolor) < 0.4.0)'

I will patch it, it's just bump. Anything else?

I can't build it so I can't continue the review without the patch.

I'll patch it myself then.

Tests failures:

failures:
---- build_auth::http_auth_offered stdout ----
	running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build -v`
running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build`
thread 'build_auth::http_auth_offered' panicked at 'called `Option::unwrap()` on a `None` value', libcore/option.rs:335:21
---- build_script::custom_build_env_var_rustc_linker stdout ----
	thread 'build_script::custom_build_env_var_rustc_linker' panicked at 'Cannot cross compile to i686-unknown-linux-gnu.
This failure can be safely ignored. If you would prefer to not see this
failure, you can set the environment variable CFG_DISABLE_CROSS_TESTS to "1".
', tests/testsuite/cargotest/support/cross_compile.rs:91:5
---- new::author_prefers_cargo stdout ----
	thread 'new::author_prefers_cargo' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
could not execute process `git config --global user.name foo` (never executed)', libcore/result.rs:945:5
---- new::finds_author_git stdout ----
	thread 'new::finds_author_git' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
could not execute process `git config --global user.name bar` (never executed)', libcore/result.rs:945:5
---- new::finds_local_author_git stdout ----
	thread 'new::finds_local_author_git' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
could not execute process `git init` (never executed)', libcore/result.rs:945:5
failures:
    build_auth::http_auth_offered
    build_script::custom_build_env_var_rustc_linker
    new::author_prefers_cargo
    new::finds_author_git
    new::finds_local_author_git
test result: FAILED. 1280 passed; 5 failed; 4 ignored; 0 measured; 0 filtered out

The last 3 tests fail because you're missing git-core as a BR for the tests.

New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-cargo.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-cargo-0.28.0-1.fc29.src.rpm

Same tests still fail:

failures:

BUILDSTDERR: thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
BUILDSTDERR:   left: `{"Accept: */*", "User-Agent: git/2.0 (libgit2 0.26.5)", "GET /foo/bar/info/refs?service=git-upload-pack HTTP/1.1"}`,
BUILDSTDERR:  right: `{"Accept: */*", "User-Agent: git/2.0 (libgit2 0.27.0)", "GET /foo/bar/info/refs?service=git-upload-pack HTTP/1.1"}`', tests/testsuite/build_auth.rs:40:9
BUILDSTDERR: note: Run with `RUST_BACKTRACE=1` for a backtrace.
test build_auth::http_auth_offered ... FAILED

---- build_auth::http_auth_offered stdout ----
	running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build -v`
running `/builddir/build/BUILD/cargo-0.28.0/target/release/cargo build`
thread 'build_auth::http_auth_offered' panicked at 'called `Option::unwrap()` on a `None` value', libcore/option.rs:335:21
---- build_script::custom_build_env_var_rustc_linker stdout ----
	thread 'build_script::custom_build_env_var_rustc_linker' panicked at 'Cannot cross compile to i686-unknown-linux-gnu.
This failure can be safely ignored. If you would prefer to not see this
failure, you can set the environment variable CFG_DISABLE_CROSS_TESTS to "1".
', tests/testsuite/cargotest/support/cross_compile.rs:91:5
failures:
    build_auth::http_auth_offered
    build_script::custom_build_env_var_rustc_linker
test result: FAILED. 1283 passed; 2 failed; 4 ignored; 0 measured; 0 filtered out


You could choose to ignore it although finding why it fails would be better.


Another problem: you must install the license files with %license in %files.

That User-Agent difference is just from using Fedora's libgit2 rather than the bundled one in rust-libgit2-sys.  Perhaps that test should be using a regex to match the strings, so the exact libgit2 version doesn't matter.

I'm already worried about the ABI in rust-libgit2-sys, as noted in bug 1584928, but that's at a deeper level than just the agent string.

Works in Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=28702523

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - you must install the license files with %license in %files.

Package approved but don't forget to install the %license files.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo