Bug 1609241 - wxi files contain references to many non-existant files
Summary: wxi files contain references to many non-existant files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: msitools
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Paolo Bonzini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-07-27 11:00 UTC by Daniel Berrangé
Modified: 2018-08-14 21:08 UTC (History)
4 users (show)

Fixed In Version: msitools-0.98-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-14 21:08:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Script to verify wxi files (1.41 KB, text/plain)
2018-07-27 11:32 UTC, Daniel Berrangé
no flags Details

Description Daniel Berrangé 2018-07-27 11:00:38 UTC
Description of problem:
Attempting to build virt-viewer win32 msi:

Couldn't find file /usr/i686-w64-mingw32/sys-root/mingw/bin/glib-genmarshal.exe

Indeed that file does not exist, as in mingw32-glib it does not have an .exe suffix. Presumably something in glib changed and msitools needs updating to match

Version-Release number of selected component (if applicable):
msitools-0.97-2.fc27.x86_64

How reproducible:
Always

Comment 1 Marc-Andre Lureau 2018-07-27 11:13:26 UTC
Victor is working on msitools update

Comment 2 Daniel Berrangé 2018-07-27 11:31:20 UTC
I wrote a script to check for missing files and it reported many more problems (not counting RPMs I don't have installed)

# perl validate.pl  //usr/share/wixl-0.97/include/*wxi


Errors in //usr/share/wixl-0.97/include/expat.wxi

  - Missing /usr/i686-w64-mingw32/sys-root/mingw/bin/xmlwf
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/bin/xmlwf


Errors in //usr/share/wixl-0.97/include/fontconfig.wxi

  - Missing /usr/i686-w64-mingw32/sys-root/mingw/etc/fonts/conf.d/30-urw-aliases.conf
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/etc/fonts/conf.d/30-urw-aliases.conf
  - Missing /usr/i686-w64-mingw32/sys-root/mingw/share/fontconfig/conf.avail/30-urw-aliases.conf
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/share/fontconfig/conf.avail/30-urw-aliases.conf


Errors in //usr/share/wixl-0.97/include/gcc.wxi

  - Missing /usr/i686-w64-mingw32/sys-root/mingw/bin/libgcc_s_seh-1.dll
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/bin/libgcc_s_sjlj-1.dll


Errors in //usr/share/wixl-0.97/include/glib2.wxi

  - Missing /usr/i686-w64-mingw32/sys-root/mingw/bin/glib-genmarshal.exe
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/bin/glib-genmarshal.exe
  - Missing /usr/i686-w64-mingw32/sys-root/mingw/bin/gspawn-$(var.GLIB_ARCH)-helper-console.exe
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/bin/gspawn-$(var.GLIB_ARCH)-helper-console.exe
  - Missing /usr/i686-w64-mingw32/sys-root/mingw/bin/gspawn-$(var.GLIB_ARCH)-helper.exe
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/bin/gspawn-$(var.GLIB_ARCH)-helper.exe


Errors in //usr/share/wixl-0.97/include/gstreamer1-plugins-bad-free.wxi

  - Missing /usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstcamerabin2.dll
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstcamerabin2.dll
  - Missing /usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstdataurisrc.dll
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstdataurisrc.dll
  - Missing /usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstgtksink.dll
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstgtksink.dll
  - Missing /usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstopus.dll
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstopus.dll


Errors in //usr/share/wixl-0.97/include/gstreamer1-plugins-base.wxi

  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/bin/i686-w64-mingw32-gst-device-monitor-1.0.exe
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/bin/i686-w64-mingw32-gst-play-1.0.exe
  - Missing /usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstencodebin.dll
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstencodebin.dll


Errors in //usr/share/wixl-0.97/include/gstreamer1-plugins-good.wxi

  - Missing /usr/i686-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstsouphttpsrc.dll
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/lib/gstreamer-1.0/libgstsouphttpsrc.dll
Cannot check //usr/share/wixl-0.97/include/gstreamer-plugins-bad-free.wxi, mingw32-gstreamer-plugins-bad-free not installed
Cannot check //usr/share/wixl-0.97/include/gstreamer-plugins-bad-free.wxi, mingw32-gstreamer-plugins-bad-free not installed
Cannot check //usr/share/wixl-0.97/include/gstreamer-plugins-base.wxi, mingw32-gstreamer-plugins-base not installed
Cannot check //usr/share/wixl-0.97/include/gstreamer-plugins-base.wxi, mingw32-gstreamer-plugins-base not installed
Cannot check //usr/share/wixl-0.97/include/gstreamer-plugins-good.wxi, mingw32-gstreamer-plugins-good not installed
Cannot check //usr/share/wixl-0.97/include/gstreamer-plugins-good.wxi, mingw32-gstreamer-plugins-good not installed
Cannot check //usr/share/wixl-0.97/include/gstreamer.wxi, mingw32-gstreamer not installed
Cannot check //usr/share/wixl-0.97/include/gstreamer.wxi, mingw32-gstreamer not installed
Cannot check //usr/share/wixl-0.97/include/gtk-vnc.wxi, mingw32-gtk-vnc not installed
Cannot check //usr/share/wixl-0.97/include/gtk-vnc.wxi, mingw32-gtk-vnc not installed
Cannot check //usr/share/wixl-0.97/include/hicolor-icon-theme.wxi, mingw32-hicolor-icon-theme not installed
Cannot check //usr/share/wixl-0.97/include/hicolor-icon-theme.wxi, mingw32-hicolor-icon-theme not installed
Cannot check //usr/share/wixl-0.97/include/libcacard.wxi, mingw32-libcacard not installed
Cannot check //usr/share/wixl-0.97/include/libcacard.wxi, mingw32-libcacard not installed
Cannot check //usr/share/wixl-0.97/include/libtiff.wxi, mingw32-libtiff not installed
Cannot check //usr/share/wixl-0.97/include/libtiff.wxi, mingw32-libtiff not installed
Cannot check //usr/share/wixl-0.97/include/nspr.wxi, mingw32-nspr not installed
Cannot check //usr/share/wixl-0.97/include/nspr.wxi, mingw32-nspr not installed
Cannot check //usr/share/wixl-0.97/include/nss.wxi, mingw32-nss not installed
Cannot check //usr/share/wixl-0.97/include/nss.wxi, mingw32-nss not installed
Cannot check //usr/share/wixl-0.97/include/pthreads.wxi, mingw32-pthreads not installed
Cannot check //usr/share/wixl-0.97/include/pthreads.wxi, mingw32-pthreads not installed
Parsing failed on //usr/share/wixl-0.97/include/SDL.wxi: 
mismatched tag at line 17, column 6, byte 677:
      <ComponentGroupRef Id="CG.win-iconv">
      <ComponentRef Id="cmpE62B6BBD3A238B97A2947D35EA1404D3"/>
    </ComponentGroup>
=====^
  </Fragment>
</Include>
 at /usr/lib64/perl5/vendor_perl/XML/Parser.pm line 187.



Errors in //usr/share/wixl-0.97/include/spice-glib.wxi

  - Missing /usr/i686-w64-mingw32/sys-root/mingw/bin/libspice-controller-0.dll
  - Missing /usr/x86_64-w64-mingw32/sys-root/mingw/bin/libspice-controller-0.dll

Comment 3 Daniel Berrangé 2018-07-27 11:32:12 UTC
Created attachment 1471065 [details]
Script to verify wxi files

Comment 4 Daniel Berrangé 2018-07-27 11:33:05 UTC
It would be nice to get this validation script wired up into the Fedora CI system in some manner so we can check that msitools works in each Fedora release.

Comment 5 Daniel Berrangé 2018-07-27 11:34:12 UTC
BTW, for spice-glib note that there's a 0.35 release in updates-testing that is why we see the missing libspice-controller-0.dll

Comment 6 Victor Toso 2018-08-01 11:23:29 UTC
The only one I missed in the merge request msitools-!2 was gcc.wxi but did not seem to trigger any issue to build my testing version of virt-viewer msi [0].

https://gitlab.gnome.org/GNOME/msitools/merge_requests/2

[0] https://people.freedesktop.org/~victortoso/msi-testing/virt-viewer-x64-8.0-on-31072018.msi

Anyway, we should automate this somehow. Not sure if gitlab's ci has an way to run tests every once in a while which we could run your script against latests version of related mingw packages... ideas welcome.

Comment 7 Victor Toso 2018-08-01 12:30:18 UTC
Created issue#1 for improving the CI upstream to check wxi data with latest fedora. This bug should be fixed in msitools 0.98 release.

https://gitlab.gnome.org/GNOME/msitools/issues/1

Comment 8 Fedora Update System 2018-08-02 14:55:44 UTC
msitools-0.98-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-ab2cb1e736

Comment 9 Fedora Update System 2018-08-03 21:58:48 UTC
msitools-0.98-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ab2cb1e736

Comment 10 Fedora Update System 2018-08-14 21:08:27 UTC
msitools-0.98-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.