Bug 1618354 - [evolution-alarm-notify] Do not show a window with a list of pending reminders by default
Summary: [evolution-alarm-notify] Do not show a window with a list of pending reminder...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: evolution-data-server
Version: 29
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Milan Crha
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-16 13:26 UTC by Stephen Gallagher
Modified: 2018-08-27 08:14 UTC (History)
10 users (show)

Fixed In Version: evolution-data-server-3.29.92
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-27 08:14:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screenshot of notification window (17.29 KB, image/png)
2018-08-21 13:51 UTC, Stephen Gallagher
no flags Details

Description Stephen Gallagher 2018-08-16 13:26:55 UTC
Description of problem:
evolution-alarm-notify is displaying an ugly window instead of sending to GNOME-shell notifications

Version-Release number of selected component (if applicable):
evolution-data-server-3.29.90-1.fc29.x86_64
gnome-shell-3.29.90-2.fc29.x86_64


How reproducible:
Every time

Steps to Reproduce:
1. Set a calendar event with a reminder via some mechanism connected to GNOME Online Accounts (I have a Google Calendar linked)
2. Wait for a reminder to be sent

Actual results:
A separate window pops up that must be dismissed with the announcement

Expected results:
The notification should use the standard GNOME notification mechanism.


Additional info:

Comment 1 Milan Crha 2018-08-20 16:28:57 UTC
Thanks for a bug report. Could you define what "ugly" means for you, please? I'm afraid it's a very subjective measure, nothing really objective.

In any case, it is supposed to show a window, unless:

   $ gsettings get org.gnome.evolution-data-server.calendar notify-with-tray

returns 'true'.

The evolution-alarm-notify also uses GNotification for the standard notifications, which is probably the main change from the previous versions (when it had been provided by evolution itself), instead of using libnotify directly. I'll investigate this further, though I'm afraid it's some GNOME shell glitch.

Comment 2 Stephen Gallagher 2018-08-21 13:51:01 UTC
Created attachment 1477515 [details]
Screenshot of notification window

Adding screenshot

Comment 3 Allan Day 2018-08-21 13:57:09 UTC
The issue here is that a window is being shown, rather than how ugly or beautiful that window is. We have a general principle that windows shouldn't be shown spontaneously - it's a surprising interruption.

Comment 4 Milan Crha 2018-08-21 15:29:36 UTC
(In reply to Stephen Gallagher from comment #2)
> Adding screenshot

Thanks, it's it, it's the new window, which replaced:
https://bugzilla.gnome.org/attachment.cgi?id=347980

(In reply to Allan Day from comment #3)
> The issue here is that a window is being shown, rather than how ugly or
> beautiful that window is. We have a general principle that windows shouldn't
> be shown spontaneously - it's a surprising interruption.

Right. Except some people prefer to have the window shown. That's why there's a setting for it. I'm pretty sure I copied the default value for it from Evolution, but I can be wrong. If you think it'll be better to switch the default value, to not show the window, then I can do it.

There's also a different problem, GNOME Shell ignores GNotification notifications, thus users do not see the notifications they are used to. I'll attach a test program which exhibits the issue. The evolution-alarm-notify in evolution-data-server begun to use GNotification, instead of libnotify, also because it's a preferred way to do the notifications these days, I've been told so. There's always a chance I missed some important bit to set/use, which might be the reason why GNOME Shell ignores them, but this works fine in MATE, soooo...

Comment 5 Milan Crha 2018-08-21 15:41:03 UTC
I filled the issue in GNOME Shell upstream, with added test program:
https://gitlab.gnome.org/GNOME/gnome-shell/issues/500

I'm not sure whether this bug should be left opened, maybe only until the decision about the default value for notify-with-tray is done.

By the way, I hesitate to add libnotify as a build dependency of evolution-data-server.

Comment 6 Allan Day 2018-08-22 08:35:01 UTC
I'm struggling to understand why this issue has been renamed. The problem is that the EDS is showing a window. This should never happen. How is this the shell's problem?

Comment 7 Milan Crha 2018-08-22 08:51:07 UTC
Okay, it can be split (it already is, strictly speaking), but, from my point of view, that the notifications are ignored is a bigger issue than the window popup. When I change the default, or when users disable the window showing, they will not receive *any* notifications of upcoming meetings in the GNOME Shell. Functionality loss is bigger issue than the dialog, which is even supposed to not steal focus.

Comment 8 Allan Day 2018-08-22 09:05:04 UTC
(In reply to Milan Crha from comment #7)
> Functionality loss is bigger issue than the dialog

I disagree. This dialog is a design anti-pattern; we even warn against this behaviour in GNOME's design principles [1].

This issue can and should be fixed independently of the GNOME Shell issue.

[1] https://developer.gnome.org/hig/stable/design-principles.html.en

Comment 9 Milan Crha 2018-08-22 09:38:01 UTC
Okay, thus you need from me to change the default, to not show the dialog. Right? I've no problem with it, I only want to know that I do it correctly and that we agree on that approach.

Comment 10 Milan Crha 2018-08-27 08:14:33 UTC
Created commit [1] in eds master (3.29.92+)
Created commit [2] in eds master (3.29.92+)

[1] https://gitlab.gnome.org/GNOME/evolution-data-server/commit/335902855
[2] https://gitlab.gnome.org/GNOME/evolution-data-server/commit/de2aa6c7e


Note You need to log in before you can comment on or make changes to this bug.