Bug 1619111 - postfix-3.3 has a new build dependency m4 and current builds are broken
Summary: postfix-3.3 has a new build dependency m4 and current builds are broken
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: postfix
Version: 28
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Jaroslav Škarvada
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-08-20 06:33 UTC by Tuomo Soini
Modified: 2018-08-24 08:04 UTC (History)
2 users (show)

Fixed In Version: postfix-3.3.1-2.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-24 08:04:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tuomo Soini 2018-08-20 06:33:55 UTC
When mysql backend is used, postfix logs mysql options like password to log if build without m4 in build environment. Note, this is a security issue because sql passwords are printed to log!

This log is from postfix mailinglist and was reported by a fedora user.

Aug 12 22:39:28 crash postfix[21125]: /usr/sbin/postconf: warning:
mysql:/etc/postfix/users.cf: unused parameter: password=xxxxxxx
Aug 12 22:39:28 crash postfix[21125]: /usr/sbin/postconf: warning:
mysql:/etc/postfix/users.cf: unused parameter: dbname=mailbox
Aug 12 22:39:28 crash postfix[21125]: /usr/sbin/postconf: warning:
mysql:/etc/postfix/users.cf: unused parameter: query=SELECT mail FROM users
WHERE mail='%>
Aug 12 22:39:28 crash postfix[21125]: /usr/sbin/postconf: warning:
mysql:/etc/postfix/users.cf: unused parameter: user=administrator
Aug 12 22:39:28 crash postfix[21125]: /usr/sbin/postconf: warning:
mysql:/etc/postfix/users.cf: unused parameter: hosts=127.0.0.1

Evidence from build log https://kojipkgs.fedoraproject.org//packages/postfix/3.3.1/1.fc28/data/logs/x86_64/build.log

sh extract_cfg.sh -d ../global/dict_ldap.c > pcf_ldap_suffixes.h
extract_cfg.sh: line 74: m4: command not found
sh extract_cfg.sh -d ../global/dict_memcache.c > pcf_memcache_suffixes.h
sh extract_cfg.sh -d -s ../global/dict_mysql.c > pcf_mysql_suffixes.h
extract_cfg.sh: line 74: m4: command not found
extract_cfg.sh: line 74: m4: command not found
sh extract_cfg.sh -d -s ../global/dict_pgsql.c > pcf_pgsql_suffixes.h
postconf_master.c: In function 'pcf_show_master_entries':
sh extract_cfg.sh -d -s ../global/dict_sqlite.c > pcf_sqlite_suffixes.h
postconf_master.c:603:25: warning: 'field_reqs' may be used uninitialized in this function [-Wmaybe-uninitialized]
     PCF_MASTER_FLD_REQ *field_reqs;
                         ^~~~~~~~~~
extract_cfg.sh: line 74: m4: command not found
extract_cfg.sh: line 74: m4: command not found

Comment 1 Jaroslav Škarvada 2018-08-20 09:53:38 UTC
Added m4 to BuildRequires in postfix-3.3.1-2.fc28 and up.

Comment 2 Fedora Update System 2018-08-20 09:58:24 UTC
postfix-3.3.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c60acb4e7c

Comment 3 Fedora Update System 2018-08-20 19:39:52 UTC
postfix-3.3.1-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c60acb4e7c

Comment 4 Fedora Update System 2018-08-24 08:04:51 UTC
postfix-3.3.1-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.