Bug 162334 - milter-greylist has broken initscript
milter-greylist has broken initscript
Product: Fedora
Classification: Fedora
Component: milter-greylist (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Enrico Scholz
Depends On:
  Show dependency treegraph
Reported: 2005-07-02 18:19 EDT by Milan Kerslager
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-12-24 08:00:43 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch for init script for milter-greylist (1.45 KB, patch)
2005-07-02 18:19 EDT, Milan Kerslager
no flags Details | Diff
/etc/sysconfig/milter-greylist file (205 bytes, text/plain)
2005-07-02 18:21 EDT, Milan Kerslager
no flags Details
Fixed patch for init script (1.47 KB, patch)
2005-07-08 16:08 EDT, Milan Kerslager
no flags Details | Diff
Fixed /etc/sysconfig/milter-greylist file (226 bytes, text/plain)
2005-07-08 16:10 EDT, Milan Kerslager
no flags Details
Patch for SPEC file to utilize /etc/sysconfig/milter-greylist (1.94 KB, patch)
2005-07-08 16:25 EDT, Milan Kerslager
no flags Details | Diff

  None (edit)
Description Milan Kerslager 2005-07-02 18:19:05 EDT
The initscript for milter-greylist isbroken. There are fixed parameters for PID
file, socket path and run-as-user. Commandline arguments take precedence of
config file so editing config file is worthless and editing init scripts means
that the next update will remove our changes.

So please apply the attached patch to honor config file and allow to override
command line parameters via /etc/sysconfig/milter-greylist. The patch does not
change current behavior, just add new feature.

Working RPM package with SRC package could be found at:
Comment 1 Milan Kerslager 2005-07-02 18:19:06 EDT
Created attachment 116299 [details]
Patch for init script for milter-greylist
Comment 2 Milan Kerslager 2005-07-02 18:21:39 EDT
Created attachment 116300 [details]
/etc/sysconfig/milter-greylist file

This /etc/sysconfig/milter-greylist file is like other config files for
initscriptsin FC or RHEL (httpd, sendmail etc).
You have to add this file to the SPEC file, see URL above with working packages
for RHEL3 and RHEL4.
Comment 3 Milan Kerslager 2005-07-08 16:09:00 EDT
Created attachment 116534 [details]
Fixed patch for init script

There was a wrong patch to the socket file in the first (now obsoleted) patch.
Comment 4 Milan Kerslager 2005-07-08 16:10:58 EDT
Created attachment 116536 [details]
Fixed /etc/sysconfig/milter-greylist file

Same wrong path to the socket file has been fixed.
Comment 5 Milan Kerslager 2005-07-08 16:25:28 EDT
Created attachment 116537 [details]
Patch for SPEC file to utilize /etc/sysconfig/milter-greylist

Just to show how the SPEC file should be changed to utilize
Comment 6 Russell Coker 2005-12-23 07:02:11 EST
While making such changes please put the socket into /var/run by default. 
Above is the FHS reference for the /var/run directory.  Below is the relevant 
"System programs that maintain transient UNIX-domain sockets must place them 
in this directory" 
Comment 7 Enrico Scholz 2005-12-24 08:00:43 EST
ok, I changed 1.6 (FC-4) to read /etc/sysconfig/milter-greylist so that
'OPTIONS' can be overridden there.

I did not added the GRUSER/GRSOCKET/GRPIDFILE code because it is too complicated
for an initscript and slows down the bootprocess. It won't be compatible with
'initng' initmethod.

In FC-5/devel branch, the user and socket will be set in the configfile only.

I changed the location of the socket as suggested in comment #6, too. But only
in devel, not in FC-4 because an upgrade might break existing installations else.

Note You need to log in before you can comment on or make changes to this bug.