I'm not yet actually using DirectFB, but I soon will most likely be. So I took a look at the package, and made some improvements (IMO ;)). See attached patch, changes: - License is LGPL, not GPL. - Build i830 driver. - Don't disable MMX/SSE, detected at runtime and used if available (AFAICT) - Include support for sysfs, video4linux2, and zlib. - Fix -devel dependencies. - Clean up installed -devel docs. - Don't build static libs. - Clean up unneeded %configure options. (-Could add --disable-dependency-tracking to %configure if you like.) About dropping static libs: it this is not a good idea and/or you don't want it, I think at least moving the *.o and *.a files from various dirs below /usr/lib/directfb-0.9.22 to the -devel package. (BTW, do you know why does it install *.o in the first place?) Let me know what you think of the above. I can also commit this (or some of these) if you like.
Created attachment 116305 [details] Suggested specfile patch
Created attachment 116306 [details] Suggested specfile patch Damn, wrong patch, here's the correct one. Also, compared to the previous one, this does not use --enable-zlib (which just seems to gzip screenshots on the fly; I guess that's probably not something most people want).
Created attachment 116307 [details] Suggested specfile patch Crap, STILL the wrong patch. Now, this is really the correct one. Sorry about the noise.
ping
ping #2... Thomas, are you alive? I'll go ahead and commit this unless I hear objections this week.
I put in most of your changes and commited the current spec file without actually tagging and requesting a build. I put back enable-static and enable-shared an disable-maintainer-mode. Per your suggestion I moved the .a and .o files to the devel packages. I'm not sure exactly why the .o files get installed, I'll see if I can figure that out. But I definately want the .a files there, since for embedded development often linking everything in is preferred. Let me know if you think this new version is ok (I also updated to a new upstream release) and I'll tag and build.
Created attachment 116935 [details] New suggested patch Thanks, looks much better now. Here's a couple of new and already submitted bits with clarifications, just in case you weren't aware of some of them; feel free to cherry pick from here what you find worth applying: - Fixed Group tag of main package - --disable-maintainer-mode and --enable-shared are the defaults, so removed - Dropped --disable-avifile; the option no longer exists. - Added --disable-dependency-tracking for slightly faster build, and slightly more readable build output. - Tuned spaces vs tabs in %build. - And last, a pretty important one: fix directory ownerships in the main package.
the reason I keep disable-maintainer-mode and --enable-shared is because they haven't been defaults in the past, and directfb's build setup does change a bit between releases.
working on this, assigning to me.
Hi Hans, uh, what's going on ?
Because you did not respond (at all) to bug 168343, I asked at fedora-extras mailing list if it was a good idea if I were to take over the maintainership of directfb, see: https://www.redhat.com/archives/fedora-extras-list/2005-November/msg01346.html I got a reply which said to go ahead: https://www.redhat.com/archives/fedora-extras-list/2005-November/msg01348.html So I've been busy today putting all the improvements in this bug into the spec files for both FC-4 and devel and to make life easier merge the specfiles. As a result of this there is now a (identical) directfb-0.9.24-4 in both FC-4 and devel CVS. Unfortunatly the build fails al-weirdo for the FC-4 version on x86_64 I've had strange build errors on x86_64 lately more often, so I believe this is a build machine issue. Anyways it seems that we have a problem here as directfb has 2 maintainers now, are you ok with me taking over or do you want to keep maintaining it? If you want to keep maintainig it I'll make you the owner of the bugzilla component again, finish what I started (IOW directfb-0.9.24-4) and leave directfb up to you.
directfb-0.9.24-4 should show up in extras within a day. Fixing this bug.