Bug 162370 - comparisons like X<=Y<=Z do not have their mathematical meaning
Summary: comparisons like X<=Y<=Z do not have their mathematical meaning
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: librsvg2
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-07-03 12:02 UTC by David Binderman
Modified: 2007-11-30 22:11 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2005-08-16 15:25:15 UTC


Attachments (Terms of Use)

Description David Binderman 2005-07-03 12:02:08 UTC
Description of problem:

I just tried to compile package librsvg2-2.9.5-2 from Redhat
Fedora Core development tree with the gcc 4.0.0 compiler and
the compiler flag -Wall.

The compiler said

rsvg-shapes.c:1845: warning: comparisons like X<=Y<=Z do not have their
mathematical meaning

The source code is

	if (height * *w >
		width * *h != (aspect_ratio & RSVG_ASPECT_RATIO_SLICE))

I agree with the compiler. Suggest code rework for maintainability.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Matthias Clasen 2005-08-16 15:25:15 UTC
librsvg cvs has added parens there to clarify the meaning.


Note You need to log in before you can comment on or make changes to this bug.