Spec URL: https://ppisar.fedorapeople.org/perl-TestML1/perl-TestML1.spec SRPM URL: https://ppisar.fedorapeople.org/perl-TestML1/perl-TestML1-0.57-1.fc30.src.rpm Description: TestML is a generic, programming language agnostic, meta language for writing unit tests. The idea is that you can use the same test files in multiple implementations of a given programming idea. Then you can be more certain that your application written in, say, Python matches your Perl implementation. In a nutshell you write a bunch of data tests that have inputs and expected results. Using a simple syntax, you specify what functions the data must pass through to produce the expected results. You use a bridge class to write the data functions that pass the data through your application. In Perl 5, TestML is the evolution of the Test::Base module. It has a superset of Test:Base's goals. The data markup syntax is currently exactly the same as Test::Base. You may want to use perl-TestML instead that supports a new generation of the meta language. Fedora Account System Username: ppisar This packaged software is a fork of TestML (already packaged as perl-TestML) because TestML will be upgraded to an incompatible version in the future. Thus the code and the spec files are very similar.
URL and Source addresses are Ok. Source archive (SHA-256: 5e90a82456e228fd946e50ac7847e3c3fbd923a76031d478ea618888f95c1733) is original. Ok. Summary verified from lib/TestML1.pod. Ok. Description verified from lib/TestML1.pod. Ok. License verified from lib/TestML1.pod and README. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-TestML1.spec review-perl-TestML1/results/perl-TestML1-0.57-1.fc30.noarch.rpm review-perl-TestML1/results/perl-TestML1-0.57-1.fc30.src.rpm perl-TestML1.noarch: W: spelling-error %description -l en_US superset -> super set, super-set, supersede perl-TestML1.src: W: spelling-error %description -l en_US superset -> super set, super-set, supersede 2 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpm -q -lv -p perl-TestML1-0.57-1.fc30.noarch.rpm drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/doc/perl-TestML1 -rw-r--r-- 1 root root 1263 juil. 28 17:01 /usr/share/doc/perl-TestML1/CONTRIBUTING -rw-r--r-- 1 root root 3963 juil. 28 17:01 /usr/share/doc/perl-TestML1/Changes -rw-r--r-- 1 root root 2823 juil. 28 17:01 /usr/share/doc/perl-TestML1/README drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/licenses/perl-TestML1 -rw-r--r-- 1 root root 18352 juil. 28 17:01 /usr/share/licenses/perl-TestML1/LICENSE -rw-r--r-- 1 root root 2464 août 31 20:00 /usr/share/man/man3/TestML1.3pm.gz -rw-r--r-- 1 root root 1510 août 31 20:00 /usr/share/man/man3/TestML1::Setup.3pm.gz drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/TestML1 -rw-r--r-- 1 root root 1067 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1.pm -rw-r--r-- 1 root root 2816 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1.pod -rw-r--r-- 1 root root 1987 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Base.pm -rw-r--r-- 1 root root 79 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Bridge.pm drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/TestML1/Compiler -rw-r--r-- 1 root root 3606 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Compiler.pm -rw-r--r-- 1 root root 6186 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Compiler/Lite.pm drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/TestML1/Compiler/Pegex -rw-r--r-- 1 root root 1546 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Compiler/Pegex.pm -rw-r--r-- 1 root root 4443 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Compiler/Pegex/AST.pm -rw-r--r-- 1 root root 10596 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Compiler/Pegex/Grammar.pm drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/TestML1/Library -rw-r--r-- 1 root root 101 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Library.pm -rw-r--r-- 1 root root 546 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Library/Debug.pm -rw-r--r-- 1 root root 4130 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Library/Standard.pm drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/TestML1/Runtime -rw-r--r-- 1 root root 12963 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Runtime.pm -rw-r--r-- 1 root root 2437 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Runtime/TAP.pm -rw-r--r-- 1 root root 3302 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Setup.pm -rw-r--r-- 1 root root 1183 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Setup.pod -rw-r--r-- 1 root root 495 juil. 28 17:01 /usr/share/perl5/vendor_perl/TestML1/Util.pm drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/auto drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/auto/share drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/auto/share/dist drwxr-xr-x 2 root root 0 août 31 20:00 /usr/share/perl5/vendor_perl/auto/share/dist/TestML1 -rw-r--r-- 1 root root 3457 juil. 28 17:01 /usr/share/perl5/vendor_perl/auto/share/dist/TestML1/testml.pgx File permissions and layout are Ok. $ rpm -q --requires -p perl-TestML1-0.57-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.0) 1 perl(constant) 1 perl(Cwd) 1 perl(Exporter) 1 perl(File::Basename) 1 perl(File::Spec) 1 perl(IO::All) 1 perl(Pegex) >= 0.30 1 perl(Pegex::Parser) 1 perl(strict) 1 perl(Template::Toolkit::Simple) 1 perl(Test::Builder) 1 perl(TestML1) 1 perl(TestML1::Base) 1 perl(TestML1::Compiler::Pegex::AST) 1 perl(TestML1::Compiler::Pegex::Grammar) 1 perl(TestML1::Runtime) 1 perl(TestML1::Util) 1 perl(Text::Diff) 1 perl(warnings) 1 perl(XXX) 1 perl(YAML::XS) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p perl-TestML1-0.57-1.fc30.noarch.rpm perl(TestML1) = 0.57 perl(TestML1::Assertion) perl(TestML1::Assignment) perl(TestML1::Base) perl(TestML1::Block) perl(TestML1::Bool) perl(TestML1::Bridge) perl(TestML1::Call) perl(TestML1::Callable) perl(TestML1::Compiler) perl(TestML1::Compiler::Lite) perl(TestML1::Compiler::Pegex) perl(TestML1::Compiler::Pegex::AST) perl(TestML1::Compiler::Pegex::Grammar) perl(TestML1::Constant) perl(TestML1::Error) perl(TestML1::Expression) perl(TestML1::Function) perl(TestML1::Library) perl(TestML1::Library::Debug) perl(TestML1::Library::Standard) perl(TestML1::List) perl(TestML1::Native) perl(TestML1::None) perl(TestML1::Num) perl(TestML1::Object) perl(TestML1::Point) perl(TestML1::Runtime) perl(TestML1::Runtime::TAP) perl(TestML1::Setup) perl(TestML1::Statement) perl(TestML1::Str) perl(TestML1::Util) perl-TestML1 = 0.57-1.fc30 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=29401209). Ok The package is in line with Fedora and Perl packaging guidelines. Resolution: Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-TestML1
Thank you for the review and the repository.