Bug 1645817 - Wrong section alignment for .note.gnu.property
Summary: Wrong section alignment for .note.gnu.property
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: annobin
Version: 29
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-04 01:27 UTC by H.J. Lu
Modified: 2019-11-27 19:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-27 19:46:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description H.J. Lu 2018-11-04 01:27:33 UTC
[hjl@gnu-skl-1 ~]$ readelf -SW /sbin/sheep
There are 31 section headers, starting at offset 0x5fb00:

Section Headers:
  [Nr] Name              Type            Address          Off    Size   ES Flg Lk Inf Al
  [ 0]                   NULL            0000000000000000 000000 000000 00      0   0  0
  [ 1] .interp           PROGBITS        0000000000000270 000270 00001c 00   A  0   0  1
  [ 2] .note.ABI-tag     NOTE            000000000000028c 00028c 000020 00   A  0   0  4
  [ 3] .note.gnu.property NOTE            00000000000002ac 0002ac 000030 00   A  0   0  4
  [ 4] .note.gnu.build-id NOTE            00000000000002dc 0002dc 000024 00   A  0   0  4

.note.gnu.property section should be aligned at 8 bytes, not 4 bytes.

Comment 1 Nick Clifton 2018-11-05 15:31:59 UTC
Hi H.J.

  What does this have to do with annobin ?

  I am not familiar with the sheep program.  Is it linked with gold or the bfd 
  linker ?

  Given that there is only one note in the .note.gnu.property section I would
  assume that this is a minor bug, but I will take a look nonetheless.

Cheers
  Nick

Comment 2 H.J. Lu 2018-11-05 15:57:46 UTC
(In reply to Nick Clifton from comment #1)
> Hi H.J.
> 
>   What does this have to do with annobin ?

I believe it is generated by annobin:

%_annobin_cflags	-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1
redhat/macros:%_annotated_cflags	%{?_annotated_build:%{_annobin_cflags}}
redhat/redhat-annobin-cc1:+ %{!-fno-use-annobin:%{!iplugindir*:%:find-plugindir()} -fplugin=annobin}


>   I am not familiar with the sheep program.  Is it linked with gold or the
> bfd 
>   linker ?
> 

bfd linker.

Comment 3 Nick Clifton 2018-11-05 17:12:57 UTC
Hi H.J.

> I believe it is generated by annobin:

Ah - thanks.  That was the hint that I needed.  (I must confess that I
had forgotten that annobin can generate those notes.  Doh).  Anyway I 
have checked a patch into annobin (f29 and rawhide) so that in the
future GNU Property notes on x86_64 targets will be generated with
8-byte alignment.

This does leave the small fact that all current F29 x86_64 annotated 
binaries will have the mis-aligned property notes.  But as mentioned
earlier I hope that this will not be a problem as there is only one
note in the section.

Chers
  Nick

Fixed in: annobin-8.23-2.fc29 and annobin-8.59-1.fc30

Comment 4 Ben Cotton 2019-10-31 20:33:59 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2019-11-27 19:46:34 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.