Bug 1647147 - Review Request: pmdk-convert - Conversion tool for PMDK pools
Summary: Review Request: pmdk-convert - Conversion tool for PMDK pools
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Dan Williams
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1488828 1634347 1654309 1659658 1659666
TreeView+ depends on / blocked
 
Reported: 2018-11-06 18:33 UTC by Marcin Ślusarz
Modified: 2019-03-07 15:49 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-12-17 13:41:48 UTC
Type: Bug
Embargoed:
dan.j.williams: fedora-review+


Attachments (Terms of Use)

Description Marcin Ślusarz 2018-11-06 18:33:11 UTC
Spec URL:
https://raw.githubusercontent.com/marcinslusarz/packages/master/pmdk-convert/pmdk-convert.spec

SRPM URL:
https://github.com/marcinslusarz/packages/raw/master/pmdk-convert/pmdk-convert-1.5-1.fc28.src.rpm

Description:
pmdk-convert is a tool for conversion of PMDK pools from any version
to any consecutive version. Currently only libpmemobj pools require
conversion and this tool supports only those kind of pools.

pmdk-convert became a separate project from PMDK with the 1.5 release.

Fedora Account System Username: marcinslusarz

Comment 1 Dan Williams 2018-11-07 18:46:35 UTC
Please provide the output of fedora-review after addressing reported issues.

Comment 2 Marcin Ślusarz 2018-11-09 21:11:36 UTC
Output of fedora-review is quite noisy and I don't see any way to fix the 2 issues that spit 800 lines of this noise.


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/common/out.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/common/sys_util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/common/util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/include/libpmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/include/libpmemobj.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemblk/blk.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemblk/btt_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemlog/log.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/bucket.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/ctree.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/cuckoo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/heap.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/heap_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/lane.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/list.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/memops.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/obj.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/pmalloc.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/redo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/libpmemobj/sync.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/tools/pmempool/common.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.0/src/tools/pmempool/output.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/common/out.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/common/sys_util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/common/util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/include/libpmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/include/libpmemobj.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemblk/blk.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemblk/btt.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemblk/btt_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/bucket.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/ctree.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/cuckoo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/heap.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/heap_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/lane.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/list.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/memblock.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/memops.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/obj.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/pmalloc.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/pvector.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/redo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/sync.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/libpmemobj/tx.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/tools/pmempool/common.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.1/src/tools/pmempool/output.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/dlsym.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/file.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/mmap.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/out.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/pmemcommon.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/pool_hdr.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/set.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/sys_util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/common/uuid.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/include/libpmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/include/libpmemobj/base.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/include/libpmemobj/pool_base.h
  pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/include/libpmemobj/thread.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/include/libpmemobj/tx_base.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/include/librpmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemblk/blk.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemblk/btt.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemblk/btt_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/bucket.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/ctree.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/cuckoo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/heap.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/heap_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/lane.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/list.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/memblock.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/memops.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/obj.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/palloc.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/pmalloc.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/pmemops.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/pvector.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/redo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/sync.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/libpmemobj/tx.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/tools/pmempool/common.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.2/src/tools/pmempool/output.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/dlsym.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/file.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/fs.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/mmap.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/os.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/os_badblock.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/os_deep.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/os_dimm.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/os_thread.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/out.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/pmemcommon.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/pool_hdr.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/set.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/shutdown_state.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/sys_util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/util_pmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/uuid.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/valgrind/drd.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/valgrind/helgrind.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/valgrind/memcheck.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/valgrind/pmemcheck.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/valgrind/valgrind.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/common/valgrind_internal.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/include/libpmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/include/libpmemobj/action_base.h
  pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/include/libpmemobj/base.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/include/libpmemobj/ctl.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/include/libpmemobj/pool_base.h
  pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/include/libpmemobj/thread.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/include/libpmemobj/tx_base.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/include/librpmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemblk/blk.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemblk/btt.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemblk/btt_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/alloc_class.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/bucket.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/container.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/container_ravl.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/container_seglists.h
  pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/ctl.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/ctl_global.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/cuckoo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/heap.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/heap_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/lane.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/list.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/memblock.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/memops.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/obj.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/palloc.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/pmalloc.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/pmemops.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/pvector.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/ravl.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/recycler.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/redo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/ringbuf.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/stats.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/sync.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/libpmemobj/tx.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/tools/pmempool/common.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.4/src/tools/pmempool/output.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/badblock.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/ctl.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/ctl_global.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/dlsym.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/extent.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/file.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/fs.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/mmap.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/os.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/os_auto_flush.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/os_badblock.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/os_deep.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/os_dimm.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/os_thread.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/out.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/pmemcommon.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/pool_hdr.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/set.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/shutdown_state.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/sys_util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/util.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/util_pmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/uuid.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/valgrind/drd.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/valgrind/helgrind.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/valgrind/memcheck.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/valgrind/pmemcheck.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/valgrind/valgrind.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/valgrind_internal.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/vec.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/common/vecq.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/include/libpmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/include/libpmemobj/action_base.h
  pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/include/libpmemobj/base.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/include/libpmemobj/ctl.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/include/libpmemobj/pool_base.h
  pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/include/libpmemobj/thread.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/include/libpmemobj/tx_base.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/include/librpmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmem/pmem.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmem/x86_64/cpu.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmem/x86_64/flush.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmem/x86_64/memcpy_memset.h
  pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemblk/blk.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemblk/btt.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemblk/btt_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemlog/log.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/alloc_class.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/bucket.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/container.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/container_ravl.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/container_seglists.h
  pmdk-convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/ctl_debug.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/cuckoo.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/heap.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/heap_layout.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/lane.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/list.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/memblock.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/memops.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/obj.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/palloc.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/pmalloc.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/pmemops.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/ravl.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/recycler.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/stats.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/sync.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/tx.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/libpmemobj/ulog.h pmdk-convert-
  debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/tools/pmempool/common.h pmdk-
  convert-debugsource : /usr/src/debug/pmdk-
  convert-1.5-1.fc28.x86_64/nvml-1.5/src/tools/pmempool/output.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "CDDL", "Unknown or generated". 17 files have
     unknown license. Detailed output of licensecheck in
     /home/mslusarz/packages/pmdk-convert/pmdk-convert/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/.build-id/8d(ghc-
     data-default-instances-old-locale, argyllcms, nss-tools, libpaper,
     dwz, gnome-software, gstreamer1-plugins-bad-free, ImageMagick-libs,
     sane-backends-drivers-scanners, coreutils, glusterfs, libcryptui,
     frei0r-plugins, libxcb, rygel, gvfs-fuse, glibc, pam), /usr/lib
     /.build-id/dd(argyllcms, bind-utils, gstreamer1-plugins-bad-free,
     ImageMagick-libs, python3-libs, gdb-headless, totem, perl-interpreter,
     python2-libs, libnl3-cli, util-linux, libijs), /usr/lib/.build-
     id/43(iptables, httpd, systemd, GConf2, libgphoto2, cups-libs, gnome-
     software, glibc, pulseaudio, gawk, polkit, glusterfs, libsigsegv,
     libao, xfsprogs, libfontenc, clang-libs, frei0r-plugins), /usr/lib
     /.build-id/53(libreport-gtk, libuser, ghc-base-compat, lvm2, liblouis,
     perl-interpreter, gnome-software, lldpad, cmake, coreutils, gstreamer1
     -plugins-base, gcr, ntfsprogs, python3-pillow, groff-base, librbd1,
     libdb-utils, ghc-HTTP, sane-backends-drivers-scanners, libusb, util-
     linux, atkmm, evolution, elfutils-libs, sssd-krb5-common, pulseaudio,
     krb5-libs, libunwind, cdparanoia-libs), /usr/lib/.build-id(gd, ghc-
     array, libwayland-server, poppler-utils, virglrenderer, libreport-gtk,
     iputils, qt5-qtxmlpatterns, totem, ghc-cmark-gfm, numactl-libs, nss-
     tools, gc, ghc-async, iproute-tc, libwmf-lite, python3-cups,
     libxshmfence, qemu-block-gluster, qemu-block-curl, ncurses-c++-libs,
     gpgme, osinfo-db-tools, libsndfile, abrt, xorg-x11-drv-openchrome,
     ghc-transformers, babl, libmediaart, libmcpp, libibverbs,
     libimagequant, giflib, gdb-headless, ghc-th-abstraction, createrepo_c-
     libs, ghc-ghc-boot-th, trousers, dleyna-core, NetworkManager-team,
     libgovirt, bzip2-libs, libqmi-utils, abrt-addon-pstoreoops, file,
     libmbim-utils, psacct, dbus-libs, ghc-asn1-parse, libdb-utils,
     tracker-miners, xorg-x11-font-utils, grilo, gtk2, gtk3, libwayland-
     egl, lame-libs, ghc-conduit, cups-client, libseccomp, gnutls, gnome-
     bluetooth-libs, atkmm, perl-Digest-SHA, npth, abrt-addon-coredump-
     helper, p11-kit, libyaml, iptables-libs, ghc-transformers-base,
     device-mapper-persistent-data, perl-Params-Validate, cryptsetup-libs,
     ghc-exceptions, gnome-control-center, gnome-system-monitor, libmodman,
     libkcapi, ghc-semigroups, libselinux-utils, perl-Scalar-List-Utils,
     systemd-libs, argyllcms, parted, gnome-disk-utility, ghc-asn1-types,
     gspell, libdvdread, ghc-x509-validation, udisks2-iscsi, xcb-util-
     image, m17n-lib, bluez-libs, libblockdev-mdraid, rng-tools, glusterfs,
     exiv2-libs, ghc-process, libinput, libwebp, libxslt, gdbm, libkcapi-
     hmaccalc, libreport-cli, libpkgconf, system-config-printer-udev,
     python3-dmidecode, libunistring, abrt-gui-libs, keyutils-libs, perl-
     Encode, libverto-libev, libproxy, libevdev, libgpg-error, sssd-common-
     pac, lvm2-libs, libosinfo, dleyna-server, abrt-gui, libgcab1,
     libtimezonemap, perl-Data-Dumper, upower, isns-utils-libs,
     qgnomeplatform, ghc-unordered-containers, libqmi, gutenprint-cups,
     gstreamer1-plugins-good, gawk, dmraid-events, pcsc-lite-libs,
     python2-rpm, libasyncns, ibus-m17n, adwaita-gtk2-theme,
     libbasicobjects, ghc-text, device-mapper-multipath, c-ares, libdazzle,
     xmlsec1-openssl, ghc-mmorph, lua-lpeg, symlinks, libvirt-daemon-
     driver-network, ghostscript, perl-libs, ethtool, gfbgraph,
     python3-cryptography, baobab, rdma-core, NetworkManager-pptp-gnome,
     ghc-haddock-library, jansson, vte291, ghc-yaml, b43-fwcutter,
     libgweather, tsocks, sssd-krb5, e2fsprogs-libs, ghc-tls, perl-Params-
     Util, bolt, librsvg2, perl-PathTools, efivar-libs, lcms2, alsa-utils,
     apr, libatasmart, ghc-split, ghc-pretty, mlocate, libsss_nss_idmap,
     brotli, qemu-guest-agent, annobin, deltarpm, file-libs, libgrss,
     grub2-tools, gupnp-dlna, attr, trousers-lib, libyubikey, gnome-
     initial-setup, avahi-glib, python3-pycurl, mokutil, openconnect,
     libblockdev-swap, tar, xcb-util-keysyms, libreport-plugin-systemd-
     journal, libnetfilter_conntrack, webrtc-audio-processing, bcache-
     tools, python3-gobject, startup-notification, libijs, m4, ghc-data-
     default-instances-containers, frei0r-plugins, ghc-Glob,
     python2-hawkey, fprintd-pam, flatpak-libs, gstreamer1-plugins-bad-
     free, ghc-aeson-pretty, libvdpau, libusbx, bind-export-libs,
     hypervvssd, libgphoto2, rpm-plugin-systemd-inhibit, git-core, compat-
     openssl10, mutter, gstreamer1-plugins-ugly-free, qrencode-libs,
     libICE, pinfo, libgexiv2, ndctl, drpm, xcb-util, gvfs-fuse, qemu-
     block-nfs, gnome-maps, evolution-data-server, abrt-plugin-bodhi, apr-
     util-bdb, bubblewrap, libgpod, mc, gcc-c++, libtasn1, speexdsp,
     libblockdev-dm, python3-coverage, xcb-util-renderutil, ghc-hashable,
     ghc-data-default-class, anaconda-widgets, dleyna-renderer, iptables,
     sqlite, http-parser, sssd-ad, perl-interpreter, xcb-util-wm, ghc-mtl,
     sudo, speech-dispatcher-espeak, nmap-ncat, libvirt-gconfig, logrotate,
     unzip, dhcp-client, fprintd, dbxtool, pinentry-gtk, libarchive,
     libvirt-daemon-driver-nwfilter, apr-util-openssl, libgfortran,
     libmount, gcc, systemd-bootchart, scl-utils, dwz, alsa-lib, libdnet,
     libsoup, accountsservice, xorg-x11-drv-qxl, gcr, ntfsprogs, evince-
     nautilus, abrt-libs, libpmem, ebtables, libvirt-daemon-driver-storage-
     disk, brasero-libs, efibootmgr, libproxy-mozjs, libgdither, ghc-
     deepseq, dbusmenu-qt, sgpio, ncurses-libs, libidn2, ghc-hxt-regex-
     xmlschema, clang, ghc-base64-bytestring, samba-common-libs, pigz,
     PackageKit-command-not-found, suitesparse, libpsl, OpenEXR-libs,
     lbzip2, gnome-color-manager, ghc-hslua, gdbm-libs, fcoe-utils,
     fribidi, xorg-x11-xkb-utils, ibus-hangul, libgnomekbd, libblockdev-
     kbd, libcom_err, NetworkManager-openvpn, ibus-rawcode, libxkbfile,
     libcurl, ghc-regex-base, python3-rpm, pciutils, nautilus-sendto,
     libwvstreams, fwupdate-libs, jimtcl, ghc-binary, libreofficekit,
     openssh-clients, xmlrpc-c-client, ghc-digest, sane-backends-drivers-
     cameras, python3-hawkey, libX11, gvfs-smb, celt051, kbd, graphviz,
     kexec-tools, libvorbis, spice-glib, kyotocabinet-libs,
     python3-pwquality, qemu-block-ssh, gvfs-mtp, gssdp, systemd, util-
     linux, ghc-template-haskell, gnome-calendar, lvm2, evince-libs, ghc-
     zlib, satyr, gupnp-igd, libwnck3, libwayland-cursor, gnome-software,
     xorg-x11-drv-ati, libnl3, libcap-ng, ghc-mime-types, libSM,
     policycoreutils, mcelog, gnome-font-viewer, libpaper, libsmartcols,
     libmusicbrainz5, ghc-unix, pptp, wpa_supplicant, libidn, sane-
     backends-drivers-scanners, libXxf86misc, libwacom, libbluray,
     foomatic, grubby, libatomic_ops, lzo, cifs-utils, NetworkManager-wifi,
     pango, colord-gtk, pcre2-utf16, libss, aspell, mod_dnssd, epiphany-
     runtime, libpath_utils, dbus, libfabric, qemu-block-rbd, vpnc,
     python3-systemd, psmisc, net-snmp-libs, perl-threads, rpm-ostree-libs,
     rpm-sign-libs, rpm-build, libnl3-cli, pangomm, ibus-libs, ghc-
     hourglass, libsss_certmap, libvirt-daemon-driver-storage-sheepdog,
     libglvnd-gles, xorg-x11-drv-libinput, python2-libcomps, libblockdev-
     mpath, cairo, mesa-libxatracker, audit-libs, fwupd, sssd-ldap, nss-
     sysinit, polkit, bluez, libgcc, gdisk, ilmbase, libvirt-daemon-driver-
     storage-iscsi, gstreamer1, gettext-libs, p11-kit-trust, gom, iio-
     sensor-proxy, nss-mdns, avahi-libs, libref_array, gmime30,
     python3-cffi, poppler, llvm-libs, mesa-dri-drivers, webkit2gtk3
     -plugin-process-gtk2, libstemmer, gvfs-afc, sshpass, djvulibre-libs,
     switcheroo-control, dmraid, cairo-gobject, ghc-old-time, ibus-
     libzhuyin, compiler-rt, fftw-libs-double, xdg-desktop-portal-gtk, net-
     tools, ModemManager, paps, gnome-screenshot, at-spi2-core, plymouth-
     plugin-two-step, libvirt-daemon-driver-storage-scsi, libkkc, sbc,
     qemu-img, git, gegl03, ghc-cookie, ghc-random, libhangul, gutenprint,
     rtkit, usermode, orc, bash, glibc-common, daxctl-libs, poppler-glib,
     NetworkManager-openvpn-gnome, qpdf-libs, linux-atm-libs, libedit,
     python3-abrt, python3-librepo, libuuid, atk, wavpack, python3-cairo,
     libblockdev-lvm, ghc-containers, ibus-gtk3, ibus-gtk2, ghc-basement,
     isl, ghc-integer-logarithms, augeas-libs, ibus-kkc, python2-pyyaml,
     hfsplus-tools, cheese, ghc-safe, openldap, ImageMagick, gssproxy,
     mpg123-libs, paps-libs, tcp_wrappers, libblockdev-btrfs, harfbuzz,
     libpinyin, xz, libXcomposite, vconfig, mtools, gupnp-av,
     python3-libxml2, SFML, libnfs, systemd-pam, libmpcdec, ghc-case-
     insensitive, gtk-update-icon-cache, vim-minimal, harfbuzz-icu, vino,
     pandoc, stoken-libs, ntpdate, atlas, libplist, gnome-contacts, ghc-
     syb, python3-wrapt, python2-smartcols, NetworkManager-libnm, xdg-user-
     dirs, ghc-x509, systemd-container, zstd, libiscsi, NetworkManager,
     libquvi, python3-markupsafe, glusterfs-libs, gnome-boxes, groff-base,
     mesa-libgbm, libdatrie, spice-server, libreport-plugin-logger, gdk-
     pixbuf2, libvirt-daemon-driver-qemu, glade-libs, svgalib, setuptool,
     lrzsz, gupnp, dos2unix, libreport, libusb, telnet, libevent,
     libipa_hbac, liblouis, python2-cccolutils, libtalloc, mesa-libGL,
     abrt-addon-ccpp, libldb, grep, guile, xorg-x11-drv-wacom, libsmbios,
     ghc-tf-random, pcre-utf16, tree, gnome-characters, ghc-tagged,
     xorg-x11-server-Xorg, NetworkManager-vpnc, mdadm, pipewire, libepoxy,
     ghc-monad-control, gnupg, pixman, libipt, perl-Storable, libcanberra,
     gvfs-goa, rpm-plugin-selinux, cronie-anacron, gvfs-archive, xfsprogs,
     authselect, man-db, libcroco, ghc-utf8-string, gedit, gnome-abrt,
     libgcrypt, PackageKit-gstreamer-plugin, libappstream-glib,
     libblockdev, socat, librdmacm, libgudev, dconf, xz-libs, dbus-glib,
     cyrus-sasl-plain, bind-libs-lite, timedatex, libsrtp, perl-Package-
     Stash-XS, telepathy-glib, samba-client-libs, libdvdnav, plymouth-
     plugin-label, libspectre, ghc-filepath, colord-libs, which, libcap,
     xmlto, libvirt-daemon-driver-storage-zfs, samba-client, openssh-
     server, glib-networking, lua-expat, wireless-tools, hplip-libs, libdb,
     exiv2, passwd, cups-pk-helper, efivar, quota, kmod-libs, libvirt-
     daemon-driver-storage-gluster, gzip, libdv, gutenprint-libs, ghc-http-
     client-tls, libgomp, desktop-file-utils, libXdamage, hypervfcopyd,
     cronie, xen-libs, ghc-directory, xorg-x11-utils, rpm-libs,
     python2-krbv, brlapi, strace, libusal, mod_http2, NetworkManager-pptp,
     soundtouch, ghc-dlist, nettle, ndctl-libs, createrepo_c, libunwind,
     tracker, gnome-session, dleyna-connector-dbus, gtkmm30, geoclue2,
     libv4l, libini_config, elfutils, ghc-hslua-module-text, keyutils,
     liboauth, python2-cryptography, colord, adcli, libpipeline,
     pkcs11-helper, accountsservice-libs, ghc-http-types, xmlsec1,
     libtirpc, libuser, ghc-aeson, findutils, popt, gsound, fakeroot-libs,
     ghc-memory, bind-libs, libsss_idmap, gobject-introspection,
     pulseaudio, libpwquality, python2-librepo, libraw1394, libwsman1,
     qemu-block-dmg, fontconfig, krb5-workstation, xorg-x11-drv-vmware,
     folks, os-prober, gnome-clocks, jbigkit-libs, ghc-hxt-unicode,
     python2-libs, python3-dbus, info, freetype, enchant2, libsmbclient,
     ghc-lifted-base, ykpers, libfprint, ghc-vector, libjpeg-turbo,
     pulseaudio-libs, cpio, libnghttp2, lz4, xapian-core-libs, libfdisk,
     lz4-libs, evince-djvu, libtar, usb_modeswitch, tbb, libdaemon, woff2,
     ghc-pandoc, hypervkvpd, ghc-JuicyPixels, evolution, dotconf, qt, abrt-
     retrace-client, ghc-x509-system, perl-Sort-Key, evince, PackageKit-
     glib, patch, krb5-libs, elfutils-libs, sqlite-libs, gnome-online-
     accounts, libconfig, lttng-ust, teamd, anaconda-core, enchant,
     pkgconf, NetworkManager-openconnect-gnome, rpcbind, enca, libXxf86dga,
     ghc-regex-pcre, json-c, python3-libselinux, rhash, xdg-user-dirs-gtk,
     ghc-base, libwayland-client, gtksourceview3, pinentry-gnome3,
     libpciaccess, sed, libXres, libvirt-daemon, libkadm5, libsss_autofs,
     perl-threads-shared, libchamplain, flatpak, libaio, kmod,
     NetworkManager-ssh-gnome, nss-util, gnome-calculator, device-mapper,
     libgs, gdm, lua, libXtst, gnome-user-share, ghc-HTTP, libpng, openssl-
     libs, ghc-unliftio-core, sane-backends-libs, python3-pillow, ghc-old-
     locale, sssd-client, libgxps, gnome-terminal, GeoIP, libvirt-daemon-
     driver-nodedev, cyrus-sasl, gnome-bluetooth, webkit2gtk3-jsc, libpeas-
     loader-python3, dhcp-libs, hardlink, libsigc++20, ghc-pem, highlight,
     libcollection, opencc, ghc-http-client, libXrandr, newt, libglvnd-egl,
     doxygen, libsolv, pulseaudio-module-bluetooth, libxkbcommon, liba52,
     hplip, ghc-QuickCheck, ghc-zip-archive, cairomm, device-mapper-
     multipath-libs, libzstd, yajl, lockdev, ghc-resourcet, nss-softokn,
     lasi, passwdqc, libXft, lsof, libical, at-spi2-atk, kpartx,
     qt5-qtdeclarative, sssd-ipa, ghc-skylighting, sheepdog, libnsl2,
     hyphen, twolame-libs, adwaita-qt4, adwaita-qt5, gnome-shell,
     gnupg2-smime, virtualbox-guest-additions, libXfont2, libblockdev-loop,
     jasper-libs, ghc-asn1-encoding, xorg-x11-server-utils, libssh2,
     syslinux, libmbim, open-vm-tools-desktop, libacl, ostree-libs,
     libpskc, libxcrypt, gnupg2, libXcursor, gcc-gdb-plugin, libomp,
     libverto, glibmm24, gnome-logs, rpm, openrdate, iptstate, bridge-
     utils, nspr, NetworkManager-ssh, radvd, cracklib, procps-ng, realmd,
     ghc-data-default-instances-dlist, avahi, plymouth-core-libs, ncurses,
     ghc-socks, openvpn, libdnf, python3-libs, graphite2, gts, ghc-
     cryptonite, simple-scan, passwdqc-lib, libvirt-daemon-driver-
     interface, libreport-plugin-kerneloops, perl-Variable-Magic,
     libwbclient, gvfs-client, libpmemobj, glusterfs-cli, xorg-x11-drv-
     nouveau, gnome-keyring, gmp, ipset-libs, bluez-obexd, pulseaudio-libs-
     glib2, sssd-krb5-common, zlib, libvirt-daemon-driver-storage-core,
     lua-socket, libpeas, netpbm, lxpolkit, pam_krb5, plymouth-graphics-
     libs, grub2-tools-efi, nm-connection-editor, libselinux, rdist,
     mozjs38, cdparanoia-libs, python3-pyparted, gnome-menus, glusterfs-
     client-xlators, python2-lxml, libassuan, python3-gpg, libxml2,
     libgepub, expat, cups-filters, iw, clutter-gtk, libzapojit, clutter,
     alsa-plugins-pulseaudio, iscsi-initiator-utils-iscsiuio, zenity,
     libblockdev-utils, rhythmbox, chkconfig, cyrus-sasl-gssapi, bluez-
     cups, mpage, glusterfs-fuse, libargon2, ibus-libpinyin, libgnome-
     keyring, userspace-rcu, mousetweaks, make, hostname, perl-Unicode-
     UTF8, iscsi-initiator-utils, coreutils, bind-utils, libsecret,
     libnice, dosfstools, librados2, source-highlight, gvfs, dbus-x11, pam,
     python2-gpg, ghc-streaming-commons, ghc-data-default-instances-old-
     locale, usbredir, python2-cffi, NetworkManager-bluetooth, nano,
     glusterfs-api, pinentry, yelp-libs, ghc-hxt-charproperties, ghc-xml,
     fuse, perl-Net-SSLeay, libsysfs, perl-Filter, librepo, xorg-x11-drv-
     vesa, crda, audit, apr-util, pcre-cpp, libieee1284, file-roller-
     nautilus, cups-libs, nautilus-extensions, webkit2gtk3, NetworkManager-
     adsl, ghc-uuid-types, ipcalc, abrt-dbus, gnome-desktop3, ghc-parsec,
     infinipath-psm, gdk-pixbuf2-modules, binutils, libsepol, totem-pl-
     parser, SDL, qemu-common, autogen-libopts, libattr, gsm, libuv,
     libtevent, nss-pem, libvirt-daemon-driver-storage-logical,
     python2-kerberos, less, isomd5sum, neon, rest, libvpx, openssh, opus,
     tcl, rpm-build-libs, LibRaw, ghc-base-compat, libsamplerate, ghc-
     blaze-html, libdmx, pcre-utf32, libglvnd, NetworkManager-vpnc-gnome,
     gnome-documents-libs, geocode-glib, corosynclib, totem-nautilus,
     pcre2, pakchois, libreport-plugin-reportuploader, libpcap, exempi,
     ghc-x509-store, libxkbcommon-x11, perl-version, qemu-block-iscsi, zfs-
     fuse, tigervnc-server-minimal, python3, gavl, libtdb, libusbmuxd,
     perl-Unicode-Normalize, sssd-nfs-idmap, libXdmcp, ghc-blaze-markup,
     libudisks2, ipset, clutter-gst3, libimobiledevice, lzop, perl-Socket,
     libvirt-daemon-driver-secret, NetworkManager-wwan, elfutils-libelf,
     libdrm, genisoimage, ghc-foundation, tmux, polkit-pkla-compat,
     libvisual, python3-libreport, unique, cups, jbig2dec-libs, python2,
     libmtp, cyrus-sasl-lib, gpm-libs, iproute, qt5-qtbase, keybinder3,
     ntfs-3g, ghc-hxt, libbytesize, xmlrpc-c, fuse-libs, python3-gobject-
     base, perl-TermReadKey, xdg-desktop-portal, gnome-settings-daemon,
     dnsmasq, geoclue2-libs, cogl, rygel, xorg-x11-xauth, libXfixes,
     libvirt-glib, libglvnd-glx, libxcb, SDL2, gtkspell3, xorg-x11-server-
     Xwayland, gjs, libcue, libcdio, libXrender, json-glib, telepathy-
     logger, ghc-cereal, libX11-xcb, libfontenc, qt5-qtbase-gui, libicu,
     libgsf, rsync, GConf2, sssd-common, grilo-plugins, ghc-byteable,
     NetworkManager-openconnect, libgtop2, glibc, ghc-network, btrfs-progs,
     krb5-pkinit, shadow-utils, snappy, perl-IO, lua-libs, libcgroup,
     gnome-photos, libssh, ghc-temporary, wvdial, grub2-tools-extra,
     libXaw, libXau, gvnc, fipscheck, authselect-libs, netcf-libs, mactel-
     boot, bc, libgdata, ghc-bytestring, xorg-x11-drv-evdev, sni-qt, gtk-
     vnc2, python3-brlapi, pulseaudio-module-x11, dmidecode, mesa-libglapi,
     usbmuxd, libpeas-gtk, libXinerama, libao, cups-filters-libs, wget,
     glx-utils, polkit-libs, gnome-autoar, libteam, python3-libcomps, gvfs-
     gphoto2, syslinux-extlinux, openssl, boost-regex, zip, PackageKit,
     libquadmath, perl-MIME-Base64, spice-gtk3, libreport-web, nautilus,
     numad, acl, libexif, ghc-tagsoup, libbabeltrace, spice-vdagent,
     xorg-x11-drv-wacom-serial-support, xorg-x11-drv-fbdev, libgusb, glib2,
     libqb, libnfsidmap, ghc-connection, libavc1394, libvirt-daemon-driver-
     storage-mpath, lldpad, ghc-time, shared-mime-info, libphodav, qemu-
     system-x86-core, sushi, libtiff, ImageMagick-libs, libev, libstdc++,
     libtool-ltdl, libmnl, ppp, libgee, sg3_utils-libs, mozjs52, libmng,
     libnotify, libcryptui, nfs-utils, readline, libXxf86vm, httpd-tools,
     pcre, mesa-libEGL, openssl-pkcs11, libchamplain-gtk, ghc-blaze-
     builder, clang-libs, ima-evm-utils, tcp_wrappers-libs, httpd, sane-
     backends, ghc-SHA, gstreamer1-plugins-base, ghc-network-uri, speech-
     dispatcher, libblkid, volume_key-libs, ctags, libvirt-libs, tcpdump,
     python2-gobject-base, ghc-transformers-compat, perl-Digest-MD5,
     pciutils-libs, libxklavier, ghc-attoparsec, traceroute, PackageKit-
     gtk3-module, libiptcdata, libmpc, ghc-pandoc-types, libXi,
     libblockdev-crypto, file-roller, openjpeg2, libshout, flac-libs,
     taglib, libXt, libXv, udisks2, eog, libXext, rp-pppoe, libtheora,
     mcpp, ModemManager-glib, libnfnetlink, dracut, ostree, ghc-time-
     locale-compat, libiec61883, mtr, glib2-devel, device-mapper-event-
     libs, libblockdev-part, libvirt-daemon-driver-storage-rbd, libreport-
     plugin-ureport, initscripts, libcanberra-gtk2, libcanberra-gtk3,
     device-mapper-event, hunspell, flex, libsemanage, libreport-plugin-
     bugzilla, marisa, ghc-primitive, libsigsegv, ghc-scientific, libpsm2,
     libndp, mtdev, links, libcomps, ghc-texmath, brltty, libmspack,
     systemd-udev, ibus, usbutils, qt-x11, jwhois, at, ghc-stm,
     libsss_sudo, libXvMC, curl, plymouth, jsoncpp, cheese-libs, abrt-
     addon-kerneloops, libthai, bzip2, ghc-data-default, cmake,
     libblockdev-fs, ghc-doctemplates, libdmapsharing, libfdt, libXmu,
     libnma, gettext, libmodulemd, fakeroot, capstone, soxr, nss-softokn-
     freebl, fipscheck-lib, open-vm-tools, evolution-ews, espeak,
     libzhuyin, openal-soft, librbd1, libvirt-gobject, time,
     python2-pycurl, python3-smartcols, libutempter, device-mapper-libs,
     xorg-x11-xinit, cpp, libogg, libmetalink, pyliblzma, libffi, gnome-
     online-miners, lmdb-libs, libcacard, slang, libsane-hpaio, abrt-tui,
     pulseaudio-utils, gvfs-afp, yelp, python3-kerberos, nss, diffutils,
     xorg-x11-drv-intel, e2fsprogs, libcdio-paranoia, chrony, abrt-addon-
     xorg, grub2-tools-minimal, abrt-java-connector, ibus-qt, libdhash,
     cryptsetup, libXpm, speex, libksba, gnome-keyring-pam, sssd-proxy,
     mpfr), /usr/lib/.build-id/d2(authselect, cups-libs, ImageMagick-libs,
     graphviz, perl-interpreter, gstreamer1, rpm-plugin-selinux, grilo-
     plugins, systemd-pam, frei0r-plugins, python2-libs, iptables, open-vm-
     tools, libgphoto2, mesa-dri-drivers, rygel, gegl03, util-linux, rp-
     pppoe, qt, evolution, evolution-data-server, virtualbox-guest-
     additions, dbus, NetworkManager-pptp-gnome, cpp), /usr/lib/.build-
     id/be(iptables, evolution, libgphoto2, colord, elfutils-libs,
     ModemManager, libmediaart, gstreamer1-plugins-bad-free, clang-libs,
     wpa_supplicant, sane-backends-drivers-scanners, e2fsprogs, ibus,
     gnome-shell, frei0r-plugins, gnupg, xorg-x11-drv-ati, traceroute,
     graphviz, glibc, jimtcl), /usr/lib/.build-id/c1(httpd, gcc, libomp,
     PackageKit, ModemManager, glibc, xorg-x11-drv-libinput, pulseaudio,
     cups-filters, shadow-utils, gstreamer1-plugins-base, glusterfs,
     gegl03, frei0r-plugins, pciutils, gnome-online-accounts, bind-libs-
     lite, grub2-tools)
     https://bugzilla.redhat.com/show_bug.cgi?id=1542507
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[!]: Package is not known to require an ExcludeArch tag.
     PMDK is x86_64-only for now.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pmdk-
     convert-debuginfo , pmdk-convert-debugsource
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: pmdk-convert-1.5-1.fc28.x86_64.rpm
          pmdk-convert-debuginfo-1.5-1.fc28.x86_64.rpm
          pmdk-convert-debugsource-1.5-1.fc28.x86_64.rpm
          pmdk-convert-1.5-1.fc28.src.rpm
pmdk-convert.x86_64: W: spelling-error %description -l en_US libpmemobj -> memorabilia
pmdk-convert.src: W: spelling-error %description -l en_US libpmemobj -> memorabilia
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

False positives.


Rpmlint (debuginfo)
-------------------
Checking: pmdk-convert-debuginfo-1.5-1.fc28.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
pmdk-convert.x86_64: W: spelling-error %description -l en_US libpmemobj -> memorabilia
pmdk-convert.x86_64: W: invalid-url URL: https://github.com/pmem/pmdk-convert <urlopen error [Errno -2] Name or service not known>
pmdk-convert-debuginfo.x86_64: W: invalid-url URL: https://github.com/pmem/pmdk-convert <urlopen error [Errno -2] Name or service not known>
pmdk-convert-debugsource.x86_64: W: invalid-url URL: https://github.com/pmem/pmdk-convert <urlopen error [Errno -2] Name or service not known>
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Spelling error is false positive. Invalid-url are bogus - rpmlint doesn't handle proxy settings correctly.


Requires
--------
pmdk-convert (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libpmem-convert.so()(64bit)
    libpmem-convert.so(LIBPMEM_1.0)(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

pmdk-convert-debuginfo (rpmlib, GLIBC filtered):

pmdk-convert-debugsource (rpmlib, GLIBC filtered):



Provides
--------
pmdk-convert:
    libpmem-convert.so()(64bit)
    libpmem-convert.so(LIBPMEM_1.0)(64bit)
    pmdk-convert
    pmdk-convert(x86-64)

pmdk-convert-debuginfo:
    debuginfo(build-id)
    pmdk-convert-debuginfo
    pmdk-convert-debuginfo(x86-64)

pmdk-convert-debugsource:
    pmdk-convert-debugsource
    pmdk-convert-debugsource(x86-64)



Unversioned so-files
--------------------
pmdk-convert: /usr/lib64/pmdk-convert/libpmem-convert.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v1.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v2.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v3.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v4.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v5.so

Source checksums
----------------
https://github.com/pmem/pmdk/archive/1.1.tar.gz#/nvml-1.1.tar.gz :
  CHECKSUM(SHA256) this package     : 2d51a356bf0bd61b0259844894223305d5d825af68d51a07aa1d2bc926b65c43
  CHECKSUM(SHA256) upstream package : 2d51a356bf0bd61b0259844894223305d5d825af68d51a07aa1d2bc926b65c43
https://github.com/pmem/pmdk/archive/1.2.3.tar.gz#/nvml-1.2.3.tar.gz :
  CHECKSUM(SHA256) this package     : 7a2c03661a122079906f700d053f9260f9814d18d49218c1b5a8332b17023fc7
  CHECKSUM(SHA256) upstream package : 7a2c03661a122079906f700d053f9260f9814d18d49218c1b5a8332b17023fc7
https://github.com/pmem/pmdk-convert/archive/1.5.tar.gz#/pmdk-convert-1.5.tar.gz :
  CHECKSUM(SHA256) this package     : 6d4fdb1679f174b673927d9d3bae879c6b572f691c28e5181f42268313e2c3d3
  CHECKSUM(SHA256) upstream package : 6d4fdb1679f174b673927d9d3bae879c6b572f691c28e5181f42268313e2c3d3
https://github.com/pmem/pmdk/archive/1.0.tar.gz#/nvml-1.0.tar.gz :
  CHECKSUM(SHA256) this package     : e9c9ed72168047f65fae72808933bfeafd965ed3237ab3fbfb199c362bf5b773
  CHECKSUM(SHA256) upstream package : e9c9ed72168047f65fae72808933bfeafd965ed3237ab3fbfb199c362bf5b773
https://github.com/pmem/pmdk/archive/1.5.tar.gz#/nvml-1.5.tar.gz :
  CHECKSUM(SHA256) this package     : 6b069d7207febeb62440e89245e8b18fcdf40b6170d2ec2ef33c252ed16db2d4
  CHECKSUM(SHA256) upstream package : 6b069d7207febeb62440e89245e8b18fcdf40b6170d2ec2ef33c252ed16db2d4
https://github.com/pmem/pmdk/archive/1.3.1.tar.gz#/nvml-1.3.1.tar.gz :
  CHECKSUM(SHA256) this package     : 0e2a3edbd72e56074c07455f20db4dd981c915c46932efa7902e2d4cbff072c9
  CHECKSUM(SHA256) upstream package : 0e2a3edbd72e56074c07455f20db4dd981c915c46932efa7902e2d4cbff072c9
https://github.com/pmem/pmdk/archive/1.4.2.tar.gz#/nvml-1.4.2.tar.gz :
  CHECKSUM(SHA256) this package     : df7e658e75d28cd80f6d2ff7b9fc9ae2885d52f8923fdbacecfd46215115fb4c
  CHECKSUM(SHA256) upstream package : df7e658e75d28cd80f6d2ff7b9fc9ae2885d52f8923fdbacecfd46215115fb4c


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --rpm-spec -n pmdk-convert-1.5-1.fc28.src.rpm
Buildroot used: fedora-28-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 3 Dan Williams 2018-11-27 06:37:15 UTC
So the header file warnings are a false positive they'll trigger on any debugsource package.

The only concern I have is why are the following:

pmdk-convert: /usr/lib64/pmdk-convert/libpmem-convert.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v1.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v2.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v3.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v4.so
pmdk-convert: /usr/lib64/pmdk-convert/pmemobj_convert_v5.so

...globally installed libraries? It seems they are just potentially dynamic objects for the pmdk-convert utility, but do they have any usage for any other application. If they are just private why not build them into the binary? If they are public and intended to be consumed by other applications then they should be versioned and moved to their own pmdk-convert-libs sub-pacakge.

Comment 4 Marcin Ślusarz 2018-11-27 18:07:54 UTC
Thanks Dan.

Those so files are in pmdk-convert subdirectory, so they should not be visible to other applications. As I understand it, this is common practice for private application plugins.

And those libraries are plugins - they are loaded dynamically and each of the versioned so's export 2 symbols with the same name, so they can't be easily linked together into pmdk-convert binary.

Comment 5 Marcin Ślusarz 2018-11-27 18:09:38 UTC
Oh, I just realized this is explained in Filesystem Hierarchy Standard - http://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s06.html

Comment 6 Dan Williams 2018-11-27 19:14:47 UTC
(In reply to Marcin Ślusarz from comment #5)
> Oh, I just realized this is explained in Filesystem Hierarchy Standard -
> http://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s06.html

Ah, ok thanks for that. Then this looks ok to me.

Comment 7 Gwyn Ciesla 2018-12-14 16:19:15 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/pmdk-convert


Note You need to log in before you can comment on or make changes to this bug.