Bug 1648558 - openbabel: Remove (sub)packages from Fedora 30+: python2-openbabel
Summary: openbabel: Remove (sub)packages from Fedora 30+: python2-openbabel
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: openbabel
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PY2REMOVAL
TreeView+ depends on / blocked
 
Reported: 2018-11-10 15:20 UTC by Miro Hrončok
Modified: 2019-03-04 14:37 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-04 14:37:08 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2018-11-10 15:20:13 UTC
In line with the Mass Python 2 Package Removal [0], the following (sub)packages of openbabel were marked for removal:

 * python2-openbabel

According to our query, those (sub)packages only provide a Python 2 importable module. If this is not true, please tell us why, so we can fix our query.

Please remove them from your package.

As said in the change document, if there is no objection in a week, we will remove the package(s) as soon as we get to it. This change might not match your packaging style, so we'd prefer if you did the change. If you need more time, please let us know here.

If you do the change yourself, it would help us a lot by reducing the amount of packages we need to mass change.

We hope this doesn't come to you as a surprise. If you want to know our motivation for this, please read the change document [0].

[0] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal

Comment 1 Miro Hrončok 2019-01-15 19:30:59 UTC
https://koji.fedoraproject.org/koji/taskinfo?taskID=32048865 test failures:

157/160 Test #157: pytest_pdbformat .................***Failed    0.04 sec
/builddir/build/BUILD/openbabel-openbabel-2-4-1/scripts/python:/builddir/build/BUILD/openbabel-openbabel-2-4-1/lib64
  File "/builddir/build/BUILD/openbabel-openbabel-2-4-1/test/testpdbformat.py", line 32
    self.entryPDBwithInsertioncodes="""ATOM    406  N   VAL L  29      58.041  17.797  48.254  1.00  0.00           N  
                                                                                                                      ^
TabError: inconsistent use of tabs and spaces in indentation
CMake Error at pytest_pdbformat.cmake:20 (MESSAGE):
  1
        Start 158: pybindtest_bindings
158/160 Test #158: pybindtest_bindings ..............***Failed  Error regular expression found in output. Regex=[FAIL]  0.18 sec
/builddir/build/BUILD/openbabel-openbabel-2-4-1/scripts/python:/builddir/build/BUILD/openbabel-openbabel-2-4-1/lib64
FF
======================================================================
FAIL: testDummy (__main__.PybelWrapper)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/openbabel-openbabel-2-4-1/test/testbindings.py", line 41, in setUp
    self.assertTrue(ob is not None, "Failed to import the openbabel module")
AssertionError: False is not true : Failed to import the openbabel module
======================================================================
FAIL: testSimple (__main__.TestPythonBindings)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/openbabel-openbabel-2-4-1/test/testbindings.py", line 41, in setUp
    self.assertTrue(ob is not None, "Failed to import the openbabel module")
AssertionError: False is not true : Failed to import the openbabel module
----------------------------------------------------------------------
Ran 2 tests in 0.001s
FAILED (failures=2)
CMake Error at pybindtest_bindings.cmake:20 (MESSAGE):
  1
        Start 159: pybindtest__pybel
159/160 Test #159: pybindtest__pybel ................***Failed    0.10 sec
/builddir/build/BUILD/openbabel-openbabel-2-4-1/scripts/python:/builddir/build/BUILD/openbabel-openbabel-2-4-1/lib64
Traceback (most recent call last):
  File "/builddir/build/BUILD/openbabel-openbabel-2-4-1/test/test_pybel.py", line 22, in <module>
    import testpybel
  File "/builddir/build/BUILD/openbabel-openbabel-2-4-1/test/../scripts/python/examples/testpybel.py", line 419, in <module>
    class TestRDKit(TestToolkit):
  File "/builddir/build/BUILD/openbabel-openbabel-2-4-1/test/../scripts/python/examples/testpybel.py", line 420, in TestRDKit
    toolkit = rdkit
NameError: name 'rdkit' is not defined
CMake Error at pybindtest__pybel.cmake:20 (MESSAGE):
  1
        Start 160: pybindtest_example
160/160 Test #160: pybindtest_example ...............***Failed  Error regular expression found in output. Regex=[FAIL]  0.09 sec
/builddir/build/BUILD/openbabel-openbabel-2-4-1/scripts/python:/builddir/build/BUILD/openbabel-openbabel-2-4-1/lib64
FF
======================================================================
FAIL: testDummy (__main__.ExamplePybelTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/openbabel-openbabel-2-4-1/test/testbindings.py", line 41, in setUp
    self.assertTrue(ob is not None, "Failed to import the openbabel module")
AssertionError: False is not true : Failed to import the openbabel module
======================================================================
FAIL: testNumberOfAtoms (__main__.ExamplePybelTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/openbabel-openbabel-2-4-1/test/testbindings.py", line 41, in setUp
    self.assertTrue(ob is not None, "Failed to import the openbabel module")
AssertionError: False is not true : Failed to import the openbabel module
----------------------------------------------------------------------
Ran 2 tests in 0.001s
FAILED (failures=2)
98% tests passed, 4 tests failed out of 160

Comment 2 Miro Hrončok 2019-02-26 12:32:59 UTC
Dominik, would you be able to help with this before the beta freeze (2019-03-05)?

Comment 3 Dominik 'Rathann' Mierzejewski 2019-02-28 13:53:14 UTC
I'll try, but no promises.

Comment 5 Miro Hrončok 2019-03-04 14:19:03 UTC
Thanks.

Comment 6 Miro Hrončok 2019-03-04 14:20:07 UTC
The builds are cancelled.

Comment 7 Dominik 'Rathann' Mierzejewski 2019-03-04 14:37:08 UTC
Yes, I forgot to add Obsoletes. New builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=33156130 (f30)
https://koji.fedoraproject.org/koji/taskinfo?taskID=33156157 (rawhide)


Note You need to log in before you can comment on or make changes to this bug.