Bug 1649928 - Some field name on virt-who config overview page are prefixed with "Satellite Virt Who Configure/Config"
Summary: Some field name on virt-who config overview page are prefixed with "Satellite...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Virt-who Configure Plugin
Version: 6.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 6.6.0
Assignee: Marek Hulan
QA Contact: Perry Gagne
satellite-doc-list
URL:
Whiteboard:
: 1708160 (view as bug list)
Depends On:
Blocks: 1122832
TreeView+ depends on / blocked
 
Reported: 2018-11-14 19:39 UTC by Perry Gagne
Modified: 2019-11-18 18:59 UTC (History)
6 users (show)

Fixed In Version: tfm-rubygem-foreman_virt_who_configure-0.4.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-22 19:47:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screen shot of virt-who config overview (203.57 KB, image/png)
2018-11-14 19:39 UTC, Perry Gagne
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 25776 0 Normal Closed Some field name on virt-who config overview page are prefixed with "Satellite Virt Who Configure/Config" 2020-07-15 18:07:17 UTC

Description Perry Gagne 2018-11-14 19:39:44 UTC
Created attachment 1505784 [details]
screen shot of virt-who config overview

Description of problem: 
The following fields in the overview tab for a virt-who config should have the prefix removed:

Satellite Virt Who Configure/Config|Hypervisor Type
Satellite Virt Who Configure/Config|Hypervisor Server
Satellite Virt Who Configure/Config|Hypervisor Username
Satellite Virt Who Configure/Config|Interval

Version-Release number of selected component (if applicable): 6.5 snap 3


How reproducible: always


Steps to Reproduce:
1. Infrastructure -> Virt Who configurations -> Create config
2. After creating the config, see its overview.

Actual results:
Some fields in the overview are prefixed with "Satellite Virt Who Configure/Config" for example "Satellite Virt Who Configure/Config|Hypervisor Type" 

Expected results: Fields shouldn't have this prefix (ie "Hypervisor Type"). 


Additional info:
See attached screenshot of overview tab

Comment 2 Marek Hulan 2018-11-15 09:42:46 UTC
Seems like an issue with translations, bk you worked on extracting strings some time ago which seemed to fail because it pull also Katello strings, does it ring any bell? I don't see this in upstream.

Comment 3 Bryan Kearney 2019-01-03 19:36:36 UTC
@Marek look at this line from 

app/helpers/foreman_virt_who_configure/configs_helper.rb

    def config_attribute_default_label(attr)
      s_(ForemanVirtWhoConfigure::Config.gettext_translation_for_attribute_name(attr).titleize)
    end

I believe the titleize should be on the outside, since the s_ seems to do the lookup and then split on the "|" character.

Comment 4 Marek Hulan 2019-01-04 09:53:17 UTC
You're correct indeed, I'm confused why/how this worked before. Anyway, I'll send a fix. Thanks!

Comment 5 Marek Hulan 2019-01-04 09:54:57 UTC
Created redmine issue https://projects.theforeman.org/issues/25776 from this bug

Comment 6 Bryan Kearney 2019-01-07 21:11:35 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/25776 has been resolved.

Comment 10 Marek Hulan 2019-05-09 09:35:36 UTC
*** Bug 1708160 has been marked as a duplicate of this bug. ***

Comment 12 Perry Gagne 2019-05-14 15:00:33 UTC
Verified fix in Sat 6.6 snap 2. 

Prefix has been removed from field names, see attachment 1568499 [details] for example

Comment 13 Bryan Kearney 2019-10-22 19:47:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3172


Note You need to log in before you can comment on or make changes to this bug.