Bug 1650340 - [v2v][osp] Migration stalls if Key Pair is not added to OSP provider, and no warning/error given
Summary: [v2v][osp] Migration stalls if Key Pair is not added to OSP provider, and no ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.10.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: GA
: 5.10.0
Assignee: Brett Thurber
QA Contact: Kedar Kulkarni
Red Hat CloudForms Documentation
URL:
Whiteboard: v2v
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-15 22:05 UTC by Kedar Kulkarni
Modified: 2019-02-12 16:50 UTC (History)
7 users (show)

Fixed In Version: 5.10.0.30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-12 16:50:49 UTC
Category: ---
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
fixed_proof.png (51.95 KB, image/png)
2018-12-20 15:30 UTC, Yadnyawalk Tale
no flags Details

Description Kedar Kulkarni 2018-11-15 22:05:00 UTC
Description of problem:
There are two things in here:
1)In the infra mapping wizard on the cluster mapping page there is no warning if OpenStack do not have a Conversion host configured. We should add that, similar to what we do for RHV
2)Migration gets stuck in "Acquiring conversion Host" phase if RSA Key pair is not added to the OpenStack provider

Version-Release number of selected component (if applicable):
5.10.0.24

How reproducible:
100%

Steps to Reproduce:
1.Add VMware and OpenStack provider(do not add RSA Key Pair in OpenStack Provider)
2.Create Infra Mapping(On cluster page observe there is no warning about conversion host being absent)
3.Create migration plan and execute

Actual results:
Migration gets stalled in the   "Acquiring conversion Host" phase

Expected results:
1)We should add Warning on Cluster Mapping page if conversion host or RSA Key Pair not present in OpenStack, similar to what we do for RHV
2)Migration should fail in case Conversion host or RSA keypair is not added/configured.

Additional info:

Comment 2 Kedar Kulkarni 2018-11-16 02:04:48 UTC
https://github.com/ManageIQ/manageiq-v2v/issues/794

Comment 5 CFME Bot 2018-12-11 22:32:57 UTC
New commit detected on ManageIQ/manageiq-v2v/master:

https://github.com/ManageIQ/manageiq-v2v/commit/d6adf67d24ae9ef511cf9eecba543b6e1c3d067d
commit d6adf67d24ae9ef511cf9eecba543b6e1c3d067d
Author:     Mike Ro <mikerodev>
AuthorDate: Tue Dec 11 10:10:35 2018 -0500
Commit:     Mike Ro <mikerodev>
CommitDate: Tue Dec 11 10:10:35 2018 -0500

    Show a warning if OSP provider lacks RSA key

    * For all available target cloud tenants, query their OSP provider along
      with their authentications
    * If any tenant's associated provider lacks an authentication with
      authtype ssh_keypair, render the warning icon

    https://bugzilla.redhat.com/show_bug.cgi?id=1650340

 app/javascript/react/screens/App/Mappings/screens/MappingWizard/MappingWizardConstants.js | 7 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStep.js | 40 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStepActions.js | 22 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStepConstants.js | 10 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStepReducer.js | 22 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/MappingWizardClusterStepActions.test.js | 30 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/MappingWizardClustersStep.test.js | 69 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/MappingWizardClustersStepReducers.test.js | 85 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/__snapshots__/MappingWizardClusterStepActions.test.js.snap | 29 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/__snapshots__/MappingWizardClustersStepReducers.test.js.snap | 68 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/__snapshots__/helpers.test.js.snap | 8 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/__snapshots__/index.test.js.snap | 1 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/helpers.test.js | 19 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/components/ClustersStepForm/ClustersStepForm.js | 34 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/components/ClustersStepForm/__tests__/ClustersStepForm.test.js | 35 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/components/ClustersStepForm/helpers.js | 9 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/helpers.js | 6 +
 17 files changed, 405 insertions(+), 89 deletions(-)

Comment 7 CFME Bot 2018-12-13 21:39:35 UTC
New commit detected on ManageIQ/manageiq-v2v/master:

https://github.com/ManageIQ/manageiq-v2v/commit/a4c33cb407e562f065a9a1e70066303ae28af9cf
commit a4c33cb407e562f065a9a1e70066303ae28af9cf
Author:     Mike Ro <mikerodev>
AuthorDate: Thu Dec 13 14:42:04 2018 -0500
Commit:     Mike Ro <mikerodev>
CommitDate: Thu Dec 13 14:42:04 2018 -0500

    Cancel OSP plans started without RSA key

    * Use the target cloud tenant's ems_id attribute to link a plan to the
      target provider.
    * We determine that an OSP target provider does not have a RSA key pair
      by inspecting its authentications

    https://bugzilla.redhat.com/show_bug.cgi?id=1650340

 app/javascript/data/models/provider.js | 3 +-
 app/javascript/react/screens/App/Mappings/Mappings.js | 9 +-
 app/javascript/react/screens/App/Mappings/MappingsActions.js | 5 +-
 app/javascript/react/screens/App/Mappings/MappingsConstants.js | 2 +
 app/javascript/react/screens/App/Mappings/__test__/MappingsActions.test.js | 44 +
 app/javascript/react/screens/App/Mappings/__test__/__snapshots__/MappingsActions.test.js.snap | 28 +
 app/javascript/react/screens/App/Overview/Overview.js | 12 +-
 app/javascript/react/screens/App/Overview/OverviewActions.js | 5 +-
 app/javascript/react/screens/App/Overview/OverviewConstants.js | 9 +-
 app/javascript/react/screens/App/Overview/OverviewReducer.js | 33 +-
 app/javascript/react/screens/App/Overview/OverviewSelectors.js | 16 +
 app/javascript/react/screens/App/Overview/__test__/Overview.test.js | 78 +-
 app/javascript/react/screens/App/Overview/__test__/OverviewSelectors.test.js | 49 +-
 app/javascript/react/screens/App/Overview/__test__/__snapshots__/Overview.test.js.snap | 14 +
 app/javascript/react/screens/App/Overview/__test__/__snapshots__/index.test.js.snap | 4 +
 app/javascript/react/screens/App/Overview/__test__/helpers.test.js | 47 +
 app/javascript/react/screens/App/Overview/components/Migrations/MigrationsInProgressCard.js | 13 +-
 app/javascript/react/screens/App/Overview/components/Migrations/__test__/MigrationsInProgressCard.test.js | 4 +-
 app/javascript/react/screens/App/Overview/helpers.js | 28 +
 app/javascript/react/screens/App/Overview/index.js | 14 +-
 20 files changed, 336 insertions(+), 81 deletions(-)

Comment 8 CFME Bot 2018-12-14 18:54:17 UTC
New commits detected on ManageIQ/manageiq-v2v/hammer:

https://github.com/ManageIQ/manageiq-v2v/commit/87d120afcf206b27a5b4f12aecd42c61013e07ae
commit 87d120afcf206b27a5b4f12aecd42c61013e07ae
Author:     Mike Turley <mike.turley.umass.edu>
AuthorDate: Tue Dec 11 17:29:25 2018 -0500
Commit:     Mike Turley <mike.turley.umass.edu>
CommitDate: Tue Dec 11 17:29:25 2018 -0500

    Merge pull request #833 from michaelkro/794-rsa-key-pair-warning

    [#794] Show a warning if OSP provider lacks RSA key

    (cherry picked from commit c0c301d3c943aad65c6c9c5e6c8e8b864a8af76d)

    https://bugzilla.redhat.com/show_bug.cgi?id=1650340

 app/javascript/react/screens/App/Mappings/screens/MappingWizard/MappingWizardConstants.js | 7 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStep.js | 40 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStepActions.js | 22 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStepConstants.js | 10 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStepReducer.js | 22 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/MappingWizardClusterStepActions.test.js | 30 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/MappingWizardClustersStep.test.js | 69 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/MappingWizardClustersStepReducers.test.js | 85 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/__snapshots__/MappingWizardClusterStepActions.test.js.snap | 29 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/__snapshots__/MappingWizardClustersStepReducers.test.js.snap | 68 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/__snapshots__/helpers.test.js.snap | 8 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/__snapshots__/index.test.js.snap | 1 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/__tests__/helpers.test.js | 19 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/components/ClustersStepForm/ClustersStepForm.js | 34 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/components/ClustersStepForm/__tests__/ClustersStepForm.test.js | 35 +-
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/components/ClustersStepForm/helpers.js | 9 +
 app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/helpers.js | 6 +
 17 files changed, 405 insertions(+), 89 deletions(-)


https://github.com/ManageIQ/manageiq-v2v/commit/63dded0a435ace650e963be74dc8bfc23ff95f14
commit 63dded0a435ace650e963be74dc8bfc23ff95f14
Author:     Mike Turley <mike.turley.umass.edu>
AuthorDate: Thu Dec 13 16:38:41 2018 -0500
Commit:     Mike Turley <mike.turley.umass.edu>
CommitDate: Thu Dec 13 16:38:41 2018 -0500

    Merge pull request #836 from michaelkro/794-cancel-no-rsa

    [#794] Cancel OSP plans started without RSA key

    (cherry picked from commit 1b6035cea1830d1fdcc84bac4e5e67fac559bc25)

    https://bugzilla.redhat.com/show_bug.cgi?id=1650340

 app/javascript/data/models/provider.js | 3 +-
 app/javascript/react/screens/App/Mappings/Mappings.js | 9 +-
 app/javascript/react/screens/App/Mappings/MappingsActions.js | 5 +-
 app/javascript/react/screens/App/Mappings/MappingsConstants.js | 2 +
 app/javascript/react/screens/App/Mappings/__test__/MappingsActions.test.js | 44 +
 app/javascript/react/screens/App/Mappings/__test__/__snapshots__/MappingsActions.test.js.snap | 28 +
 app/javascript/react/screens/App/Overview/Overview.js | 12 +-
 app/javascript/react/screens/App/Overview/OverviewActions.js | 5 +-
 app/javascript/react/screens/App/Overview/OverviewConstants.js | 9 +-
 app/javascript/react/screens/App/Overview/OverviewReducer.js | 33 +-
 app/javascript/react/screens/App/Overview/OverviewSelectors.js | 16 +
 app/javascript/react/screens/App/Overview/__test__/Overview.test.js | 78 +-
 app/javascript/react/screens/App/Overview/__test__/OverviewSelectors.test.js | 49 +-
 app/javascript/react/screens/App/Overview/__test__/__snapshots__/Overview.test.js.snap | 14 +
 app/javascript/react/screens/App/Overview/__test__/__snapshots__/index.test.js.snap | 4 +
 app/javascript/react/screens/App/Overview/__test__/helpers.test.js | 47 +
 app/javascript/react/screens/App/Overview/components/Migrations/MigrationsInProgressCard.js | 13 +-
 app/javascript/react/screens/App/Overview/components/Migrations/__test__/MigrationsInProgressCard.test.js | 27 +-
 app/javascript/react/screens/App/Overview/components/Migrations/__test__/__snapshots__/MigrationsInProgressCard.test.js.snap | 2 +
 app/javascript/react/screens/App/Overview/helpers.js | 28 +
 app/javascript/react/screens/App/Overview/index.js | 14 +-
 21 files changed, 361 insertions(+), 81 deletions(-)

Comment 9 Yadnyawalk Tale 2018-12-20 15:30:56 UTC
Created attachment 1515909 [details]
fixed_proof.png

Fixed! Can see warning on in-progress card as well as on target project.
Verified on - 5.10.0.30.20181218191323_900a416


Note You need to log in before you can comment on or make changes to this bug.