+++ This bug was initially created as a clone of Bug #159363 +++ Description of problem: The utmp entries of gnome-terminals run under vnc don't get cleaned up if the vnc session is killed via 'vncserver -kill <display>'. This is because vncserver doesn't just kill the gnome-terminals as a user would, but rather kills all child processes, which includes gnome-pty-helper. gnome-pty-helper just dies, leaving the stale utmp/wtmp entries to potentially confuse subsequent users of '/bin/who -u', which isn't supposed to show entries for dead processes. Version-Release number of selected component (if applicable): vte-0.11.10-11 How reproducible: Always Steps to Reproduce: (This occurs naturally when a vncserver running gnome-terminals is killed using 'vncserver -kill <display number>' but the below process is much simpler) 1. start a gnome-terminal (note the tty) 2. kill both the gnome-terminal and gnome-pty-helper with SIGHUP 3. check 'who -u' output Actual results: The entry for the gnome-terminal is still there although the terminal is gone Expected results: No 'who -u' output for dead gnome-terminal Additional info: I've seen the gnome-terminal get SIGPIPE and as a result send SIGTERM to gnome-pty-helper and I've also seen gnome-pty-helper get SIGHUP from (I guess) vncserver. Patch from Dave Lehman <dlehman> at: https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=115067
Patch was committed to HEAD upstream.
The original patch was broken (ie. doing nasty things in the signal handler). This upstream patch (on top of the old one) should fix it: http://cvs.gnome.org/viewcvs/vte/gnome-pty-helper/gnome-pty-helper.c?r1=1.9&r2=1.10 Ray, let me know if you need the final patch backported.
Bastien, can you attach a final patch?
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
Created attachment 143990 [details] vte-0.11.11-pty-helper-utmp-update.patch Untested patch.
I also included the patch from: http://bugzilla.gnome.org/show_bug.cgi?id=387482 Patch compiles fine.
Built.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0219.html