Red Hat Bugzilla – Bug 165230
Review Request: Eclipse Graphical Editing Framework
Last modified: 2007-11-30 17:11:11 EST
Spec Name or Url: http://people.redhat.com/aluchko/rpms/rawhide/eclipse-gef.spec
SRPM Name or Url: http://people.redhat.com/aluchko/rpms/rawhide/eclipse-gef-3.1.0-1.src.rpm
Description: This package contains 3.1.0 of the Graphical Editing Framework which is required by a number of eclipse plugins.
Find attached a patch to the spec file that fixes small issues and other minor
The whole top arch defines seemed usless to me, but maybe I'm missing something.
Also, is this arch specific code or could the package be noarch? I don't know
much about java, but it seems that only xml and jar files are in this package,
so I was wondering.
Last, I've built the package successfully in a development x86_64 root, but I
don't have a real desktop system running development where I could test the install.
Created attachment 117904 [details]
Spec file patch
Thanks for the patch, I glanced over it and will try to have a better look at it
on Monday (I'm going to be away for a few days) but there seem to be some good
The reason we need the arch specific code is while it's all java and xml we use
gcj to compile the code to binary as well as bytecode though I'll need to have a
glance to make sure it is getting generated.
I'll try to respond sometime on Monday with an updated spec and the scripts I
used to build the tarball since the procedure is fairly non-trivial.
Documenting the way the tarball is generated in the spec file, or adding a
script that does it as a source to the package would be good indeed. As for the
binary code in the package, unless it's included in the .jar files, there
doesn't seem to be any.
Let me know once you have an updated package and I'll further review it.
Sorry for not getting back to you on Monday :)
I'm back at school so my time to work on it is fairly limited unfortunately, I
have a little more done at
but there's still a couple bugs in the build I need to work out and a couple
clean ups in the spec file (I combined your changes with the eclipse-changelog
I hope to be able to get back to this after exams in Christmas and finish it off.
Okay, it all builds (expect for a couple minor failures due to classes that are
missing from libgcj), has documentation, and passes all the gef junit tests.
When generating the debug info a bunch of messages pop up
extracting debug info from
extracting debug info from
cpio: eclipse-gef-3.1.1_fc/java/awt/BasicStroke.java: No such file or directory
cpio: eclipse-gef-3.1.1_fc/java/awt/geom/Area.java: No such file or directory
cpio: eclipse-gef-3.1.1_fc/java/awt/geom/GeneralPath.java: No such file or directory
Apparently this is due to an rpm bug that is fixed in 4.1.2 (fc4 is currently
4.1.1), Bug 161722
Here is the specfile and src.rpm
Wow, this ticket has been idle for seven months. Anything happening here?
(In reply to comment #8)
> Wow, this ticket has been idle for seven months. Anything happening here?
We can't build GEF until some of GNU Classpath head is backported to the libgcj
we have. This work has been done and is waiting on one more patch before we can
test it. When this finishes (before test2 I've been told), someone will re-submit.
I actually already submitted GEF and it was approved :) That was a new version
with a new way of building. Sorry to take this from you, Aaron, but I know
you're busy and not involved everyday with this like I am.
This bug should be closed.
Closing as WONTFIX then... better than staying idle anyway ;-)