Description of problem:
If BitBucket webhook is used to triggeer build and git-commit contains git tag, OpenShift master-api-service crashes and coredump is created.
Version-Release number of selected component (if applicable):
features: Basic-Auth GSSAPI Kerberos SPNEGO
Steps to Reproduce:
1. Create Bitbucket webhook to trigger a build using: Triggers: repo:push
2. Push some code to repository with tag to trigger the build
3. OpenShift master-api-service crashes
Openshift-master-api-service crashes and generates core-dump
Build starts normally
On line 159 the parser expects lastCommits to be present on the JSON-payload.
But when push is tagged with some git-tag parser fails to read the commit information.
Created attachment 1508809 [details]
Failing BitBucket webhook payload
Created attachment 1508810 [details]
Succesful BitBucket webhook payload
Created attachment 1508811 [details]
Seems to fixed on upstream 3.10: https://github.com/openshift/origin/blob/release-3.10/pkg/build/webhook/bitbucket/bitbucket.go
if len(event.Push.Changes) == 0 || len(event.Push.Changes.Commits) == 0
So should this be backported to 3.9?
if len(event.Push.Changes) == 0
And webhook payload includes changes but no commits (just tags).
We would only backport it if there is a specific customer request and that customer cannot reasonably upgrade to 3.10.
Closing as won't fix for now, pending that request/requirement.