Bug 1656392 - Review Request: perl-JSON-Color - Encode to colored JSON
Summary: Review Request: perl-JSON-Color - Encode to colored JSON
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1656335
TreeView+ depends on / blocked
 
Reported: 2018-12-05 12:16 UTC by Jitka Plesnikova
Modified: 2018-12-06 14:21 UTC (History)
2 users (show)

Fixed In Version: perl-JSON-Color-0.12-1.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-12-06 14:21:58 UTC
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2018-12-05 12:16:10 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-JSON-Color/perl-JSON-Color.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-JSON-Color/perl-JSON-Color-0.12-1.fc30.noarch.rpm

Description:
This module generates JSON, colorized with ANSI escape sequences.

Fedora Account System Username: jplesnik@redhat.com

Comment 1 Petr Pisar 2018-12-05 14:01:55 UTC
The SRPM URL points to a binary package. Please provide a source package.

Comment 3 Petr Pisar 2018-12-05 14:54:23 UTC
Url and Source0 addresses are Ok.
The Source0 archive (SHA-256 e2aa12287b072d11eb7bc048dacc0918be34ddc3ace654697f0b5479f33b52d4) is Ok.
Summary verified from lib/JSON/Color.pm. Ok.
Description verified from lib/JSON/Color.pm. Ok.
License verified from LICENSE and lib/JSON/Color.pm. Ok.
No XS code, noarch BuildArch is Ok.
Build dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-JSON-Color.spec ../SRPMS/perl-JSON-Color-0.12-1.fc30.src.rpm ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm
drwxr-xr-x    2 root    root                        0 Dec  5 15:42 /usr/share/doc/perl-JSON-Color
-rw-r--r--    1 root    root                     1440 Aug 23  2016 /usr/share/doc/perl-JSON-Color/Changes
-rw-r--r--    1 root    root                     1973 Aug 23  2016 /usr/share/doc/perl-JSON-Color/README
drwxr-xr-x    2 root    root                        0 Dec  5 15:42 /usr/share/licenses/perl-JSON-Color
-rw-r--r--    1 root    root                    18367 Aug 23  2016 /usr/share/licenses/perl-JSON-Color/LICENSE
-rw-r--r--    1 root    root                     2596 Dec  5 15:42 /usr/share/man/man3/JSON::Color.3pm.gz
drwxr-xr-x    2 root    root                        0 Dec  5 15:42 /usr/share/perl5/vendor_perl/JSON
-rw-r--r--    1 root    root                     8076 Aug 23  2016 /usr/share/perl5/vendor_perl/JSON/Color.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Exporter)
      1 perl(Scalar::Util::LooksLikeNumber)
      1 perl(strict)
      1 perl(Term::ANSIColor) >= 3.00
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: I think the `perl(Scalar::Util::LooksLikeNumber)' run-time dependency could be weaker, like Recommends.

$ rpm -q --provides -p ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm | sort -f | uniq -c
      1 perl(JSON::Color) = 0.12
      1 perl-JSON-Color = 0.12-1.fc30
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-JSON-Color-0.12-1.fc30.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F30 (https://koji.fedoraproject.org/koji/taskinfo?taskID=31283761). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the `TODO' item before building this package.
Resolution: APPROVED.

Comment 4 Gwyn Ciesla 2018-12-06 14:06:56 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-JSON-Color

Comment 5 Jitka Plesnikova 2018-12-06 14:21:58 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.