Hide Forgot
Created attachment 1517098 [details] logs with API calls and engine.log Description of problem: When creating a VM with os type as windows_2008R2x64 and GMT Standard Time we get a 400 Bad request instead of 409 conflict: 2018-12-27 18:58:26,459 - MainThread - api_utils - ERROR - Failed to create element NOT as expected: Status: 400 Reason: Bad Request Detail: [Cannot add VM. Invalid time zone for given OS type., Attribute: vmStatic] Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Create a VM with os type as windows_2008R2x64 and GMT Standard Time Actual results: 400 bad request in response body from the API Expected results: 409 conflict This bug fix is important for negative testing in RHV automation. Additional info: logs with API calls and engine.log
Version: ovirt-engine-4.3.0-0.6.alpha2.el7.noarch
Re-targeting to 4.3.1 since it is missing a patch, an acked blocker flag, or both
So to sum it up: when you create VM with os type windows_2008R2x64 and some unsupported time zone, you propose to change the response code from 400 (Bad request) to 409 (Conflict). I think that 400 (Bad request) is more appropriate, since the request parameters are not correct. I do not see how it could be a conflict since there is no existing state of the VM. I suggest that we keep the response as it is now (400 Bad request).
I agree, Lucia - Elad, can we adjust the automation to match this?
Yes, we can adjust the automation for that
Great :) Closing