Spec URL: https://ppisar.fedorapeople.org/perl-Net-Netmask/perl-Net-Netmask.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Net-Netmask/perl-Net-Netmask-1.910.400-1.fc31.src.rpm Description: Net::Netmask parses and understands IPv4 and IPv6 CIDR blocks (see <https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing> for more information on CIDR blocks). There are also functions to insert a network block into a table and then later look up network blocks by an IP address using that table. Fedora Account System Username: ppisar
URL and Source addresses are Ok. Source archive (SHA-256: 7efc6c544b76ee3923a4f3bf82d2b20ca7452e55cfd05ec65789fceab716919e) is original. Ok. Summary verified from lib/Net/Netmask.pod. Ok. Description verified from lib/Net/Netmask.pod. Ok. License verified from lib/Net/Netmask.pod and README. Ok. No XS code, noarch BuildArch is Ok. $ rpmlint perl-Net-Netmask.spec review-perl-Net-Netmask/results/perl-Net-Netmask-1.910.400-1.fc31.noarch.rpm review-perl-Net-Netmask/results/perl-Net-Netmask-1.910.400-1.fc31.src.rpm perl-Net-Netmask.noarch: W: spelling-error %description -l en_US https -> HTTP perl-Net-Netmask.noarch: W: spelling-error %description -l en_US wikipedia -> Wikipedia perl-Net-Netmask.src: W: spelling-error %description -l en_US https -> HTTP perl-Net-Netmask.src: W: spelling-error %description -l en_US wikipedia -> Wikipedia 2 packages and 1 specfiles checked; 0 errors, 4 warnings. $ rpm -q -lv -p perl-Net-Netmask-1.910.400-1.fc31.noarch.rpm 23:28:49 drwxr-xr-x 2 root root 0 févr. 28 23:00 /usr/share/doc/perl-Net-Netmask -rw-r--r-- 1 root root 3229 juil. 28 2018 /usr/share/doc/perl-Net-Netmask/CODE_OF_CONDUCT.md -rw-r--r-- 1 root root 1690 juil. 28 2018 /usr/share/doc/perl-Net-Netmask/CONTRIBUTING -rw-r--r-- 1 root root 7728 juil. 28 2018 /usr/share/doc/perl-Net-Netmask/Changes -rw-r--r-- 1 root root 21212 juil. 28 2018 /usr/share/doc/perl-Net-Netmask/README -rw-r--r-- 1 root root 324 juil. 28 2018 /usr/share/doc/perl-Net-Netmask/TODO drwxr-xr-x 2 root root 0 févr. 28 23:00 /usr/share/licenses/perl-Net-Netmask -rw-r--r-- 1 root root 18469 juil. 28 2018 /usr/share/licenses/perl-Net-Netmask/LICENSE -rw-r--r-- 1 root root 6585 févr. 28 23:00 /usr/share/man/man3/Net::Netmask.3pm.gz drwxr-xr-x 2 root root 0 févr. 28 23:00 /usr/share/perl5/vendor_perl/Net -rw-r--r-- 1 root root 27405 juil. 28 2018 /usr/share/perl5/vendor_perl/Net/Netmask.pm -rw-r--r-- 1 root root 14745 juil. 28 2018 /usr/share/perl5/vendor_perl/Net/Netmask.pod File permissions and layout are Ok. $ rpm -q --requires -p perl-Net-Netmask-1.910.400-1.fc31.noarch.rpm | sort -f | uniq -c 23:29:16 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.6.0 1 perl(Carp) 1 perl(Exporter) 1 perl(Math::BigInt) >= 1.999811 1 perl(overload) 1 perl(POSIX) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p perl-Net-Netmask-1.910.400-1.fc31.noarch.rpm perl(Net::Netmask) = 1.9104 perl-Net-Netmask = 1.910.400-1.fc31 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=33109673). Ok Resolution: Package approved.
Thank you for the review. The package actually has already existed in Fedora. I'm sorry for wasting your time. I updated the package based on this review.