Red Hat Bugzilla – Bug 168766
savage driver 1.1.27mh hang
Last modified: 2007-11-30 17:07:08 EST
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; T312461)
Description of problem:
Whenever this test program is executed, the system does hang.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. install drawline.tar.gz
2. execute drawline
Actual Results: system is hung.
Expected Results: Savage driver works.
Created attachment 119015 [details]
Created attachment 119016 [details]
Issue of hang is corrected with this patch.
Thanks for the report. I've reviewed the patch, and have some questions:
Where did the patch originate? It contains a number of changes which don't
actually do anything, ie:
Curious if you got this from somewhere on the net, or from XFree86 or X.Org
CVS, or somewhere else?
static void SavageSubsequentSolidTwoPointLine(
This will disable 2 point lines on all savage hardware. Instead of this,
does using the XaaNoSolidTwoPointLine option with the stock Red Hat driver
yield the same result?
Some of the changes in the patch seem harmless, while other parts of the
patch touch code which is shared among different savage hardware, and of
which it is unclear as to the effect they might have on other Savage
In addition to the above questions, please attach your X server log from
before and after this patch for review.
Thanks in advance.
Setting status to "NEEDINFO_REPORTER".
This patch is not original.
It is backported from savage driver 1.1.27 of RHEL4.
The cause of this issue is xaaptr->SolidBresenhamLineErrorTermBits = 14.
TermBit=14 will generate overfllow of the BCI command.
It should be xaaptr->SolidBresenhamLineErrorTermBits = 13.
I consented for the log. Please wait until tomorrow.
Thanks. We'll review the patch in greater depth, and do a risk analysis for
consideration in a future update.
(In reply to comment #6)
> Thanks. We'll review the patch in greater depth, and do a risk analysis for
> consideration in a future update.
Thanks. Please contact me if there is an update.
BTW, this isseu is solved with the following patches.
(See attached file: patch.tar.gz)
diff -urN xc/programs/Xserver/hw/xfree86/drivers/savage.orig/savage_accel.c
--- xc/programs/Xserver/hw/xfree86/drivers/savage.orig/savage_accel.c 2005-09-
20 17:41:38.000000000 +0900
+++ xc/programs/Xserver/hw/xfree86/drivers/savage/savage_accel.c 2005-09-
20 17:43:26.000000000 +0900
@@ -485,7 +485,7 @@
xaaptr->SubsequentSolidFillTrap = SavageSubsequentSolidFillTrap;
- xaaptr->SolidBresenhamLineErrorTermBits = 14;
+ xaaptr->SolidBresenhamLineErrorTermBits = 13;
/* ImageWrite */
Created attachment 119060 [details]
The patches were attached.
Created attachment 119061 [details]
The log was attached.
Thanks for the additional attachments. We'll review this during RHEL3 U7
development for potential inclusion, and update the report again.
For future reference, when attaching patches or other text files, please attach
them as uncompressed file attachments of mime-type "text/plain" or check the
"patch" checkbox in bugzilla's file attachment feature. This makes it easy to
review the patch inside the web browser directly, and speeds up our internal
I've reviewed both patches in the attachment in comment #8:
This one seems to be very obvious simple no-brainer fixes which appear
to be correct and low risk.
This one is non-obvious from the patch itself, without familiarity with
the hardware/specs/driver code. However, I have confirmed comment #5,
and reviewed the current driver source as well, and the fix seems to
be correct for this issue according to cvs commits et al.
Patches applied to CVS for XFree86-4.3.0-98.EL
XFree86-4.3.0-98.EL rpms built for RHEL3 U7 are temporarily available for
download and testing at the following URL:
Please download a copy right away, even if you can't test them right away,
as I have limited disk quota, and the files will be removed to make space
for other things soon.
Setting status to "MODIFIED", and waiting for testing feedback from
XFree86-4.3.0-98.EL.src.rpm was downloaded. I begin testing.
Rebuilding the src.rpm can potentially introduce inconsistencies or anomalies
into the build which might not be present in our official buildsystem.
As such, it is preferred if possible that you the Red Hat generated
binaries are used for testing/confirmation, as they are what will
ultimately be released as official erratum.
Thanks for testing, and also for your fast response!
> Rebuilding the src.rpm can potentially introduce inconsistencies or anomalies
> into the build which might not be present in our official buildsystem.
> As such, it is preferred if possible that you the Red Hat generated
> binaries are used for testing/confirmation, as they are what will
> ultimately be released as official erratum.
> Thanks for testing, and also for your fast response!
It has understood.
An official binary of RHEL3 U7
The tester of Toshiba will confirm it by using international Î².
I completed the test. XFree86-4.3.0-98.EL works well.
Tested by reporter, moving to PASSES_QA.
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.