Bug 169190 - compiler notices dodgy code
Summary: compiler notices dodgy code
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: kdeutils
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Than Ngo
QA Contact: Ben Levenson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-09-24 11:21 UTC by David Binderman
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-10-27 19:53:44 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Binderman 2005-09-24 11:21:56 UTC
Description of problem:
I just tried to compile Fedora development package kdeutils-3.4.2-2
with the extra compiler flag -Wall.

The compiler said

hexprinter.cc:136: warning: 'size$height' is used uninitialized in this function

The source code is

SPageSize CHexPrinter::pageFullSize( void )
{
  QPaintDeviceMetrics metric( this );
  SPageSize size;
  size.width = metric.width();
  size.width = metric.height();

  return( size );
}

Notice that size.width gets assigned to twice. Maybe size.height was
intended on the second initialisation ?

  size.width = metric.width();
  size.height = metric.height();


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Marcin Garski 2005-10-27 19:53:44 UTC
Thanks for the bug report.

Bug has been reported upstream:
http://bugs.kde.org/show_bug.cgi?id=115227

I will notify when this bugs will be fixed upstream.

Comment 2 Marcin Garski 2005-10-27 23:39:18 UTC
Bug has been fixed in KDE's SVN.


Note You need to log in before you can comment on or make changes to this bug.