Description of problem:
  Function find_dump_device() is always called with void * argument,
  but uses it as struct dump_device_s *, which is wrong.
  Found in the original diskdump patch, on FC3. Probably exists also
  in FC4 or other red-hat products.

Version-Release number of selected component (if applicable):
  kernel-2.6.12-1.1378_FC3

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
  Initial diskdump (over 2.6.9) patch has the same pb.
  - In ide-dump.c, the function ide_dump_probe returns a ide_drive_t 
    pointer.
  - In scsi_dump.c, the function scsi_dump_probe returns a scsi_device
    pointer.
  The value returned by xxx_probe is given as is to find_dump_device(),
  which use them as disk_dump_device pointers. Below, one possible patch :


diff -ru linux-2.6.12.old/drivers/block/diskdump.c
linux-2.6.12.new/drivers/block/diskdump.c
--- linux-2.6.12.old/drivers/block/diskdump.c   2005-10-02 02:49:49.000000000 +0200
+++ linux-2.6.12.new/drivers/block/diskdump.c   2005-10-03 01:47:59.000000000 +0200
@@ -689,12 +689,12 @@
        return NULL;
 }
 
-static struct disk_dump_device *find_dump_device(struct disk_dump_device *device)
+static struct disk_dump_device *find_dump_device(void *real_device)
 {
        struct disk_dump_device *dump_device;
 
        list_for_each_entry(dump_device, &disk_dump_devices, list)
-               if (device->device == dump_device->device)
+               if (dump_device->device == real_device)
                        return  dump_device;
        return NULL;
 }