Red Hat Bugzilla – Bug 169973
Review Request: python-clientform - ClientForm
Last modified: 2007-11-30 17:11:14 EST
Spec Name or Url: http://jdub.homelinux.org/files/ClientForm/ClientForm.spec
SRPM Name or Url: http://jdub.homelinux.org/files/ClientForm/lientForm-0.1.17-1.src.rpm
Description: <description here>
ClientForm is a Python module for handling HTML forms on the client side,
useful for parsing HTML forms, filling them in and returning the completed
forms to the server. It developed from a port of Gisle Aas' Perl module
HTML::Form, from the libwww-perl library, but the interface is not the same.
I'd personally name it "python-clientform" (all lowercase). Please at least
add the "python-" prefix.
The module name is ClientForm so the proper name would be python-ClientForm.
The majority of python-* in Extras seem to disagree with that (based on
quickly peeking into the source tarball names only).
The prefix is a MUST. The lowercase is up to the packager.
Ok, updated spec file and srpm at:
- *.pyo needs to be %ghost ed
Summary doesn't seem to match the package:
Summary: Powerful extensions to the standard datetime module
Is this the right Summary?
- typo in Source1, net not not:
- BSD license, text included
- spec legible
- source matches upstream
- builds on FC4
- follows python template
- owns all it's files
- rpmlint clean
(In reply to comment #6)
> Needs work:
> - *.pyo needs to be %ghost ed
Ok, I think I fixed this... (first time packaging python)
> Summary doesn't seem to match the package:
> Summary: Powerful extensions to the standard datetime module
> Is this the right Summary?
No. Blatant copy/paste error. Fixed.
> - typo in Source1, net not not:
Updated spec files and srpm at:
Looks good. APPROVED
branched, tagged, and built. thanks for the review!
Normalize summary field for easy parsing