Bug 1700923 - annobin: annocheck complains about wrong stack protector flags
Summary: annobin: annocheck complains about wrong stack protector flags
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: annobin
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-17 16:25 UTC by Florian Weimer
Modified: 2020-11-24 20:21 UTC (History)
4 users (show)

Fixed In Version: annobin-8.72-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-24 20:21:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2019-04-17 16:25:00 UTC
This:

echo 'int main (void) { return 0; }' > t.c
gcc `rpm --eval "%build_cflags %build_ldflags"` t.c
annocheck a.out

results in:

Hardened: a.out: FAIL: The binary was compiled without sufficient -fcf-protection.
Hardened: a.out: FAIL: The binary was compiled without -fstack-protector-strong.

Since the right build flags are used, this test should pass.

Package versions:

annobin-8.71-1.fc31.x86_64
binutils-2.32-11.fc31.x86_64
gcc-9.0.1-0.13.fc31.x86_64
glibc-2.29.9000-15.fc31.x86_64
redhat-rpm-config-128-1.fc30.noarch

Comment 1 Nick Clifton 2019-04-18 11:14:45 UTC
This has been caused by the recent changes to the rawhide gcc rpm, which
mean that the annobin plugin is no longer in sync with the gcc sources.
Thus when the plugin attempts to look at gcc's flag_cf_protection variable,
for example, it actually sees the value for a different variable.

The solution is to rebuild annobin against the latest version of gcc.
Rather than incrementing the NVR however I have chosen to make a small
increment to the annobin sources themselves, adding in a few more 
debugging printfs when the plugin is running in verbose mode.

Comment 2 Nick Clifton 2019-04-19 09:13:00 UTC
Fixed in annobin-8.72-1.fc31

Comment 3 Ben Cotton 2019-08-13 16:54:08 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.

Comment 4 Ben Cotton 2019-08-13 19:27:10 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 5 Jiri Danek 2019-08-20 10:34:54 UTC
I am seeing this bug with annobin 8.77 on rhel 8

.qa.[root@dhcp-145-18 ~]# echo 'int main (void) { return 0; }' > t.c
.qa.[root@dhcp-145-18 ~]# gcc `rpm --eval "%build_cflags %build_ldflags"` t.c
.qa.[root@dhcp-145-18 ~]# annocheck a.out
annocheck: Version 8.77.
Hardened: a.out: FAIL: Linked with different -fshort-enum settings.  Run with -v to see where.
Hardened: a.out: FAIL: The binary was compiled without -fstack-protector-strong.

Comment 6 Jiri Danek 2019-08-20 10:44:18 UTC
About last comment, never mind. I did `yum update` to beta, http://pulp.dist.prod.ext.phx2.redhat.com/content/beta/rhel8/8/x86_64/... and now annocheck does not report anything for the reproducer.

Comment 7 Ben Cotton 2020-11-03 15:13:24 UTC
This message is a reminder that Fedora 31 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '31'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 31 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 8 Ben Cotton 2020-11-24 20:21:28 UTC
Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.