Bug 1702375 - Presets for Fedora CoreOS should be included in fedora-release RPM for F30
Summary: Presets for Fedora CoreOS should be included in fedora-release RPM for F30
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-release
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mohan Boddu
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-23 15:36 UTC by Robert Fairley
Modified: 2019-07-29 14:18 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-23 16:51:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Robert Fairley 2019-04-23 15:36:15 UTC
Description of problem:

When building Fedora CoreOS (FCOS), a preset file [1] is added through the build configuration (fedora-coreos-config [2]) consumed by coreos-assembler [3].

We'd like the presets to be sourced from the fedora-release RPM for the FCOS preview release, which is based on F30. This will mean the switch to remove the presets from fedora-coreos-config can be done before F30, rather than wait until F31 (where the preset file has been added already [4]).

Version-Release number of selected component (if applicable):

30-1


How reproducible:

Always

Steps to Reproduce:
1. Build FCOS locally using coreos-assembler (see instructions [5]).
2. Execute `cosa run` to boot the built FCOS image.
3. In the FCOS image, execute `rpm -qf /usr/lib/systemd/system-preset/42-coreos.preset` and see that this preset file comes from `fedora-coreos-overlay-1555615086-25b3162.noarch`.

Actual results:

In step 3 above, the `42-coreos.preset` file exists and is owned by `fedora-coreos-overlay` (a package generated at build time by coreos-assembler).

```
rpm -qf /usr/lib/systemd/system-preset/42-coreos.preset
fedora-coreos-overlay-1555615086-25b3162.noarch
```

Expected results:

In step 3 above, the `42-coreos.preset` file should be named `80-coreos.preset` and owned by `fedora-release-coreos`.

Additional info:

[1] https://github.com/coreos/fedora-coreos-config/blob/8722d95bab1ddd0e2d453c4069dc773cf030beab/overlay/usr/lib/systemd/system-preset/42-coreos.preset
[2] https://github.com/coreos/fedora-coreos-config/
[3] https://github.com/coreos/coreos-assembler
[4] https://src.fedoraproject.org/rpms/fedora-release/pull-request/74
[5] https://github.com/coreos/coreos-assembler/blob/master/README.md#setup

Comment 1 Fedora Blocker Bugs Application 2019-04-23 15:42:02 UTC
Proposed as a Freeze Exception for 30-final by Fedora user sgallagh using the blocker tracking app because:

 Changes to default presets are primarily meaningful only at initial system installation, so changing this in an update would be too late.

Comment 2 Robert Fairley 2019-04-23 15:45:03 UTC
PR to fix: https://src.fedoraproject.org/rpms/fedora-release/pull-request/79

Comment 3 Adam Williamson 2019-04-23 15:50:06 UTC
Well. CoreOS is not part of the official compose / release process anyway, right? So can't CoreOS builds just pull in a fix for this from an update repo when they're built? Or is there a target to release a CoreOS build at the same time as the official release and built from the official release repo, or something?

Comment 4 Stephen Gallagher 2019-04-23 16:51:35 UTC
Based on the discussion in https://src.fedoraproject.org/rpms/fedora-release/pull-request/79 we have decided this isn't needed as an FE after all. It will be deferred to F31.

Comment 5 Robert Fairley 2019-05-08 20:47:24 UTC
Just to give an update to this BZ after more discussion in https://src.fedoraproject.org/rpms/fedora-release/pull-request/79:

This would be fine to ship as an update to F30 as new FCOS builds can pull in the update, as Adam pointed out (so no need to wait for F31).

Comment 6 Robert Fairley 2019-07-29 14:18:27 UTC
^ Meant to change status for a different bug.


Note You need to log in before you can comment on or make changes to this bug.