Bug 1702671 - glibc: Fix annocheck failures on binaries that lack BIND_NOW and PIE
Summary: glibc: Fix annocheck failures on binaries that lack BIND_NOW and PIE
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: glibc
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1639343
TreeView+ depends on / blocked
 
Reported: 2019-04-24 12:37 UTC by Florian Weimer
Modified: 2019-05-16 03:17 UTC (History)
10 users (show)

Fixed In Version: glibc-2.29.9000-17.fc31 glibc-2.28-28.fc29 glibc-2.27-39.fc28 glibc-2.29-10.fc30 glibc-2.29-12.fc30 glibc-2.28-30.fc29
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-06 00:45:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2019-04-24 12:37:48 UTC
We received guidance that all programs installed by glibc should be linked with BIND_NOW and should be PIE.

memusagestat will only be fixed by the general program changes for --enable-bind-now if this patch is backported as well:

commit f9b645b4b0a10c43753296ce3fa40053fa44606a
Author: Mike Frysinger <vapier>
Date:   Wed Apr 24 13:32:22 2019 +0200

    memusagestat: use local glibc when linking [BZ #18465]
    
    The memusagestat is the only binary that has its own link line which
    causes it to be linked against the existing installed C library.  It
    has been this way since it was originally committed in 1999, but I
    don't see any reason as to why.  Since we want all the programs we
    build locally to be against the new copy of glibc, change the build
    to be like all other programs.

Comment 1 Florian Weimer 2019-04-24 14:06:53 UTC
I posted upstream patches for review which should address this:

Extend BIND_NOW to installed programs with --enable-bind-now
https://sourceware.org/ml/libc-alpha/2019-04/msg00528.html

benchtests: Enable BIND_NOW if configured with --enable-bind-now
https://sourceware.org/ml/libc-alpha/2019-04/msg00525.html

This bug is now blocked on upstream acceptance.  I don't think we should carry downstream-specific patches for this, based on the guidance on downstream security changes.

Comment 2 Florian Weimer 2019-04-25 12:55:39 UTC
(In reply to Florian Weimer from comment #0)
> commit f9b645b4b0a10c43753296ce3fa40053fa44606a
> Author: Mike Frysinger <vapier>
> Date:   Wed Apr 24 13:32:22 2019 +0200
> 
>     memusagestat: use local glibc when linking [BZ #18465]
>     
>     The memusagestat is the only binary that has its own link line which
>     causes it to be linked against the existing installed C library.  It
>     has been this way since it was originally committed in 1999, but I
>     don't see any reason as to why.  Since we want all the programs we
>     build locally to be against the new copy of glibc, change the build
>     to be like all other programs.

This patch needs more upstream work to correct the usage of -Wl,-rpath-link:

Makeconfig: Move $(CC) to +link command variables
https://sourceware.org/ml/libc-alpha/2019-04/msg00548.html

Makeconfig: Move -Wl,-rpath-link options before library references
https://sourceware.org/ml/libc-alpha/2019-04/msg00549.html

Comment 3 Fedora Update System 2019-05-03 12:47:23 UTC
glibc-2.29-12.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f82f6f0c87

Comment 4 Fedora Update System 2019-05-03 12:47:31 UTC
glibc-2.28-30.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-73917d2c1c

Comment 5 Fedora Update System 2019-05-04 01:57:44 UTC
glibc-2.29-12.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f82f6f0c87

Comment 6 Fedora Update System 2019-05-04 02:58:21 UTC
glibc-2.28-30.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-73917d2c1c

Comment 7 Fedora Update System 2019-05-06 00:45:37 UTC
glibc-2.29-12.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2019-05-16 03:17:50 UTC
glibc-2.28-30.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.