Bug 1710262 - moby-engine shows only "dev" as Server Version
Summary: moby-engine shows only "dev" as Server Version
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: moby-engine
Version: 30
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Olivier Lemasle
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-05-15 08:18 UTC by Paul Trunk
Modified: 2020-03-09 02:27 UTC (History)
4 users (show)

Fixed In Version: moby-engine-18.09.7-4.ce.git2d0083d.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-09 02:27:46 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch to fix missing server version (391 bytes, patch)
2019-05-15 11:05 UTC, Paul Trunk
no flags Details | Diff

Description Paul Trunk 2019-05-15 08:18:41 UTC
Description of problem:

Hi, 
i switched from the (pretty old) docker package to moby-engine on my fedora servers. It is great to see that fedora is packaging upstream docker versions again. But i got some problems because the the version in "docker info" and "docker version" does not match the correct version. Instead of the correct version (e.g. 18.06.3) it only shows "dev". This breaks some scripts and my Ansible Playbooks because i need to compare the installed version for some features to support docker older version like the normal docker package on fedora.

This is also a little bit confusing because the client (cli) version shows the correct version and not "dev".

Best regards,
Paul Trunk

 


Version-Release number of selected component (if applicable):

Name         : moby-engine
Version      : 18.06.3
Release      : 2.ce.gitd7080c1.fc30
Architecture : x86_64
Size         : 226 M
Quelle       : moby-engine-18.06.3-2.ce.gitd7080c1.fc30.src.rpm
Repository   : @System
Aus Paketque : fedora


How reproducible:

Install moby-engine and run "docker version"


Actual results:

Client:
 Version:           18.06.3
 API version:       1.38
 Go version:        go1.12
 Git commit:        d7080c1
 Built:             Thu Mar 28 16:22:13 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          dev
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.12
  Git commit:       d7080c1
  Built:            Thu Mar 28 16:21:35 2019
  OS/Arch:          linux/amd64
  Experimental:     false


Expected results:

[...]
Server:
 Engine:
  Version:          18.06.3
[...]

Comment 1 Paul Trunk 2019-05-15 11:05:34 UTC
Created attachment 1568953 [details]
Patch to fix missing server version

I could fix this problem with exporting the VERSION environment variable during the engine build process (i've checked the make.sh script to realize "dev" ist just the default if VERSION is not defined. I just modifed the moby-engine.spec file to do this.

I have attached a small patch file.

Comment 2 David Michael 2019-05-15 11:37:50 UTC
I have submitted https://bodhi.fedoraproject.org/updates/FEDORA-2019-54864c8857 to updates-testing which seems to show the correct version.  Can you test that?

Comment 3 Fedora Update System 2019-05-15 11:38:00 UTC
moby-engine-18.09.6-1.ce.git481bc77.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-54864c8857

Comment 4 Paul Trunk 2019-05-15 12:09:07 UTC
Yes, i can confirm moby-engine-18.09.6-1.ce.git481bc77.fc30 is working fine. The server version is correct now.

Thank you very much!

Comment 5 Fedora Update System 2019-05-16 02:36:13 UTC
moby-engine-18.09.6-1.ce.git481bc77.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-54864c8857

Comment 6 Olivier Samyn 2019-06-20 09:28:45 UTC
This new package seems to conflict with runc (I have buildah installed)


Problem: problem with installed package runc-2:1.0.0-93.dev.gitb9b6cc6.fc30.x86_64
 - package moby-engine-18.09.6-1.ce.git481bc77.fc30.x86_64 conflicts with runc provided by runc-2:1.0.0-93.dev.gitb9b6cc6.fc30.x86_64
 - cannot install the best update candidate for package moby-engine-18.06.3-2.ce.gitd7080c1.fc30.x86_64

Comment 7 Fedora Update System 2019-07-12 16:55:15 UTC
FEDORA-2019-1ffec936f0 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1ffec936f0

Comment 8 Fedora Update System 2019-07-13 00:58:05 UTC
moby-engine-18.09.7-3.ce.git2d0083d.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1ffec936f0

Comment 9 Fedora Update System 2019-07-13 12:43:29 UTC
FEDORA-2019-572b06a0f7 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-572b06a0f7

Comment 10 Fedora Update System 2019-07-14 03:07:41 UTC
moby-engine-18.09.7-4.ce.git2d0083d.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-572b06a0f7

Comment 11 Fedora Update System 2020-03-09 02:27:46 UTC
moby-engine-18.09.7-4.ce.git2d0083d.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.