Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kasablanca-0.4.0.2-1.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kasablanca-0.4.0.2-1.src.rpm Description: Kasablanca is an ftp client for KDE, among its features are currently encryption (auth tls) support, fxp, site bookmarks, and queued transfers.
* Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop) * Please remove the CVS tag id on top of the spec file (it mentions kbear.spec) * As in digikamimageplugins : * please drop the debug_package test in make install * please re-add the gtk-update-cache call
%changelog * Sat Oct 22 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.4.0.2-2 - .desktop: --add-category=Application - %%post,%%postun: gtk-update-icon-cache - drop CVS tags - drop %%{?debug_package} Spec Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/SPECS/kasablanca-0.4.0.2-2.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/kasablanca-0.4.0.2-2.src.rpm
"Application" is not a registered desktop entry category, I wonder if it's still needed in recent distro versions: http://standards.freedesktop.org/menu-spec/latest/apa.html
> "Application" is not a registered desktop entry category It used to, maybe it was removed recently (personally, I considered it mostly superfluous anyway)
Review for release 2: * RPM name is OK * Source kasablanca-0.4.0.2.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint of kasablanca looks OK * File list of kasablanca looks OK * Works fine. APPROVED