Bug 1720333 - Template Wizard accepts malformed MAC address
Summary: Template Wizard accepts malformed MAC address
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 2.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 2.1.0
Assignee: Phillip Bailey
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-06-13 17:24 UTC by Radim Hrazdil
Modified: 2019-11-04 15:07 UTC (History)
4 users (show)

Fixed In Version: 4.2.0-0.nightly-2019-08-15-073735
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-04 15:07:41 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt web-ui-components pull 527 0 None closed Add MAC address validation to Create VM wizard 2020-12-21 07:05:08 UTC
Github openshift console pull 2285 0 None closed Bug 1720333: Validate MAC when adding a NIC 2020-12-21 07:05:06 UTC

Description Radim Hrazdil 2019-06-13 17:24:43 UTC 
Description of problem:
Template can be created successfully with a malformed MAC address and a user gets a failure when trying to create a VM using the template.

There should be a validation in place to make sure that the created template is valid. The same validation should also be in VM 

Creating VM from such template then fails on 

Version-Release number of selected component (if applicable):
kubevirt-web-ui-container-v2.0.0-14.7
HCO_BUNDLE_REGISTRY_TAG: v2.0.0-27

How reproducible:
100%

Steps to Reproduce:
1. Create a template with NIC with MAC set to '24:42' or similar invalid value
2.
3.

Actual results:
template can be created

Expected results:
User should not be allowed to proceed in the wizard

Additional info:
Comment 1 Phillip Bailey 2019-08-09 12:15:16 UTC 
Network interfaces can also be added through the "Network Interfaces" tab in the VM details view. It makes sense to validate the MAC there, as well. This is being accomplished in a PR[1] submitted to the openshift/console repository.

[1] https://github.com/openshift/console/pull/2285
Note You need to log in before you can comment on or make changes to this bug.