Bug 1722330

Set target to 8.1 Beta, please correct it if it's wrong. Thanks.

This issue could be reproduce on RHEL8.1 and RHEL7.7.

Hi Eduardo，

I see this is targeted to 8.2. Do you think the ds-identify.sh could also be added to RHEL7.x?

Thanks,
Pengpeng

(In reply to Pengpeng Sun from comment #6)
> Hi Eduardo，
> 
> I see this is targeted to 8.2. Do you think the ds-identify.sh could also be
> added to RHEL7.x?
> 
> Thanks,
> Pengpeng

ds-identify was added to rhel-7.8 branch (and will be added to rhel-8.2 branch:

commit 6954486d1318a3d1aa5bbcfcb119bcfcb73618bf
Author: Eduardo Otubo <otubo>
Date:   Fri Sep 6 12:12:11 2019 +0200

    Fix for network configuration not persisting after reboot
    
    RH-Author: Eduardo Otubo <otubo>
    Message-id: <20190906121211.23172-1-otubo>
    Patchwork-id: 90300
    O-Subject: [RHEL-7.8/RHEL-8.1.0 cloud-init PATCH] Fix for network configuration not persisting after reboot
    Bugzilla: 1593010
    RH-Acked-by: Mohammed Gamal <mgamal>
    RH-Acked-by: Miroslav Rezanina <mrezanin>
    
    The reasons the configuration does not persist after reboot includes
    different aspects and they're all fixed on this patch:
    
      1) The rpm package doesn't include the systemd-generator and
    ds-identify. The systemd-generator is called early in the boot process
    that calls ds-identify to check if there's any Data Source available in
    the current boot. In the current use case, the Data Source is removed
    from the VM on the second boot, this means cloud-init should disable
    itself in order to keep the configuration it did in the first boot.
    
      2) Even after adding those scripts, cloud-init was still being
    executed and the configurations were being lost. The reason for this is
    that the cloud-init systemd units had a wrong dependency
    
         WantedBy: multi-user.target
    
         Which would start them every time no matter the return of
    ds-identify. The fix is to replace the dependency by the systemd unit to
    cloud-init.target, which is the main cloud-init target enabled - or in
    this case, disabled by ds-identify. The file cloud-init.target was also
    missing on rpm package.
    
    After adding both scripts, the main cloud-init systemd target and
    adjusting the systemd dependencies the configuration persists after
    reboots and shutdowns.
    
    Signed-off-by: Eduardo Otubo <otubo>
    Signed-off-by: Miroslav Rezanina <mrezanin>

Hi Eduardo,

Our team is checking the new 8.2 alpha build, found ds-identify is not there, could you please double-check it?

Thanks,
Pengpeng

(In reply to Pengpeng Sun from comment #8)
> Hi Eduardo,
> 
> Our team is checking the new 8.2 alpha build, found ds-identify is not
> there, could you please double-check it?
> 
> Thanks,
> Pengpeng

I can confirm the above mentioned patch in comment #7 is in the rhel-8.2.0 branch of cloud-init, perhaps it's be present in the next build?

(In reply to Eduardo Otubo from comment #9)
> (In reply to Pengpeng Sun from comment #8)
> > Hi Eduardo,
> > 
> > Our team is checking the new 8.2 alpha build, found ds-identify is not
> > there, could you please double-check it?
> > 
> > Thanks,
> > Pengpeng
> 
> I can confirm the above mentioned patch in comment #7 is in the rhel-8.2.0
> branch of cloud-init, perhaps it's be present in the next build?

Just as a reference, the package I checked is cloud-init-18.5-8.el8. You should use this package (or version above) to have ds-identify included.